From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hartmut Goebel Subject: Re: [PATCH 3/6] gnu: Add python-orderedmultidict. Date: Thu, 3 Nov 2016 22:58:27 +0100 Message-ID: References: <20161103105604.2937-1-dannym@scratchpost.org> <20161103105604.2937-4-dannym@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2Q1q-0007cp-Ga for guix-devel@gnu.org; Thu, 03 Nov 2016 17:58:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2Q1n-000705-Cm for guix-devel@gnu.org; Thu, 03 Nov 2016 17:58:34 -0400 Received: from mail-out.m-online.net ([2001:a60:0:28:0:1:25:1]:58659) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c2Q1n-0006zZ-6I for guix-devel@gnu.org; Thu, 03 Nov 2016 17:58:31 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3t8zPK4TV6z3hjXn for ; Thu, 3 Nov 2016 22:58:29 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3t8zPK3R5Czvl0v for ; Thu, 3 Nov 2016 22:58:29 +0100 (CET) Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id zOeQ82OdsoNL for ; Thu, 3 Nov 2016 22:58:28 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-188-174-138-33.dynamic.mnet-online.de [188.174.138.33]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for ; Thu, 3 Nov 2016 22:58:27 +0100 (CET) Received: from thisbe.goebel-consult.de (hermia.goebel-consult.de [192.168.110.7]) by hermia.goebel-consult.de (Postfix) with ESMTP id 5F95B604D7 for ; Thu, 3 Nov 2016 22:58:27 +0100 (CET) In-Reply-To: <20161103105604.2937-4-dannym@scratchpost.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org Am 03.11.2016 um 11:56 schrieb Danny Milosavljevic: > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'fix-tests > + (lambda _ > + (and (zero? (system* "touch" "tests/__init__.py")))))))) Maybe add a note like: "The packages uses nosetest for running the tests. Adding this initfile allows to run the test suite without requiring nosetest." > + (synopsis "Python Ordered Multivalue Dictionary - omdict.") Trailing period > + (description "This package contains Ordered Multivalue Dictionary = - omdict > +- for Python.") Please be more verbose here. Maybe the description could be enhanced using text from the setup.py: A multivalue dictionary is a dictionary that can store multiple values for the same key. An ordered multivalue dictionary is a multivalue dictionary that retains the order of insertions and deletions. --=20 Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible |