unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Hartmut Goebel <h.goebel@crazy-compilers.com>
To: guix-devel@gnu.org
Subject: Re: [PATCH 3/6] gnu: Add python-orderedmultidict.
Date: Thu, 3 Nov 2016 22:58:27 +0100	[thread overview]
Message-ID: <c88e1e11-8552-08a2-afb4-62d37506bd94@crazy-compilers.com> (raw)
In-Reply-To: <20161103105604.2937-4-dannym@scratchpost.org>

Am 03.11.2016 um 11:56 schrieb Danny Milosavljevic:
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'fix-tests
> +           (lambda _
> +             (and (zero? (system* "touch" "tests/__init__.py"))))))))

Maybe add a note like: "The packages uses nosetest for running the
tests. Adding this initfile allows to run the test suite without
requiring nosetest."

> +    (synopsis "Python Ordered Multivalue Dictionary - omdict.")
Trailing period
> +    (description "This package contains Ordered Multivalue Dictionary - omdict
> +- for Python.")

Please be more verbose here. Maybe the description could be enhanced
using text from the setup.py:

    A multivalue dictionary is a dictionary that can store multiple
    values for the
    same key. An ordered multivalue dictionary is a multivalue
    dictionary that
    retains the order of insertions and deletions.


-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

  reply	other threads:[~2016-11-03 21:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-03 10:55 [PATCH 0/6] Enable lots of sqlalchemy features Danny Milosavljevic
2016-11-03 10:55 ` [PATCH 1/6] gnu: Enable python-psycopg2 support in python-sqlalchemy Danny Milosavljevic
2016-11-03 21:42   ` Hartmut Goebel
2016-11-03 22:14     ` Danny Milosavljevic
2016-11-03 10:56 ` [PATCH 2/6] gnu: Add python-pycodestyle Danny Milosavljevic
2016-11-03 21:49   ` Hartmut Goebel
2016-11-03 10:56 ` [PATCH 3/6] gnu: Add python-orderedmultidict Danny Milosavljevic
2016-11-03 21:58   ` Hartmut Goebel [this message]
2016-11-03 10:56 ` [PATCH 4/6] gnu: Add python-furl Danny Milosavljevic
2016-11-03 22:01   ` Hartmut Goebel
2016-11-03 10:56 ` [PATCH 5/6] gnu: Add python-flask-babel Danny Milosavljevic
2016-11-03 22:05   ` Hartmut Goebel
2016-11-03 10:56 ` [PATCH 6/6] gnu: Enable passlib, babel, cryptography, pyt, psycopg2, furl, flask-babel and pytest in python-sqlalchemy-utils Danny Milosavljevic
2016-11-03 22:15   ` Hartmut Goebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c88e1e11-8552-08a2-afb4-62d37506bd94@crazy-compilers.com \
    --to=h.goebel@crazy-compilers.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).