From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wL1bA6j1x18tdwAA0tVLHw (envelope-from ) for ; Wed, 02 Dec 2020 20:14:32 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 8C/IOqf1x18QdAAA1q6Kng (envelope-from ) for ; Wed, 02 Dec 2020 20:14:31 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 003919402A7 for ; Wed, 2 Dec 2020 20:14:30 +0000 (UTC) Received: from localhost ([::1]:57396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kkYWD-0004qH-NS for larch@yhetil.org; Wed, 02 Dec 2020 15:14:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45474) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkYVn-0004pz-M4 for guix-devel@gnu.org; Wed, 02 Dec 2020 15:14:03 -0500 Received: from 102b.relay.hey.com ([204.62.115.200]:32815) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkYVk-0005YA-Py for guix-devel@gnu.org; Wed, 02 Dec 2020 15:14:03 -0500 Received: from hey.com (bigip-vip-new.rw-ash-int.37signals.com [10.20.0.24]) by 102.relay.hey.com (Postfix) with ESMTP id 6EAAA820B5; Wed, 2 Dec 2020 20:13:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hey.com; s=heymail; t=1606940038; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to; bh=UXZ4qWEUxyeW+8RMCn9QlrybVrp3Z6c/ran6nREDkns=; b=BMaMU1ZNHHV0tLl/4yw+KeI7zT428o6HTB2pMg6AeP6dgbamUjs2ySsMSYLtPpU5oSTWF4 0d31fHYJ9IoOkbQPMTpxwkY8ldGHX3G8cWyVMNp1YxW+91ElCdUg23RDO++/c8Nfvz+n6N 9+R3lbDwcAk+eEk0Raqt9H9SgQQDbxMt3ZR/XEAm1BM494I/9Y/slD1xyq1sDvVq8UCiq4 aWMcSkcNhhVnnSpiDAWL2lyxcsMxpJ0aZGh3Bs4ck3VBs6+aFNPJp4+oqCeqD7M9XG+LUy ohWVEDNkweD7JtahrOp75gB4uKf9ArowJCcpc07p8nMBIifCqSKheLgM8i/t9w== Date: Wed, 02 Dec 2020 20:13:56 +0000 From: Ryan Prior To: Raghav Gururajan , Danny Milosavljevic , Mark H Weaver Cc: Development of GNU Guix and the GNU System distribution Message-ID: In-Reply-To: <87mtywf35o.fsf@netris.org> Subject: Re: Questionable "cosmetic changes" commits Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5fc7f585644cd_2d2df07798b"; charset=UTF-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=204.62.115.200; envelope-from=ryanprior@hey.com; helo=102b.relay.hey.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.48 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=hey.com header.s=heymail header.b=BMaMU1ZN; dmarc=pass (policy=quarantine) header.from=hey.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 003919402A7 X-Spam-Score: -2.48 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: Fq+ke+R+bUfm ----==_mimepart_5fc7f585644cd_2d2df07798b Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Mark! On December 2, 2020, Mark H Weaver wrote: > We all have our own personal preferences of how best to indent scheme > code, but if more of us adopted the habit of needlessly reordering > fields and reindenting code of every package we touch, as one of us > seems to have done, it could get out of hand quickly. I don't particularly hold any opinion about stylistic commits except that I prefer tools like gofmt, Python's Black and standard.js which enforce uniform code style, and would use such a tool for my Guile code if it exists. I do think it's important to acknowledge that the commits written by Raghav were part of his internship and advised by his mentors who signed off on the commits, so it's not like these changes were unsolicited and materialized out of nowhere. ----==_mimepart_5fc7f585644cd_2d2df07798b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Mark!

On December 2, 2020, Mark H Weaver <= mhw@netris.org> wrote:
We all have our own personal p= references of how best to indent scheme
code, but if more of us adopte= d the habit of needlessly reordering
fields and reindenting code of ev= ery package we touch, as one of us
seems to have done, it could get ou= t of hand quickly.

I don't particularly hold any opi= nion about stylistic commits except that I prefer tools like gofmt, Pytho= n's Black and standard.js which enforce uniform code style, and would use= such a tool for my Guile code if it exists.

I do think it's impor= tant to acknowledge that the commits written by Raghav were part of his i= nternship and advised by his mentors who signed off on the commits, so it= 's not like these changes were unsolicited and materialized out of nowher= e.
----==_mimepart_5fc7f585644cd_2d2df07798b--