From mboxrd@z Thu Jan 1 00:00:00 1970 From: kei@openmailbox.org Subject: Re: [PATCH] gnu: Add gnome-sudoku and qqwing Date: Mon, 11 Apr 2016 12:06:17 -0400 Message-ID: References: <75cba97de5a5a0c6ff4eb5af47ee72a2@openmailbox.org> <20160411044408.GA26072@jasmine> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=_7d2ccf8f0c721fe011af65a88911b0b9" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apeMD-0001JE-BK for guix-devel@gnu.org; Mon, 11 Apr 2016 12:06:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1apeM9-00036P-9W for guix-devel@gnu.org; Mon, 11 Apr 2016 12:06:33 -0400 Received: from smtp5.openmailbox.org ([62.4.1.39]:58586) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apeM8-00036K-U9 for guix-devel@gnu.org; Mon, 11 Apr 2016 12:06:29 -0400 In-Reply-To: <20160411044408.GA26072@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org --=_7d2ccf8f0c721fe011af65a88911b0b9 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed On 2016-04-11 00:44, Leo Famulari wrote: > On Sun, Apr 10, 2016 at 11:23:51PM -0400, kei@openmailbox.org wrote: >> I'm attempting something new with this patch. I want to add >> gnome-sudoku to >> the tree, and it requires qqwing as a dependency. QQwing didn't seem >> to fit >> in any other category so I put it in it's own file. >> >> Guidance would be appreciated! Thank you in advance. > > Thanks for trying something new :) > > I think they both would fit in games.scm. Can you put them there in a > revised patch series? > I decided to add gnome-sudoku to gnome.scm because of how a new version is released with each new version of GNOME. Also, since qqwing seems to be used only by gnome-sudoku, I moved it over to gnome.scm as well. >> * gnu/packages/qqwing.scm (qqwing): New variable. >> * gnu/packages/gnome.scm (gnome-sudoku): New variable. > > We like to add packages as separate commits. Can you separate them in > the revised patch series? > > Also, remember to add a copyright line for yourself at the top of the > file. > >> +(define-public gnome-sudoku > > Okay with the changes requested above. > >> +(define-public qqwing > > [...] > >> + (uri (string-append >> + "mirror://debian/pool/main/q/qqwing/" >> + name "_" version ".orig.tar.gz")) > > Why download the source code from Debian instead of https://qqwing.com > (which redirects to GitHub)? > I switched to using the link at the bottom of the page. >> + (synopsis "Software for working with sudoku puzzles.") > > Can you capitalize Sudoku here? Also be sure to run `guix lint` on > these > packages; the linter should complain about the period in the synopsis. > >> + (description >> + "QQwing is software for generating and solving Sudoku puzzles.") > > Sometimes there isn't much to say. But can you try to add a little more > here? You could look for inspiration in the man page. This is as extensive as the descriptions for this software get in its own documentation as well as across many different software repositories. Any ideas for what else to put here? --=_7d2ccf8f0c721fe011af65a88911b0b9 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0002-gnu-Add-gnome-sudoku.patch Content-Disposition: attachment; filename=0002-gnu-Add-gnome-sudoku.patch; size=1993 RnJvbSBjZWYyYzU2MTI5NzM5OWNhYWQzZTZmY2VlYTlmNzI5OWQ5M2U1YzA0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZWkgWWFtYXNoaXRhIDxrZWlAb3Blbm1haWxib3gub3JnPgpE YXRlOiBNb24sIDExIEFwciAyMDE2IDExOjU4OjM0IC0wNDAwClN1YmplY3Q6IFtQQVRDSCAyLzJd IGdudTogQWRkIGdub21lLXN1ZG9rdS4KCiogZ251L3BhY2thZ2VzL2dub21lLnNjbSAoZ25vbWUt c3Vkb2t1KTogTmV3IHZhcmlhYmxlLgotLS0KIGdudS9wYWNrYWdlcy9nbm9tZS5zY20gfCAzNSAr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDM1IGlu c2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvZ25vbWUuc2NtIGIvZ251L3Bh Y2thZ2VzL2dub21lLnNjbQppbmRleCA2YmExZmM1Li5kYjk1YzA4IDEwMDY0NAotLS0gYS9nbnUv cGFja2FnZXMvZ25vbWUuc2NtCisrKyBiL2dudS9wYWNrYWdlcy9nbm9tZS5zY20KQEAgLTIyMjks NiArMjIyOSw0MSBAQCBmbG9hdGluZyBpbiBhbiBvY2VhbiB1c2luZyBvbmx5IHlvdXIgYnJhaW4g YW5kIGEgbGl0dGxlIGJpdCBvZiBsdWNrLiIpCiAgICAgICJRUXdpbmcgaXMgc29mdHdhcmUgZm9y IGdlbmVyYXRpbmcgYW5kIHNvbHZpbmcgU3Vkb2t1IHB1enpsZXMuIikKICAgICAobGljZW5zZSBs aWNlbnNlOmdwbDIrKSkpCiAKKyhkZWZpbmUtcHVibGljIGdub21lLXN1ZG9rdQorICAocGFja2Fn ZQorICAgIChuYW1lICJnbm9tZS1zdWRva3UiKQorICAgICh2ZXJzaW9uICIzLjE4LjIiKQorICAg IChzb3VyY2UKKyAgICAgKG9yaWdpbgorICAgICAgIChtZXRob2QgdXJsLWZldGNoKQorICAgICAg ICh1cmkgKHN0cmluZy1hcHBlbmQgIm1pcnJvcjovL2dub21lL3NvdXJjZXMvIiBuYW1lICIvIgor ICAgICAgICAgICAgICAgICAgICAgICAgICAgKHZlcnNpb24tbWFqb3IrbWlub3IgdmVyc2lvbikg Ii8iCisgICAgICAgICAgICAgICAgICAgICAgICAgICBuYW1lICItIiB2ZXJzaW9uICIudGFyLnh6 IikpCisgICAgICAgKHNoYTI1NgorICAgICAgICAoYmFzZTMyCisgICAgICAgICAiMWI2MHoyMmZq cmp6c3owa2ZodjBrZmh2aWd6bjU0d3ZoOXMzMXpybHA3c3gyaDJkeHZzZiIpKSkpCisgICAgKGJ1 aWxkLXN5c3RlbSBnbGliLW9yLWd0ay1idWlsZC1zeXN0ZW0pCisgICAgKG5hdGl2ZS1pbnB1dHMK KyAgICAgYCgoInBrZy1jb25maWciICxwa2ctY29uZmlnKQorICAgICAgICgiZGVza3RvcC1maWxl LXV0aWxzIiAsZGVza3RvcC1maWxlLXV0aWxzKQorICAgICAgICgiaW50bHRvb2wiICxpbnRsdG9v bCkKKyAgICAgICAoIml0c3Rvb2wiICxpdHN0b29sKQorICAgICAgICgieG1sbGludCIgLGxpYnht bDIpKSkKKyAgICAoaW5wdXRzCisgICAgIGAoKCJndGsrIiAsZ3RrKykKKyAgICAgICAoImpzb24t Z2xpYiIgLGpzb24tZ2xpYikKKyAgICAgICAoImxpYmdlZSIgLGxpYmdlZSkKKyAgICAgICAoImxp YnJzdmciICxsaWJyc3ZnKQorICAgICAgICgicXF3aW5nIiAscXF3aW5nKSkpCisgICAgKGhvbWUt cGFnZSAiaHR0cHM6Ly93aWtpLmdub21lLm9yZy9BcHBzL1N1ZG9rdSIpCisgICAgKHN5bm9wc2lz ICJKYXBhbmVzZSBsb2dpYyBnYW1lIikKKyAgICAoZGVzY3JpcHRpb24KKyAgICAgIlN1ZG9rdSBp cyBhIEphcGFuZXNlIGxvZ2ljIGdhbWUgdGhhdCBleHBsb2RlZCBpbiBwb3B1bGFyaXR5IGluIDIw MDUuCitHTk9NRSBTdWRva3UgaXMgbWVhbnQgdG8gaGF2ZSBhbiBpbnRlcmZhY2UgYXMgc2ltcGxl IGFuZCB1bm9ic3RydXNpdmUgYXMKK3Bvc3NpYmxlIHdoaWxlIHN0aWxsIHByb3ZpZGluZyBmZWF0 dXJlcyB0aGF0IG1ha2UgcGxheWluZyBkaWZmaWN1bHQgU3Vkb2t1Cittb3JlIGZ1bi4iKQorICAg IChsaWNlbnNlIGxpY2Vuc2U6Z3BsMispKSkKKwogKGRlZmluZS1wdWJsaWMgZ25vbWUtdGVybWlu YWwKICAgKHBhY2thZ2UKICAgICAobmFtZSAiZ25vbWUtdGVybWluYWwiKQotLSAKMi43LjMKCg== --=_7d2ccf8f0c721fe011af65a88911b0b9 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-gnu-Add-qqwing.patch Content-Disposition: attachment; filename=0001-gnu-Add-qqwing.patch; size=1770 RnJvbSBlZTRkNjk2MmE0YTk2NjZlMDI2MjI0NzIyYzdlOGM4Zjk3MjA1ZTIyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZWkgWWFtYXNoaXRhIDxrZWlAb3Blbm1haWxib3gub3JnPgpE YXRlOiBNb24sIDExIEFwciAyMDE2IDExOjU3OjE0IC0wNDAwClN1YmplY3Q6IFtQQVRDSCAxLzJd IGdudTogQWRkIHFxd2luZy4KCiogZ251L3BhY2thZ2VzL2dub21lLnNjbSAocXF3aW5nKTogTmV3 IHZhcmlhYmxlLgotLS0KIGdudS9wYWNrYWdlcy9nbm9tZS5zY20gfCAyMiArKysrKysrKysrKysr KysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBh L2dudS9wYWNrYWdlcy9nbm9tZS5zY20gYi9nbnUvcGFja2FnZXMvZ25vbWUuc2NtCmluZGV4IDVj MmNmMDEuLjZiYTFmYzUgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9nbm9tZS5zY20KKysrIGIv Z251L3BhY2thZ2VzL2dub21lLnNjbQpAQCAtMTUsNiArMTUsNyBAQAogOzs7IENvcHlyaWdodCDC qSAyMDE2IFJlbmUgU2FhdmVkcmEgPHJlbm5lc0BvcGVubWFpbGJveC5vcmc+CiA7OzsgQ29weXJp Z2h0IMKpIDIwMTYgSm9jaGVtIFJhYXQgPGpjaG1ydEByaXNldXAubmV0PgogOzs7IENvcHlyaWdo dCDCqSAyMDE2IFJlbmUgU2FhdmVkcmEgPHJlbm5lc0BvcGVubWFpbGJveC5vcmc+Cis7OzsgQ29w eXJpZ2h0IMKpIDIwMTYgS2VpIFlhbWFzaGl0YSA8a2VpQG9wZW5tYWlsYm94Lm9yZz4KIDs7Owog Ozs7IFRoaXMgZmlsZSBpcyBwYXJ0IG9mIEdOVSBHdWl4LgogOzs7CkBAIC0yMjA3LDYgKzIyMDgs MjcgQEAgYW5kIG90aGVyIHNlY3JldHMuICBJdCBjb21tdW5pY2F0ZXMgd2l0aCB0aGUgXCJTZWNy ZXQgU2VydmljZVwiIHVzaW5nIERCdXMuIikKIGZsb2F0aW5nIGluIGFuIG9jZWFuIHVzaW5nIG9u bHkgeW91ciBicmFpbiBhbmQgYSBsaXR0bGUgYml0IG9mIGx1Y2suIikKICAgICAobGljZW5zZSBs aWNlbnNlOmdwbDIrKSkpCiAKKyhkZWZpbmUtcHVibGljIHFxd2luZworICAocGFja2FnZQorICAg IChuYW1lICJxcXdpbmciKQorICAgICh2ZXJzaW9uICIxLjMuNCIpCisgICAgKHNvdXJjZSAob3Jp Z2luCisgICAgICAgICAgICAgIChtZXRob2QgdXJsLWZldGNoKQorICAgICAgICAgICAgICAodXJp IChzdHJpbmctYXBwZW5kCisgICAgICAgICAgICAgICAgICAgICJodHRwczovL3Fxd2luZy5jb20v IgorICAgICAgICAgICAgICAgICAgICBuYW1lICItIiB2ZXJzaW9uICIudGFyLmd6IikpCisgICAg ICAgICAgICAgIChzaGEyNTYKKyAgICAgICAgICAgICAgIChiYXNlMzIKKyAgICAgICAgICAgICAg ICAiMGJ3MHBhcHlxamcyMno2aXJmMzZnczU0eTgyMzZ3YTM3YjZneW4yaDFzcHk2NW43NmxxcCIp KSkpCisgICAgKGJ1aWxkLXN5c3RlbSBnbnUtYnVpbGQtc3lzdGVtKQorICAgIChuYXRpdmUtaW5w dXRzCisgICAgICBgKCgicGtnLWNvbmZpZyIgLHBrZy1jb25maWcpKSkKKyAgICAoaG9tZS1wYWdl ICJodHRwczovL3Fxd2luZy5jb20vIikKKyAgICAoc3lub3BzaXMgIlNvZnR3YXJlIGZvciB3b3Jr aW5nIHdpdGggU3Vkb2t1IHB1enpsZXMiKQorICAgIChkZXNjcmlwdGlvbgorICAgICAiUVF3aW5n IGlzIHNvZnR3YXJlIGZvciBnZW5lcmF0aW5nIGFuZCBzb2x2aW5nIFN1ZG9rdSBwdXp6bGVzLiIp CisgICAgKGxpY2Vuc2UgbGljZW5zZTpncGwyKykpKQorCiAoZGVmaW5lLXB1YmxpYyBnbm9tZS10 ZXJtaW5hbAogICAocGFja2FnZQogICAgIChuYW1lICJnbm9tZS10ZXJtaW5hbCIpCi0tIAoyLjcu MwoK --=_7d2ccf8f0c721fe011af65a88911b0b9--