From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id +P3xDR7ADmbFggEAqHPOHw:P1 (envelope-from ) for ; Thu, 04 Apr 2024 16:58:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id +P3xDR7ADmbFggEAqHPOHw (envelope-from ) for ; Thu, 04 Apr 2024 16:58:38 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=futurile.net header.s=selector1 header.b=lZ6EWgri; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1712242718; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=LbN2PUjJGmx/bilbm8FvNoeUJshzw5BBH139wQQRS2A=; b=n2tutLUbjRjF3mvZgfJPw2wUb4Kw+3fCbvqmg5nB2oPPZVGJLKQZE0rRTm7ZDIGH7bqzLk eWB9QRbM9CAfiqfuQsumVfuLOAFNVxxhXWS5Pk/h6mfzG7KnbuWeJ5T7YEPNAwhe5CmaAO uKMcmRsK1ko84nCGWECW350bR/2oVkqxtFT5yDO1yTTSHwDMKVErqdoF58DAB0srevbjCv bKvaACCVmJlW5TiF2i14Exym+gXb/9eKo9M0rK+PTCyjYuNPwIlICu6vQ7HxI2HwS9c2Ak Q7lBowC2yAiO+uthG4Edz5bPsXHmNqAgDwpF1G+S6/1qHFfX/xNQGvhPbMH7uw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=futurile.net header.s=selector1 header.b=lZ6EWgri; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1712242718; a=rsa-sha256; cv=none; b=UHWEsYQIa4ZEYI+ZCf+SE/SCgZgvmksQAAEXAnM+5BgoCmZhyxFLcJlzgKsT3O2DrNgyZN /EDHdbtIVqfHC6Ow50OqnA2qMufEIeIfgJ+sv7PpkcauWO8P9zMmqGIfsWL70AMmQLlQSl x6DDKLqrVVoPcRd5qVRatI9Li6gtBWzmKM23cxyygFheUDmBX8oGQHoy2wmsRPzT2t+pIA ighOlQaB5ftzRpSHRpY1sraL4qXXHa+oFzdkeuO4ufHlk+adwZHyrwCo+c+mTlwDoSMtBn kvqJKFptwlfvrEVB+rWJ+ZvW2uSiG8QHXVZ/G2wDKwSMeJ+rH3kDZxmQGc+t4g== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2218B627A8 for ; Thu, 04 Apr 2024 16:58:38 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rsOXI-0007uQ-Up; Thu, 04 Apr 2024 10:57:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rsOXH-0007uB-5t for guix-devel@gnu.org; Thu, 04 Apr 2024 10:57:51 -0400 Received: from mailtransmit04.runbox.com ([2a0c:5a00:149::25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rsOXE-0008S4-3Y for guix-devel@gnu.org; Thu, 04 Apr 2024 10:57:50 -0400 Received: from mailtransmit03.runbox ([10.9.9.163] helo=aibo.runbox.com) by mailtransmit04.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1rsOX7-000kbx-BT for guix-devel@gnu.org; Thu, 04 Apr 2024 16:57:41 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=futurile.net; s=selector1; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date; bh=LbN2PUjJGmx/bilbm8FvNoeUJshzw5BBH139wQQRS2A=; b=lZ6EWgrim8JsIgvZYM7uG+TkC7 7N64XNs2yz+jh4r+uFhjYuj7cM0GI1TrCr0oNHFxFWd3dzjvZrBOFCb1JmHO0atfreln0K02J9s6W VdzQVkiInAv1EPowEtPZBaymDTjMm2GRM4agizuiS9EkrTO7qDd+owW3kt+H1lXj6xVEEs/u3agrK 3XvSZZUsxgxWJr6t71QVdM/SvlFgHVSm804z0JqF2MTB4Z8DEQ4fnFJv144cpxxn2pTz7IIeXpNfB xpeIqlreEBFDs1hdT40vqgRUrnxKlusXO1rxqmreW7D/n99jchYliyNFnD3shCVV1YRx51/vuBN/H lToUVemQ==; Received: from [10.9.9.73] (helo=submission02.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1rsOX6-0005dY-Qh; Thu, 04 Apr 2024 16:57:40 +0200 Received: by submission02.runbox with esmtpsa [Authenticated ID (641962)] (TLS1.2:ECDHE_SECP256R1__RSA_SHA256__AES_256_GCM:256) (Exim 4.93) id 1rsOX3-000w1u-Ba; Thu, 04 Apr 2024 16:57:37 +0200 Date: Thu, 4 Apr 2024 15:57:35 +0100 From: Steve George To: Christina O'Donnell Cc: guix-devel , efraim@flashner.co.il Subject: Re: Coordinators for patch review session on Tuesday Message-ID: References: <55f9be63-419e-57ba-7bd8-691cf80ab012@mutix.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <55f9be63-419e-57ba-7bd8-691cf80ab012@mutix.org> Received-SPF: permerror client-ip=2a0c:5a00:149::25; envelope-from=steve@futurile.net; helo=mailtransmit04.runbox.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, T_SPF_PERMERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -8.74 X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -8.74 X-Migadu-Queue-Id: 2218B627A8 X-TUID: XPopUL52nU/G Hi, Comments below: On 3 Apr, Christina O'Donnell wrote: (...) > Thank you for writing this up in so much depth! I've reviewed [1] and tried > to tag it as reviewed-looks-good, though I don't think that has gone > through. If you or someone else could take a look at it then I'd appreciate > that. I plan on reviewing some more patches this evening. > > Kind regards, > Christina > > [1] https://debbugs.gnu.org/cgi-bin/bugreport.cgi?users=guix;bug=65938 > 1. Changing the tag to reviewed-looks-good It doesn't look like this worked. The way to do this is in the instructions are 4. 'Set a user tag' [0], probably the easiest way is to send an email (I do get funny results sometimes with my email client): Subject: setting usertag on 65938 user guix usertag 65938 + reviewed-looks-good quit The first line is important it has to be 'user guix' for it to appear on the patch review reports [1]. I think I messed up the instructions in the Wiki - you have to have a + in between the bug number and the tag you want to set (sorry about that). Please try again. This is really just a way of signalling that reviews are happening - so trying to keep us in sync. The usertags we're using are: - patch-review-hackers-list - under-review - escalated-review-request - waiting-on-contributor - reviewed-looks-good The patch changes all look reasonable to me, you've already done a lot: 1. You should add a reviewed-by trailer: Reviews are contributions from our community (and work!) so we should recognise them and add trailers. It also helps the maintainer know who did the review and therefore the level of confidence. Basically just add 'Reviewed-by: A Person - [2] It looks like your updated patch retriggered QA, so if you look here and the foolow the Data Service link on the right you can see it's building it: https://qa.guix.gnu.org/issue/65938 The last step will be for a maintainer to see that it's built correctly, see your review and to apply it - great job for a first patch review! Steve / Futurile [0] https://libreplanet.org/wiki/Group:Guix/PatchReviewSessions2024#Patch_review_process_-_CLI_tools [1] https://libreplanet.org/wiki/Group:Guix/PatchReviewSessions2024#Patch_review_states_and_reports [2] https://libreplanet.org/wiki/Group:Guix/PatchReviewSessions2024#10._Add_a_Reviewed-by_Trailer