From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id eHgQMXGkUWD7NgAA0tVLHw (envelope-from ) for ; Wed, 17 Mar 2021 06:40:49 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id uGbILHGkUWCAXgAAbx9fmQ (envelope-from ) for ; Wed, 17 Mar 2021 06:40:49 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4CE291A1C6 for ; Wed, 17 Mar 2021 07:40:49 +0100 (CET) Received: from localhost ([::1]:52966 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMPrM-0006GR-FN for larch@yhetil.org; Wed, 17 Mar 2021 02:40:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMPqz-0006Ei-3a for guix-devel@gnu.org; Wed, 17 Mar 2021 02:40:25 -0400 Received: from mail.zaclys.net ([178.33.93.72]:54371) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMPqu-00079R-VJ for guix-devel@gnu.org; Wed, 17 Mar 2021 02:40:24 -0400 Received: from guix-xps.local (82-64-145-38.subs.proxad.net [82.64.145.38]) (authenticated bits=0) by mail.zaclys.net (8.14.7/8.14.7) with ESMTP id 12H6eCP4046967 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 17 Mar 2021 07:40:13 +0100 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.zaclys.net 12H6eCP4046967 Authentication-Results: mail.zaclys.net; spf=fail smtp.mailfrom=lle-bout@zaclys.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zaclys.net; s=default; t=1615963213; bh=Zcjh8kCz4aPYn+yEnckyJD801c6ORCNSngDukOlPsyw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=Ms3/DIp1IigDB7ok2msP84qbH6Zw+WL29pbihT6Rwe1F1UVjAagNSSGlh6quOVwpv qP30wKZyefxJ4ofBhxRj+cnzrrZsHzq5ELrhDc1dnIaf5DAlA2aH/Oc1xAyceP4dna AMN0tP8cl3Hf4CE07q77tI3jy2K1aB2F6cxqYbow= Message-ID: Subject: Re: Release 1.2.1: zstd 1.4.4 -> 1.4.9: grafting or core-updates? From: =?ISO-8859-1?Q?L=E9o?= Le Bouter To: Tobias Geerinckx-Rice , Leo Famulari Cc: guix-devel@gnu.org Date: Wed, 17 Mar 2021 07:40:07 +0100 In-Reply-To: <87ft0un7ma.fsf@nckx> References: <91998d12df3c4a279f46cf50b15d47c99e064a46.camel@zaclys.net> <87ft0un7ma.fsf@nckx> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-bi32k8pR4bPAd0E6nFeJ" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Received-SPF: pass client-ip=178.33.93.72; envelope-from=lle-bout@zaclys.net; helo=mail.zaclys.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615963249; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Zcjh8kCz4aPYn+yEnckyJD801c6ORCNSngDukOlPsyw=; b=etpu+Xhluu0DaSxigB6cIlX2JyoWmG+YmbdjnvRNOBzwXK+zGWxNgAKrxt3D7hXFC6bXOP NtukE6J2D8U4sgH1x+ucT51b/rt5Auoe0ZlnCOxKsklstaT3gpJ8HXC0HUIw4PHEP51q36 wim1Crz0k/EktF/zoPYGm9NUsHVbAutBWBSpt6IDAeb3dCBY4wD80UNo7HD7BGAzFV5Hs3 y/BS57puyM37ywTQKOeaH3zi5uxL86VNY6wEIR+ev81usbjkgigq5rNXrOG56R5+vhQkQM 723cqxrrXMGKeaCDIX8Zm0BpXmq+w2msI6b+s2Oi14nAjYtvguYCaVgLj5PHkA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615963249; a=rsa-sha256; cv=none; b=OU4+H4ZH+erVm08LU57mxyMC1BgiddZHstbPfVDsb/VxvLSl81f2AxxHPoKbi2dv/uoHxS C6oVYW0/HRaxN2id0zjQFW8oKp/sUesW5Ir9pzKlu2BR0COqtpxNqn+bjrUD3Qil1r36+B 8xYaPe4LjTUKO31US/HdOGucI1e0Y8zy2MmlE1mpbRdtEpyxlqDufggz9nA78okxImQ0Vd ouDsqOBBq1PwJEZgNa+baM/hEbxVwKgZqxXG5C/yMUQS5p9dHqRyBai1oAWJXpVXPiFefz wSbTd2wAhP/XLadnX1MZEy7WQNFPwPSHbI2V24BLTFoCWCRuBT5b23WsIaV7wQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=zaclys.net header.s=default header.b="Ms3/DIp1"; dmarc=pass (policy=reject) header.from=zaclys.net; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -4.20 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=zaclys.net header.s=default header.b="Ms3/DIp1"; dmarc=pass (policy=reject) header.from=zaclys.net; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 4CE291A1C6 X-Spam-Score: -4.20 X-Migadu-Scanner: scn0.migadu.com X-TUID: nSXiplAgM5jx --=-bi32k8pR4bPAd0E6nFeJ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2021-03-16 at 21:53 +0100, Tobias Geerinckx-Rice wrote: > Hi L[=C3=A9e]o, >=20 > Wow, L=C3=A9o. You've done some seriously impressive CVE squashing in= =20 > such a short timespan, and I'm very grateful to have you on board. I spent few days on this, it's not that much! I did not do much work, I didnt manually backport any patch (or only some with trivial changes that can be made by manually editing the patch file), I don't feel I deserve such thanks, even if they are appreciated, and we are all to be thanked for our work, it's not that impressive, I think I just went down with serious motivation looking at it and doing the repetitive work there. > I have the same request :-) Please submit non-trivial patches for=20 > review (and, unfortunately, grafts are hardly ever trivial). This=20 > isn't a comment on your work; it's our standard way of doing=20 > things. >=20 > I know we're not the #1 bestest project when it comes to the swift=20 > review of patches. I understand the sense of urgency in fixing=20 > things that one feels should have been fixed long ago. Thank you=20 > for helping us to improve on both points. I understand, I am sorry for unsolicited breakage anything might have caused, I will try to put it up for review, I already do try, zstd was one of my earlier grafts, I did realize even by myself that after pushing it I was touching a very critical part of GNU Guix and it would've been better maybe to ask for review before. > Kind regards, >=20 > T G-R L=C3=A9o --=-bi32k8pR4bPAd0E6nFeJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEFIvLi9gL+xax3g6RRaix6GvNEKYFAmBRpEcACgkQRaix6GvN EKYdqA/+NYhMLTlEl/TINIKCUYv+ACn7eXURlpg2qAcxlUgLJmVx/P5KgfUK21Wd 6zA9Iq5hJjaww2md8B2IuLLO/b20utyD9wXeKyU1kYG5zCdB6LgFJVen8XdlQPU+ 6XvQ2M4Twu3RJnEi8dCIRuVKKtOGLACeCFC2erxsQ5UQSsq5SY2TSIj/xVCWQ2J5 l+eSlu6x+2u40Y61a8xs4Rg/T9DOyxtYTBIkbWFOfFX/SZo80G4j2pagWIkkOJaf DT3sLGfGGIs8SmGAeG7dmJ70r7fzDlS6UHyvrUwGmcVaaFzRU2i5dpeu/erDDg6b sUL1rwSfPwVHBJXpUYvVVShaqK01UwE1D2tNBbRKB9pTprAD3HIZvAQ2A39SmnhL ByhTI1KpI0hjf6z4x1BeYi2sRJMHdW5VUPILBsPP3rekya8v33gysUqJ9JhAdwg0 3Y7y62/oU0XL6E3J+CqnbAC/V+XbMhLfpIaQoKeWkfiYyIoz2MUKGKk/yzbvFdEc g3ywO4GmCN10TkfIMch5Lewp2T6U4cVZcEGz4FOdP8QTWf/j8ghBtRrfnHDsuHhn rDXZsbBDGBo5QZ7lVxqA114YVNYDxgGf8908IQWX3SltYAS08zqPZ/nFU/BQiDbF UF+T3HhSgDMKZcXMWwj6u19ByE0x8xTa2HLB+NzDsMPH10TaT2M= =1+qV -----END PGP SIGNATURE----- --=-bi32k8pR4bPAd0E6nFeJ--