From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0LMSFCQ6C1+GfwAA0tVLHw (envelope-from ) for ; Sun, 12 Jul 2020 16:28:20 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id OCPlDyQ6C19VLAAAB5/wlQ (envelope-from ) for ; Sun, 12 Jul 2020 16:28:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0685694066B for ; Sun, 12 Jul 2020 16:28:19 +0000 (UTC) Received: from localhost ([::1]:52464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1juepu-0005Xa-Lu for larch@yhetil.org; Sun, 12 Jul 2020 12:28:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44334) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1juepH-0005XF-0R for guix-devel@gnu.org; Sun, 12 Jul 2020 12:27:39 -0400 Received: from mout.web.de ([212.227.17.11]:56875) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1juepF-0000Af-99; Sun, 12 Jul 2020 12:27:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1594571255; bh=cEQrQY6KfQPNIfQIPm4u7lB7VdWnb5OQUU0ZJetZm/c=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=G0xTCSFkrlnuass1sauNPnOlLSByMaJblNMEaT4XrTerWsRBM/f+B2Szsnnb09FdN o5NIKqxFyRVAAffXWFDt4NGchNGe2CLKN1cbbUxrqv+hgJRtNhxy972Pbd2heIZAQR hfZdjsVEckstRe4PaiImJwVZYL0kG14YcFLDIrt0= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.178.20] ([88.152.184.127]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N9cHX-1kzdR40nkD-015dgO; Sun, 12 Jul 2020 18:27:35 +0200 Subject: Re: Pushed a fix (?) for ACL key location To: Marius Bakke , guix-devel@gnu.org References: <877dv98q1z.fsf@dustycloud.org> <522d8a75-a2ba-d6a0-908f-a6e5029c3309@web.de> <87y2noc3qn.fsf@gnu.org> From: Jonathan Brielmaier Message-ID: Date: Sun, 12 Jul 2020 18:27:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Icedove/68.9.0 MIME-Version: 1.0 In-Reply-To: <87y2noc3qn.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:8MS+2zdJUYmUxR7dlusd7T3yqjF4VEKREi0BmVwVisqtaUbGfG1 2LZiqE2E5H2v7cPf/+A+Z6duppdBJ83y1JfteqJvdFDiHMspeTpduc21xCWvuQV7oa8JY1R EGx0WkhnpUNVs5hPGqTd6xziZG1n8+JmoO3vVllpN9H5QeUQ6SyJwXf3EGXqLVhDyHLTagk XM0BqU4hTOVyiU9xwsMKQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:1a27KwnpJrw=:KEjkNrEWNNv2zppD/sI1hw kf1i9NhKvY9MRJUrHUr8LTLFAf1QI5xEuPMl/Ya9j3OkIHvjW+IXtYjaXaVR+WaElcBSQfRjC UY5nkwE/4syqAY+ecQpcQvGh5jMUk3D4GS3T4N8ZUie+TFJzSuXolT9Pp011x3TRdPdE1Mlfw jvOkQVzCozsCkiAoi+vQupLyMcvJ+OgDFkF86zbE1w6sU9g9T/WQK5eezVYFL1wMBO+kE9UYp jm45rDeqQ0V4UHW8f8Oh0JWSnlVLTf6H4nqUayqKRq3bwX7smym40N6mBsmHPglJtRfFIISxD 9FD37mCXj6eF68dsQtYuVMhsoAm8/LSrEMIYXXMUhwuqDj9cZhIZOBfg5Wku1TbfTyVOfyd8t MlBrLFZcXccV7dzQIPmLk5hGblekRjiViYDl9BSRlloWcQpdEG52n1jxHm/xNjjCc4jZZgKF9 ApO51DPzkqSNQBkD3vAC0iZ5ULESfhfW65nY2r9K51Ku0w4KIpRP5lpbuV4D3vvQPscUsPmSa wGVDNVxXXvf+bfk18zU9FgdDEP6hI1ycObwyW1yvDPE3BUj0sgKBXAUzjdkAHDYVOY3L+U4ut cOzGbQ667quVamEjo0wzZ1TqhGXbzrS+IgNj8i8WgBBtYeoy3LVKPrSFTgY6lHqx38Jdk2Yhz cYlXF/KoLDreml4jvcnInh2CLHgSR2KvZL+E6LwJKbZ8xRosL/NdU6kcKEhti6h9u9gai5kgz Jn23X0LdG7P3tYKAOpr/FAMgUmys7HHlO1+7vorIWFHGUdP7MSfuebJWyBI3zob29ShFguNcZ lAY7SbOu9EuzUTzDUxJMPw8Rn1tPfX9kMJl9ALrL8wqhgE1Z6W3KOe7xEqLmIrGXQgFJd+p0g Bagv4gzNdvJuY4xx4yQZZW6UZDQv2VAOK/o+WiPCk1owD0nE5L3jAhXODBKsOJj7HW2SckCZC gDuoxg+RMmEnRXmjBopHSQS9bYjamX4x03JNjYwOG8QevD+TG9OXynrNS2b13aSUlUQ1CjwCw QPCjnJFI5qJNSiU2YfumB2tYP12YAjTjCMJInhKICGpUgA3/Yqknng6KrAK0jaT+GxYBEq/bX hYX5i1Y/RAPRH/GzCcQOQ2J+mPCSh3lde/ml31ruO1v1iFed2Pt3G8xZp6/VUvLjvJjw7FFcl JUiLY3AfnBPbo6KrVrkL7y2wQRAYw+OaWuGSR9xgPpd/i9vaRe0eESL4W3SpEAbqtCCIE2JVr HHuf0+0Y2S5R1QbJ4GDgkSEbIc/9mk2sSn6LBDg== Received-SPF: pass client-ip=212.227.17.11; envelope-from=jonathan.brielmaier@web.de; helo=mout.web.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/12 12:27:35 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=web.de header.s=dbaedf251592 header.b=G0xTCSFk; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: IqVkLtk+Lc06 On 12.07.20 14:33, Marius Bakke wrote: > Jonathan Brielmaier writes: > >> On 12.07.20 03:44, Christopher Lemmer Webber wrote: >>> Commit 6680880f9b8dceb4f2f3f91bd2b13c659b53835e pushed out a new versi= on >>> of Guix, and it looks like it wasn't possible to build new systems fro= m >>> that because the filename for the "Berlin ACL key" changed. (Or at >>> least, I couldn't run "guix system vm".) >>> >>> I pushed out a "fix" for this. I hope it's ok. >> >> Thanks for the fix. >> >> As I ran into all those little errors with `guix pull` this week-end, I >> wonder if we can do better. > > This particular change broke 'guix system', not 'guix pull'. Which is > equally bad of course, but a different kind of beast entirely. > > Are you referring to something else? It started with d283bb960f927dd5f7bb8b96bc697221e4e8ad39 and it could be `guix system` which failed. Then it's a different case, because testing `guix system` is working, is more difficult. > >> So maybe some pre-checkin CI which tests that a commit/commit series >> doesn't break `guix pull`. What do you think? Is this doable? > >> I find those little errors pretty annoying as they seem to be avoidable >> through technical counter measures... > > One possible solution that has been discussed before is to have the CI > continously merge master to a 'stable' branch when lights are green. > There are quite a few challenges to solve with that approach though. > > We could make the pre-push hook run 'guix pull' and 'guix system build' > but it will quickly get annoying. A server-side hook for the same would > be less annoying, but would have a hard time if someone accidentally > pushes a full rebuild. That's a point. So my idea was to do it at least for all changes of Guix itself. Like updating the guix package, new po files, Makefile changes etc. I think this could lead to quite an improvement. > In practice there will always be problems that cannot be caught in an > automated way. I hope such breakages are rare, but from your message it > sounds like there were many problems just this week-end? I counted two or three this week-end connected with the renaming of the public key of the berlin build farm, so a "trivial" change...