[PATCH] gnu: Add python2-pbkdf2

[PATCH] gnu: Add python2-pbkdf2

[Daniel Pimentel]

[-- Attachment #1: Type: text/plain, Size: 95 bytes --]

Add new package python2-pbkdf2.

Patch attached.

Thanks Guixs,

-- 
Daniel Pimentel (aka d4n1)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0002-gnu-Add-python2-pbkdf2.patch --]
[-- Type: text/x-diff; name=0002-gnu-Add-python2-pbkdf2.patch, Size: 1542 bytes --]

From 8bf389c554c0b8e4f19f25c828fd2c2846cfb662 Mon Sep 17 00:00:00 2001
From: Daniel Pimentel <d4n1@d4n1.org>
Date: Mon, 13 Jun 2016 18:08:32 -0300
Subject: [PATCH 2/2] gnu: Add python2-pbkdf2

---
 gnu/packages/python.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 0ee6ade..c9ac1f1 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9035,3 +9035,26 @@ It supports both the original 1.0 specification, as well as the
 new (proposed) 2.0 spec, which includes batch submission, keyword arguments,
  etc.")
     (license license:expat)))
+
+(define-public python2-pbkdf2
+  (package
+    (name "python2-pbkdf2")
+    (version "1.3")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "http://pypi.python.org/packages/source/p/pbkdf2/pbkdf2-"
+                    version ".tar.gz"))
+              (sha256
+               (base32
+                "0yb99rl2mbsaamj571s1mf6vgniqh23v98k4632150hjkwv9fqxc"))))
+    (build-system python-build-system)
+    (inputs
+     `(("python-setuptools" ,python-setuptools)))
+    (arguments `(#:tests? #f))
+    (home-page "https://www.dlitz.net/software/python-pbkdf2/")
+    (synopsis "A module that implements the password-based key derivation function PBKDF2")
+    (description
+     "This module implements the password-based key derivation function, 
+PBKDF2, specified in RSA PKCS#5 v2.0.")
+    (license license:expat)))
-- 
2.7.4

Re: [PATCH] gnu: Update python2-pbkdf2

[Daniel Pimentel]

[-- Attachment #1: Type: text/plain, Size: 62 bytes --]

Update patch to python2-pbkdf2

-- 
Daniel Pimentel (aka d4n1)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0004-gnu-Update-python2-pbkdf2.patch --]
[-- Type: text/x-diff; name=0004-gnu-Update-python2-pbkdf2.patch, Size: 1049 bytes --]

From 701c0e1d213efe8efdb96fb82d6e7a10d0c2ac2e Mon Sep 17 00:00:00 2001
From: Daniel Pimentel <d4n1@d4n1.org>
Date: Tue, 14 Jun 2016 16:40:53 -0300
Subject: [PATCH 4/4] gnu: Update python2-pbkdf2

---
 gnu/packages/python.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index efdce9a..e054c63 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9050,8 +9050,9 @@ new (proposed) 2.0 spec, which includes batch submission, keyword arguments,
                 "0yb99rl2mbsaamj571s1mf6vgniqh23v98k4632150hjkwv9fqxc"))))
     (build-system python-build-system)
     (inputs
-     `(("python-setuptools" ,python-setuptools)))
-    (arguments `(#:tests? #f))
+     `(("python2-setuptools" ,python2-setuptools)))
+    (arguments
+     `(#:tests? #f)) ; test empty to build
     (home-page "https://www.dlitz.net/software/python-pbkdf2/")
     (synopsis "A module that implements the password-based key derivation function PBKDF2")
     (description
-- 
2.7.4

Re: [PATCH] gnu: Update python2-pbkdf2

[Daniel Pimentel]

[-- Attachment #1: Type: text/plain, Size: 81 bytes --]

Update patch to python2-pbkdf2 (python2 support).

-- 
Daniel Pimentel (aka d4n1)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0006-gnu-Update-python2-pbkdf2.patch --]
[-- Type: text/x-diff; name=0006-gnu-Update-python2-pbkdf2.patch, Size: 905 bytes --]

From 0535122c2fe6e59b1ee9639224dae9a7ee8291c8 Mon Sep 17 00:00:00 2001
From: Daniel Pimentel <d4n1@d4n1.org>
Date: Tue, 14 Jun 2016 16:53:45 -0300
Subject: [PATCH 6/6] gnu: Update python2-pbkdf2

---
 gnu/packages/python.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 33bc932..775b760 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9054,7 +9054,8 @@ new (proposed) 2.0 spec, which includes batch submission, keyword arguments,
     (inputs
      `(("python2-setuptools" ,python2-setuptools)))
     (arguments
-     `(#:tests? #f)) ; test empty to build
+     `(#:tests? #f
+                #:python ,python-2))
     (home-page "https://www.dlitz.net/software/python-pbkdf2/")
     (synopsis "A module that implements the password-based key derivation function PBKDF2")
     (description
-- 
2.7.4

Re: [PATCH] gnu: Update python2-pbkdf2

[Daniel Pimentel]

[-- Attachment #1: Type: text/plain, Size: 58 bytes --]

Add HTTPS in URI.

thanks,

-- 
Daniel Pimentel (aka d4n1)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0008-gnu-Update-python2-pbkdf2.patch --]
[-- Type: text/x-diff; name=0008-gnu-Update-python2-pbkdf2.patch, Size: 880 bytes --]

From facbf4a5b4c01abd583adebc66949737b9b54d19 Mon Sep 17 00:00:00 2001
From: Daniel Pimentel <d4n1@d4n1.org>
Date: Tue, 14 Jun 2016 17:00:57 -0300
Subject: [PATCH 8/8] gnu: Update python2-pbkdf2

---
 gnu/packages/python.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 0e2a162..997be60 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9045,7 +9045,7 @@ new (proposed) 2.0 spec, which includes batch submission, keyword arguments,
     (source (origin
               (method url-fetch)
               (uri (string-append
-                    "http://pypi.python.org/packages/source/p/pbkdf2/pbkdf2-"
+                    "https://pypi.python.org/packages/source/p/pbkdf2/pbkdf2-"
                     version ".tar.gz"))
               (sha256
                (base32
-- 
2.7.4

Re: [PATCH] gnu: Update python2-pbkdf2 (refactored)

[Daniel Pimentel]

[-- Attachment #1: Type: text/plain, Size: 50 bytes --]

Add python2-pbkdf2

-- 
Daniel Pimentel (aka d4n1)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0002-gnu-Add-python2-pbkdf2.patch --]
[-- Type: text/x-diff; name=0002-gnu-Add-python2-pbkdf2.patch, Size: 1589 bytes --]

From ccfc0c589d297ff262fdc8d7495ffb12854bfc7c Mon Sep 17 00:00:00 2001
From: Daniel Pimentel <d4n1@d4n1.org>
Date: Thu, 16 Jun 2016 09:11:09 -0300
Subject: [PATCH 2/2] gnu: Add python2-pbkdf2

---
 gnu/packages/python.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 6dece06..0d1391b 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9244,3 +9244,28 @@ It supports both the original 1.0 specification, as well as the
 new (proposed) 2.0 spec, which includes batch submission, keyword arguments,
  etc.")
     (license license:expat)))
+
+(define-public python2-pbkdf2
+  (package
+    (name "python2-pbkdf2")
+    (version "1.3")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://pypi.python.org/packages/source/p/pbkdf2/pbkdf2-"
+                    version ".tar.gz"))
+              (sha256
+               (base32
+                "0yb99rl2mbsaamj571s1mf6vgniqh23v98k4632150hjkwv9fqxc"))))
+    (build-system python-build-system)
+    (inputs
+     `(("python2-setuptools" ,python2-setuptools)))
+    (arguments
+     `(#:tests? #f
+                #:python ,python-2))
+    (home-page "https://www.dlitz.net/software/python-pbkdf2/")
+    (synopsis "A module that implements the password-based key derivation function PBKDF2")
+    (description
+     "This module implements the password-based key derivation function, 
+PBKDF2, specified in RSA PKCS#5 v2.0.")
+    (license license:expat)))
-- 
2.7.4

Re: [PATCH] gnu: Update python2-pbkdf2 (refactored)

[Leo Famulari]

On Thu, Jun 16, 2016 at 09:12:56AM -0300, Daniel Pimentel wrote:

Thanks! Can you rebase this patch on the current master branch?

This patch's context is your patch for python2-jsonrpclib, but I changed
the license in that patch, so this patch cannot be applied.

In the meantime, some comments:

> Subject: [PATCH 2/2] gnu: Add python2-pbkdf2

Can you add the line for the changelog? See the line I added to
python2-jsonrpclib's commit message for reference.

> ---
>  gnu/packages/python.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 6dece06..0d1391b 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -9244,3 +9244,28 @@ It supports both the original 1.0 specification, as well as the
>  new (proposed) 2.0 spec, which includes batch submission, keyword arguments,
>   etc.")
>      (license license:expat)))
> +
> +(define-public python2-pbkdf2
> +  (package
> +    (name "python2-pbkdf2")
> +    (version "1.3")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://pypi.python.org/packages/source/p/pbkdf2/pbkdf2-"
> +                    version ".tar.gz"))

Can you make these lines shorter than 80 characters?

> +              (sha256
> +               (base32
> +                "0yb99rl2mbsaamj571s1mf6vgniqh23v98k4632150hjkwv9fqxc"))))
> +    (build-system python-build-system)
> +    (inputs
> +     `(("python2-setuptools" ,python2-setuptools)))

Can you check if it works with setuptools as native-input?

> +    (arguments
> +     `(#:tests? #f
> +                #:python ,python-2))

This #:python line should be aligned with #:tests.

> +    (home-page "https://www.dlitz.net/software/python-pbkdf2/")

Unfortunately this server is inaccesible. They have enabled HTTP Strict
Transport Security (HSTS), but their TLS certificate has expired.
Hopefully they fix this. No change required to the patch, although it
would be friendly if you notified them.

> +    (synopsis "A module that implements the password-based key derivation function PBKDF2")

This is too long. I don't have a good suggestion. How about
"Password-Based Key Derivation Function 2 in Python"? 

Re: [PATCH 3/3] gnu: Update python2-pbkdf2

[Daniel Pimentel]

[-- Attachment #1: Type: text/plain, Size: 85 bytes --]

Thank you for your comments.

Update patch in attach.

-- 
Daniel Pimentel (aka d4n1)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0008-add-python2-pbkdf2.patch --]
[-- Type: text/x-diff; name=0008-add-python2-pbkdf2.patch, Size: 1295 bytes --]

From 188ba4b27ed1b0581cda6187e2389ee4db5b9471 Mon Sep 17 00:00:00 2001
From: Daniel Pimentel <d4n1@d4n1.org>
Date: Fri, 17 Jun 2016 21:44:56 -0300
Subject: [PATCH 8/8] add python2-pbkdf2 * gnu/packages/python.py: update uri,
 indentation and resume synopsis.

---
 gnu/packages/python.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 0959ecb..2990efc 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9254,13 +9254,13 @@ new (proposed) 2.0 spec, which includes batch submission, keyword arguments,
                (base32
                 "0yb99rl2mbsaamj571s1mf6vgniqh23v98k4632150hjkwv9fqxc"))))
     (build-system python-build-system)
-    (inputs
+    (native-inputs
      `(("python2-setuptools" ,python2-setuptools)))
     (arguments
      `(#:tests? #f
-                #:python ,python-2))
+       #:python ,python-2))
     (home-page "https://www.dlitz.net/software/python-pbkdf2/")
-    (synopsis "A module that implements the password-based key derivation function PBKDF2")
+    (synopsis "A module that implements function PBKDF2")
     (description
      "This module implements the password-based key derivation function, 
 PBKDF2, specified in RSA PKCS#5 v2.0.")
-- 
2.7.4

[PATCH] gnu: Add python2-pbkdf2 and update python2-jsonrpclib

[Daniel Pimentel]

[-- Attachment #1: Type: text/plain, Size: 130 bytes --]

* gnu/packages/python.scm: add new package and update variable

Note: full package (merge commits)

-- 
Daniel Pimentel (aka d4n1)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-add-python2-pbkdf2.patch --]
[-- Type: text/x-diff; name=0001-gnu-add-python2-pbkdf2.patch, Size: 1957 bytes --]

From 7acca9fa8e2c67b1149c584b447270d501376fe7 Mon Sep 17 00:00:00 2001
From: Daniel Pimentel <d4n1@d4n1.org>
Date: Thu, 23 Jun 2016 13:02:58 -0300
Subject: [PATCH] gnu: add python2-pbkdf2 * gnu/packages/python.scm: add new
 package

---
 gnu/packages/python.scm | 27 ++++++++++++++++++++++++---
 1 file changed, 24 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 4567a91..cf4ef3c 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9274,9 +9274,7 @@ specified in POSIX.1-2001 and POSIX.1-2008.")
     (version "0.1.7")
     (source (origin
               (method url-fetch)
-              (uri (string-append
-                    "https://pypi.python.org/packages/source/j/jsonrpclib/"
-                    "jsonrpclib-" version ".tar.gz"))
+              (uri (pypi-uri "jsonrpclib" version))
               (sha256
                (base32
                 "02vgirw2bcgvpcxhv5hf3yvvb4h5wzd1lpjx8na5psdmaffj6l3z"))))
@@ -9294,3 +9292,26 @@ It supports both the original 1.0 specification, as well as the
 new (proposed) 2.0 spec, which includes batch submission, keyword arguments,
 etc.")
     (license asl2.0)))
+
+(define-public python2-pbkdf2
+  (package
+    (name "python2-pbkdf2")
+    (version "1.3")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "pbkdf2" version))
+              (sha256
+               (base32
+                "0yb99rl2mbsaamj571s1mf6vgniqh23v98k4632150hjkwv9fqxc"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python2-setuptools" ,python2-setuptools)))
+    (arguments
+     `(#:tests? #f
+       #:python ,python-2))
+    (home-page "https://www.dlitz.net/software/python-pbkdf2/")
+    (synopsis "A module that implements function PBKDF2.")
+    (description
+     "A module that implements the password-based key derivation 
+function PBKDF2.")
+    (license license:expat)))
-- 
2.7.4

Re: [PATCH] gnu: Add python2-pbkdf2 and update python2-jsonrpclib

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

On Thu, Jun 23, 2016 at 01:07:26PM -0300, Daniel Pimentel wrote:
> * gnu/packages/python.scm: add new package and update variable

The program claims to support Python 3 and Python 2. It also has a test
suite in the 'test/' directory. So, I changed your patch as attached.
But, it fails the test suite.

Can you try to make it work?

[-- Attachment #2: 0001-gnu-Add-python-pbkdf2.patch --]
[-- Type: text/x-diff, Size: 1452 bytes --]

From 9b31ca925ef9da4e9e5299215dc73f866114fee9 Mon Sep 17 00:00:00 2001
From: Daniel Pimentel <d4n1@d4n1.org>
Date: Thu, 23 Jun 2016 13:07:26 -0300
Subject: [PATCH] gnu: Add python-pbkdf2.

* gnu/packages/python.scm (python-pbkdf2, python2-pbkdf2): New variables.

Co-authored-by: Leo Famulari <leo@famulari.name>
---
 gnu/packages/python.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 8c34ff2..c4bfe76 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9291,3 +9291,23 @@ It supports both the original 1.0 specification, as well as the
 new (proposed) 2.0 spec, which includes batch submission, keyword arguments,
 etc.")
     (license asl2.0)))
+
+(define-public python-pbkdf2
+  (package
+    (name "python-pbkdf2")
+    (version "1.3")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "pbkdf2" version))
+              (sha256
+               (base32
+                "0yb99rl2mbsaamj571s1mf6vgniqh23v98k4632150hjkwv9fqxc"))))
+    (build-system python-build-system)
+    (home-page "https://www.dlitz.net/software/python-pbkdf2/")
+    (synopsis "A module that implements function PBKDF2.")
+    (description "A module that implements the password-based key derivation
+function PBKDF2.")
+    (license license:expat)))
+
+(define-public python2-pbkdf2
+  (package-with-python2 python-pbkdf2))
-- 
2.9.0

Re: [PATCH] gnu: Add python2-pbkdf2 and update python2-jsonrpclib

[d4n1]

[-- Attachment #1: Type: text/html, Size: 836 bytes --]