unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Andreas Enge <andreas@enge.fr>, guix-devel@gnu.org
Subject: Re: Gnome dans core-updates
Date: Sat, 18 Mar 2023 00:00:49 +0100	[thread overview]
Message-ID: <b3730678c30b8e37b15438d8ea8516ccefb03cb8.camel@gmail.com> (raw)
In-Reply-To: <ZBTCEKehr7peOJwL@jurong>

[-- Attachment #1: Type: text/plain, Size: 1301 bytes --]

Am Freitag, dem 17.03.2023 um 20:40 +0100 schrieb Andreas Enge:
> packagekit fails its installation phase (!) like so:
> /gnu/store/xrn2zn2ky4jkigg2cal0g8sacpkfai9m-meson-0.63.2/bin/meson
> install --no-rebuild
> ninja: build stopped: subcommand failed.
> error: in phase 'install': uncaught exception:
> %exception #<&invoke-error program: "ninja" arguments: ("install")
> exit-status: 1 term-signal: #f stop-signal: #f>
> phase `install' failed after 0.3 seconds
> command "ninja" "install" failed with status 1
> builder for `/gnu/store/4yvabkw23pwmxcanvl1qn8ch9jak7py4-packagekit-
> 1.2.5.drv' failed with exit code 1
> build of /gnu/store/4yvabkw23pwmxcanvl1qn8ch9jak7py4-packagekit-
> 1.2.5.drv failed
> View build log at
> '/var/log/guix/drvs/4y/vabkw23pwmxcanvl1qn8ch9jak7py4-packagekit-
> 1.2.5.drv.gz'.
This error is caused by trying to install
'/gnu/store/mxp199mvjb6dhyyg0pi4hn6c7m0xibvp-bash-completion-
2.11/share/bash-completion/completions/pkcon'.  Meson appears to have a
feature where it tries to use pkexec to gain elevated privileges. 
However, since that pkexec is actually the one pulled in for the build
system, that won't work here.

In any case, the attached patch fixes the more pressing issue of
getting the installation directory wrong.

Cheers

[-- Attachment #2: 0001-gnu-packagekit-Fix-installation-directory-for-bash-c.patch --]
[-- Type: text/x-patch, Size: 1667 bytes --]

From b7c1a259815e97beeb9f60b8991fde87c31abf64 Mon Sep 17 00:00:00 2001
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
Date: Fri, 17 Mar 2023 23:57:22 +0100
Subject: [PATCH] gnu: packagekit: Fix installation directory for bash
 completions.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Without this patch, packagekit would attempt to install bash completions
to another store directory, invoking pkexec in the process and raising
a cryptic error.

* gnu/packages/freedesktop.scm (packagekit)[#:phases]: Add
‘fix-bash-completion-dir’.
---
 gnu/packages/freedesktop.scm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index 9ba53cd044..9256dac0e0 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -1006,7 +1006,15 @@ (define-public packagekit
     (build-system meson-build-system)
     (arguments
      (list #:tests? #f
-           #:configure-flags #~'("-Dsystemd=false" "-Doffline_update=false")))
+           #:configure-flags #~'("-Dsystemd=false" "-Doffline_update=false")
+           #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'unpack 'fix-bash-completion-dir
+                 (lambda _
+                   (substitute* "contrib/meson.build"
+                     (("bash_.*_dep\\.get_.*\\('completionsdir', .*\\)")
+                      "join_paths(get_option('prefix'), 'share',
+                                  'bash-completion', 'completions')")))))))
     (native-inputs
      (list bash-completion
            docbook-xsl
-- 
2.39.2


  parent reply	other threads:[~2023-03-17 23:01 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-17 19:40 Gnome dans core-updates Andreas Enge
2023-03-17 19:45 ` Andreas Enge
2023-03-17 20:46 ` Liliana Marie Prikler
2023-03-17 20:58   ` Liliana Marie Prikler
2023-03-18  9:53   ` Andreas Enge
2023-03-17 23:00 ` Liliana Marie Prikler [this message]
2023-03-18 10:36   ` Andreas Enge
2023-03-18 11:15     ` Liliana Marie Prikler
2023-03-18 17:57       ` Andreas Enge
2023-03-18 10:07 ` Andreas Enge
2023-03-18 10:18   ` Andreas Enge
2023-03-19  9:20   ` Josselin Poiret
2023-03-19  9:59     ` Andreas Enge
2023-03-19 14:14       ` Josselin Poiret
2023-03-20 17:00         ` Andreas Enge
2023-03-20 17:11           ` Andreas Enge
2023-03-20 17:17             ` Efraim Flashner
2023-03-20 17:52               ` Andreas Enge
2023-03-20 19:18                 ` Josselin Poiret
2023-03-30  9:08                   ` Andreas Enge
2023-04-05  8:54                     ` Andreas Enge
2023-04-07 13:45 ` Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b3730678c30b8e37b15438d8ea8516ccefb03cb8.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=andreas@enge.fr \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).