Re: New review checklist

[Maxime Devos <maximedevos@telenet.be>]

[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]

Liliana Marie Prikler schreef op vr 01-04-2022 om 06:14 [+0200]:
> It won't be added to Guix.  Here's why it won't.
> You appear to believe that
> [...]
> [ ] hard-coding the commit field is a good idea

Does the following count:

(define-public foo
  (package
    (name "foo")
    (version "1.0.0")
    (source
      (origin
        [...]
        (file-name (git-file-name name version))
        ;; Upstream does not tag versions, see
        ;; <https://foo.bar/versions> for which commit
        ;; corresponds to which version.
        ;;
        ;; (alternatively)
        ;;
        ;; Upstream deletes old tags every N months,
        ;; so explicitly write the commit here.;
        ;;
        ;; (alternatively)
        ;;
        ;; There is consensus that the benefits of explicit commits
        ;; outweigh the downsides, see
        ;; <https://actually.I.dont.think.there.is.consensus?>
        (commit "cabba9e..."))
   [...]))

-- would the commit need to be let-bound here?

Greetings,
Maxime

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]