From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id eOVnHLHvy18hXwAA0tVLHw (envelope-from ) for ; Sat, 05 Dec 2020 20:38:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id kORAGLHvy1+zBgAA1q6Kng (envelope-from ) for ; Sat, 05 Dec 2020 20:38:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 215FC9402A5 for ; Sat, 5 Dec 2020 20:38:09 +0000 (UTC) Received: from localhost ([::1]:58756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kleJk-0002bb-0K for larch@yhetil.org; Sat, 05 Dec 2020 15:38:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kleJI-0002bP-Tl for guix-devel@gnu.org; Sat, 05 Dec 2020 15:37:40 -0500 Received: from knopi.disroot.org ([178.21.23.139]:42850) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kleJG-00049h-Mo for guix-devel@gnu.org; Sat, 05 Dec 2020 15:37:40 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id B2E5F51BE0; Sat, 5 Dec 2020 21:37:34 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ab3wvH8Nq4n1; Sat, 5 Dec 2020 21:37:33 +0100 (CET) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1607200653; bh=eCuRmKHE2VWqknKkPUpZIE/RAC0q+qNv3jVlbGRv7bk=; h=Date:From:Subject:To:Cc:In-Reply-To:References; b=lpKURxTqsgPq9Z1q5uE0/B7L3/kK8Sqse8D0uUP37yFovjzWMW+R55mKH+hPvFEGI O92VEMGSK/xnqEQJjTaKeiBR0RkKio1yeQNYvdBQzhUyZQpwoB2y4O6ah73yQXel36 XhqhR7p3dEmjB1ypgLYZc5K2Au5zuSN5aMwfHHd041aCgygSJ350AZVWDOq2IamZrn I1C4SniTasYDR5mmQIWXLPZJA/LZon+TK83MURFtD30cImREZDdmHrWFUZV54+r4VO 5ZXFPEvCAHu1B/+ybvi9UjqBciElBzC7sxWAZO2y5srdAs53L7mi543osTNXPzYPgV hllXjFBCTP58g== Date: Sat, 05 Dec 2020 20:37:32 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: "Raghav Gururajan" Message-ID: Subject: Re: Questionable "cosmetic changes" commits To: "Mark H Weaver" , "Ryan Prior" , "Danny Milosavljevic" Cc: "Development of GNU Guix and the GNU System distribution" In-Reply-To: <87im9g4ukt.fsf@netris.org> References: <87im9g4ukt.fsf@netris.org> Received-SPF: pass client-ip=178.21.23.139; envelope-from=raghavgururajan@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.50 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=disroot.org header.s=mail header.b=lpKURxTq; dmarc=pass (policy=quarantine) header.from=disroot.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 215FC9402A5 X-Spam-Score: -2.50 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: QN4Fz7DzKx4z Hi Mark!=0A=0A> Meanwhile, you've only provided a rationale for 1 out of = 3 of the kinds=0A> of changes made in these commits.=0A> =0A> Do you have= an explanation for why you are removing comments in your=0A> "cosmetic c= hanges" commits? For example, the following two commits=0A> remove commen= ts that explain why 'propagated-inputs' are needed:=0A> =0A> https://git.= sv.gnu.org/cgit/guix.git/commit/?id=3Dc3264f9e100ad6aefe5216002b68f3bfdcf= 6be95=0A> https://git.sv.gnu.org/cgit/guix.git/commit/?id=3D416b1b9f56b51= 4677660b56992cea1c78e00f519=0A> =0A> What's your rationale for doing this= ? Am I the only one here who finds=0A> this practice objectionable? It's = not even mentioned in the commit logs.=0A=0AI think the comments are usef= ul for non-trivial cases. In these definitions, the inputs were propagate= d because they were mentioned in .pc files. Propagation because of pkg-co= nfig is trivial. So I removed the comments.=0A=0ARegards,=0ARG.