From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GBB5DkZw4l6+TQAA0tVLHw (envelope-from ) for ; Thu, 11 Jun 2020 17:56:22 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id kFouCkZw4l7qRgAAbx9fmQ (envelope-from ) for ; Thu, 11 Jun 2020 17:56:22 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A6D8294051C for ; Thu, 11 Jun 2020 17:56:21 +0000 (UTC) Received: from localhost ([::1]:34348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jjRR6-0007to-GQ for larch@yhetil.org; Thu, 11 Jun 2020 13:56:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53010) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jjRQr-0007t3-NJ for guix-devel@gnu.org; Thu, 11 Jun 2020 13:56:05 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:39312) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jjRQo-0001fD-Q3 for guix-devel@gnu.org; Thu, 11 Jun 2020 13:56:05 -0400 Received: by mail-wr1-x42e.google.com with SMTP id t18so7096349wru.6 for ; Thu, 11 Jun 2020 10:55:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=bS8IhK/+68i1kFGm6eaOoXRXEeoyjVARV57XvwXymNY=; b=cv+HJuGxYzfm+vJ1EJ1yK/NMtSBGG6FbGS2+792t2nctGKRR7YHC1tuiSgKqQ/lvtZ 4wGpKQna/i5miW65On1zTFhk7XotAmsQGGWt0L8kLUv6LxQ5IyAVI9r6r2SxBoxKezsn CrX+dsK73P8cD7vNts+Bu+d2xuNCrCOTKpJ9u77E4VPystPQxCvO5uuZ+wJdPvFLcjOx 1OQ+4Ocmzc3ZCDJrcATpF+fMBcWG0JBUf7Hiie6d2MkdwlHZ4KAw0b4v/oJ/5qkuJXwG A3WM0RaBD5URVKU1YDTthv97OhEGHqKN7Gig1K2x0wI1+2sUVRAt18xqgsqIIk8H5q8k sN8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bS8IhK/+68i1kFGm6eaOoXRXEeoyjVARV57XvwXymNY=; b=uF2K3GpiF4unL/HSMDPdzWxqF4TfQDrXRNB05yxe5/6moRij7cSgaNs7k0tJtB8Bq5 6tT29umJ1Iu7L9ZPexLgejjio4o8gTrAvVC13DagUB9Rwy0uwcQFnU9M/45UNfd9a0oq MLvZTTegrhwOEqii6w5ZawDo/V2I6+h7DM2syodDSnokpynDlpkIK16vrjFmOz+y40f6 rpSKtUz3BXUFVsr/lPaixazSiGD9AtfRU0CJ9FFgBpDZTur3lVzNpO3yd0afdiHZaNPZ ql/jmId9wRdKw4DLFg4jjKJT0KphOFeviQH269Nhx+NTcDT7ctpHko3CdeiFV/I/2nn+ 4fgw== X-Gm-Message-State: AOAM531C0W3xCuvSlo13+D4pdBHmd/GqAhVTRxhARebUG18cjRc9qQIV A492LpxN7CSr2TqqqQCYVSTA3OLnV/I= X-Google-Smtp-Source: ABdhPJzGS8z5Ume0ZB687JVREvgVuCgR159B+dfRNCBVVy8I+K9/2oTUrM30qKbXF7Dajo7lkN95QA== X-Received: by 2002:a5d:6905:: with SMTP id t5mr10471574wru.113.1591898154164; Thu, 11 Jun 2020 10:55:54 -0700 (PDT) Received: from [10.0.0.2] (se167-1-82-242-148-1.fbx.proxad.net. [82.242.148.1]) by smtp.gmail.com with ESMTPSA id g18sm5569040wme.17.2020.06.11.10.55.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2020 10:55:53 -0700 (PDT) Subject: Re: A script to check an edit does not break anything To: Edouard Klein , guix-devel@gnu.org References: <87sgf1r5nk.fsf@alice.lan> <87mu59r4od.fsf@alice.lan> From: Vincent Legoll Message-ID: Date: Thu, 11 Jun 2020 19:55:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <87mu59r4od.fsf@alice.lan> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=vincent.legoll@gmail.com; helo=mail-wr1-x42e.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=cv+HJuGx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -1.71 X-TUID: V+Ifha4EP0bP Hello Edouard, I think you left a hardcoded package name in your script, line 29, fix with: s/python-websockets/$package/ Also you sometimes use $package vs ${package} This kind of thing (maybe converted into scheme what about `guix before-submit') should be a valuable addition to guix, it would help beginners (like me do less mistakes) and comitters could have more confidence in a submission if it has gone through this. Which would in turn enable us to integrate patches quicker. WDYT ? -- Vincent Legoll