From mboxrd@z Thu Jan 1 00:00:00 1970 From: rennes@openmailbox.org Subject: Re: [PATCH] gnu: Add spice-protocol. Date: Fri, 12 Feb 2016 20:55:26 -0600 Message-ID: References: <12541d95db51a675a0adc0d43464784e@openmailbox.org> <20160213003105.GA13163@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56996) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUQN6-0006Vz-Sc for guix-devel@gnu.org; Fri, 12 Feb 2016 21:55:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aUQN2-0007fB-NC for guix-devel@gnu.org; Fri, 12 Feb 2016 21:55:44 -0500 Received: from mail2.openmailbox.org ([62.4.1.33]:50966) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUQN2-0007ez-Dr for guix-devel@gnu.org; Fri, 12 Feb 2016 21:55:40 -0500 In-Reply-To: <20160213003105.GA13163@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Leo Famulari Cc: guix-devel@gnu.org Hi Leo, On 2016-02-12 18:31, Leo Famulari wrote: > On Thu, Feb 11, 2016 at 07:56:56AM -0600, rennes@openmailbox.org wrote: >> Hi, >> >> i attached spice-protocol patch for review. > > Thanks for the patch! > >> >> SPICE protocol, is a required package to package spice-gtk(requiered >> for >> GNOME Vinagre). >> >> Considerations: >> >> a) I use the source: "http://www.spice-space.org/download/releases/" >> instead >> "https://cgit.freedesktop.org/spice/spice-protocol". >> b) The home page "http://www.spice-space.org" instead >> "https://cgit.freedesktop.org/spice/spice-protocol". > > Okay. > >> * gnu/packages/gnome.scm (spice-protocol): New variable. > > The patch looks good. I don't know how to test whether or not the > software it installs _works_ or not. Have you tested that? i tested SPICE protocol and spice-gtk, just need to try a SPICE conection in GNOME Vinagre. Thanks