From mboxrd@z Thu Jan 1 00:00:00 1970 From: david.larsson@selfhosted.xyz Subject: Re: guile-bash updated source url Date: Sun, 5 May 2019 13:07:30 +0200 (CEST) Message-ID: References: <87imurbq18.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="8323328-1732139264-1557054451=:11664" Return-path: Received: from eggs.gnu.org ([209.51.188.92]:55201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNEzo-0008P0-RJ for guix-devel@gnu.org; Sun, 05 May 2019 07:07:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hNEzn-0001c4-0k for guix-devel@gnu.org; Sun, 05 May 2019 07:07:52 -0400 In-Reply-To: <87imurbq18.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Cc: guix-devel@gnu.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-1732139264-1557054451=:11664 Content-Type: text/plain; format=flowed; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Andreas & Ludo, On Fri, 3 May 2019, Ludovic Court=C3=A8s wrote: > Hello David, > > david.larsson@selfhosted.xyz skribis: > >> This is my first contribution to guix and it's just a minor fix for >> the guile-bash package which had an outdated source url. I was able to >> retrieve the same revision of the package via the software-heritage >> project's website and upload it to gitlab. Then I installed it >> successfully via guix package -f my-guile-bash.scm using the gitlab >> url, then copied it to the existing guile-xyz.scm in gnu/packages. > > [...] > >> --- a/gnu/packages/guile-xyz.scm >> +++ b/gnu/packages/guile-xyz.scm >> @@ -294,23 +294,21 @@ dictionary and suggesting spelling corrections."= ) >> (license license:gpl3+))) >> >> (define-public guile-bash >> - ;; This project is currently retired. It was initially announced h= ere: >> - ;; . >> - (let ((commit "1eabc563ca5692b3e08d84f1f0e6fd2283284469") >> + (let ((commit "49099fe6a592aa3b8001e826b939869fe5811785") >> (revision "0")) > > Why is the commit different? Looks like it=E2=80=99s more than just a = mirror. > > If you made changes on top of the original code, that=E2=80=99s actuall= y great. > However, I=E2=80=99d prefer to first see a patch that simply changes th= e URL, > not the commit and hash, and later updates to a different revision. > > Does that make sense? > I made a commit since I was unable figure out how to create a git-mirror from the Software Heritage website but was able to retrieve the correct commit as a tarball. Then I guix init'ed the folder, and made a commit in order to push it to gitlab. > Andreas Enge skribis: > >> should the package not be retrieved automatically from Software Herita= ge >> with the newest Guix API? And apart from that, will it be desirable to= keep >> around an unmaintained software for which the source has disappeared? I don't know if the newest Guix API would fix it, but I haven't been able to install guile-bash from source so far using e.g. guix challenge. I can't really answer your second question, but I will personally use the package and thought it would be nice to be able to retrieve it from a standard Guix install and that it can be built and challenged. Previously I had to add additional --substitute-url's to guix install it. > > I think David is in fact suggesting that they may well be maintaining > it, which is good news IMO. :-) I wish that was the case - maybe in the future, I am slowly learning Guile at the moment :-) Currently, I can at most support the package definition and change the url if someone notifies me they want to start actively maintaining it. So I don't know if you think the patch should be rejected or not.. maybe the comment about the project being retired should remain, if so I can resubmit a patch. Thanks for your comments, // David L --8323328-1732139264-1557054451=:11664--