unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Jack Hill <jackhill@jackhill.us>
To: guix-devel@gnu.org, HiPhish <hiphish@posteo.de>
Subject: Re: neovim and luajit?
Date: Thu, 22 Apr 2021 01:33:58 -0400 (EDT)	[thread overview]
Message-ID: <alpine.DEB.2.21.2104220115450.8414@marsh.hcoop.net> (raw)
In-Reply-To: <alpine.DEB.2.21.2007311601410.4809@marsh.hcoop.net>

[-- Attachment #1: Type: text/plain, Size: 1272 bytes --]

On Fri, 31 Jul 2020, Jack Hill wrote:

> Hi Guix,
>
> I'm wondering why we use Lua 5.1 instead of LuaJIT for neovim? It seems that 
> upstream prefers LuaJIT given the non-default configure flag we use[0] and 
> their FAQ[1].
>
> I don't have an opinion either way. I'm learning about neovim today, and am 
> curious how we arrived at our configuration.
>
> [0] https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/vim.scm?id=96a655a77bb087397a9436391e472c36ff0a2ec2#n647
> [1] https://github.com/neovim/neovim/wiki/FAQ#why-embed-lua-instead-of-x
>
> Best,
> Jack

I've returned to the above question. With the attached patch, neovim 
builds on x86_64 and performs basic editing functions. I did not test it 
with any extra packages or plugins.

In addition to what I said before, I'm also interested in LuaJIT because 
it supports the 5.1 language and still seems to be developed upstream. Lua 
is no longer developing the 5.1 series and the newer series have an 
incompatible language.

A downside to using LuaJIT is that it doesn't support all the 
architectures that Guix supports [2]. In particular, it looks like 
aarch64 and ppc64el are missing.

[2] https://luajit.org/install.html

Best,
Jack

P.S. Maybe its time to work on the Lua language of Guile 😀

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-diff; name=0001-gnu-neovim-Use-luajit.patch, Size: 1857 bytes --]

From eea95ade77aabd0528043a68fee4d2c45a334602 Mon Sep 17 00:00:00 2001
From: Jack Hill <jackhill@jackhill.us>
Date: Thu, 22 Apr 2021 01:17:56 -0400
Subject: [PATCH] gnu: neovim: Use luajit.

* gnu/packages/vim.scm (neovim)[inputs]: Replace lua-5.1 with luajit.
[arguments]: Remove "-DPREFER_LUA:BOOL=YES" from #:configure-flags, and adjust
"set-lua-paths" phase to use luajit.
---
 gnu/packages/vim.scm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/vim.scm b/gnu/packages/vim.scm
index 231fae9298..35608a2220 100644
--- a/gnu/packages/vim.scm
+++ b/gnu/packages/vim.scm
@@ -643,7 +643,6 @@ are detected, the user is notified.")))
      `(#:modules ((srfi srfi-26)
                   (guix build cmake-build-system)
                   (guix build utils))
-       #:configure-flags '("-DPREFER_LUA:BOOL=YES")
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'set-lua-paths
@@ -658,7 +657,7 @@ are detected, the user is notified.")))
                        (let ((path (string-append prefix "/share/lua/" lua-version)))
                          (string-append path "/?.lua;" path "/?/?.lua"))))
                     (lua-inputs (map (cute assoc-ref %build-inputs <>)
-                                     '("lua"
+                                     '("luajit"
                                        "lua-luv"
                                        "lua-lpeg"
                                        "lua-bitop"
@@ -684,7 +683,7 @@ are detected, the user is notified.")))
        ("unibilium" ,unibilium)
        ("jemalloc" ,jemalloc)
        ("libiconv" ,libiconv)
-       ("lua" ,lua-5.1)
+       ("luajit" ,luajit)
        ("lua-luv" ,lua5.1-luv)
        ("lua-lpeg" ,lua5.1-lpeg)
        ("lua-bitop" ,lua5.1-bitop)
-- 
2.31.1


  reply	other threads:[~2021-04-22  5:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-31 20:26 neovim and luajit? Jack Hill
2021-04-22  5:33 ` Jack Hill [this message]
2021-04-25  7:15   ` Efraim Flashner
2021-04-25  9:23     ` HiPhish
2021-04-29 22:28       ` Jack Hill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.2104220115450.8414@marsh.hcoop.net \
    --to=jackhill@jackhill.us \
    --cc=guix-devel@gnu.org \
    --cc=hiphish@posteo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).