From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jack Hill <jackhill@jackhill.us>
Subject: Re: Certbot with alternative certificate authority
Date: Thu, 5 Mar 2020 14:49:06 -0500 (EST)
Message-ID: <alpine.DEB.2.20.2003051444230.19733@marsh.hcoop.net>
References: <alpine.DEB.2.20.2003051334390.19733@marsh.hcoop.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:37829)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <jackhill@jackhill.us>) id 1j9wUV-0005pl-PF
 for guix-devel@gnu.org; Thu, 05 Mar 2020 14:49:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <jackhill@jackhill.us>) id 1j9wUU-0002sh-RQ
 for guix-devel@gnu.org; Thu, 05 Mar 2020 14:49:07 -0500
Received: from minsky.hcoop.net ([104.248.1.95]:45626)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <jackhill@jackhill.us>)
 id 1j9wUU-0002sW-O8
 for guix-devel@gnu.org; Thu, 05 Mar 2020 14:49:06 -0500
Received: from marsh.hcoop.net ([45.55.52.66])
 by minsky.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.89) (envelope-from <jackhill@jackhill.us>)
 id 1j9wUU-0005o3-9N
 for guix-devel@gnu.org; Thu, 05 Mar 2020 14:49:06 -0500
In-Reply-To: <alpine.DEB.2.20.2003051334390.19733@marsh.hcoop.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org
Sender: "Guix-devel"
 <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
To: guix-devel@gnu.org

On Thu, 5 Mar 2020, Jack Hill wrote:

> What error have I made?

Thanks to Tobias Geerinckx-Rice on IRC, it looks like I forgot additional 
record changes as well. Even though Tobias was not able to reproduce my 
exact problem, making the following additional changes fixed it for me:


```
diff --git a/gnu/services/certbot.scm b/gnu/services/certbot.scm
index 3e71026387..f2cc00e97f 100644
--- a/gnu/services/certbot.scm
+++ b/gnu/services/certbot.scm
@@ -146,7 +146,7 @@
           (message (format #f (G_ "~a may need to be run~%") script)))
      (match config
        (($ <certbot-configuration> package webroot certificates email
-                                  rsa-key-size default-location)
+                                  server rsa-key-size default-location)
         (with-imported-modules '((guix build utils))
           #~(begin
               (use-modules (guix build utils))
@@ -158,7 +158,7 @@
  (define certbot-nginx-server-configurations
    (match-lambda
      (($ <certbot-configuration> package webroot certificates email
-                                rsa-key-size default-location)
+                                server rsa-key-size default-location)
       (list
        (nginx-server-configuration
```

I will clean up these changes and submit a proper patch to improve our 
certbot service.

Best,
Jack