From: Eric Bavier <ericbavier@openmailbox.org>
To: ludo@gnu.org
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/2] gnu: Add evilwm.
Date: Tue, 20 Oct 2015 14:37:22 -0500 [thread overview]
Message-ID: <aec486aaab7fae20503f1a376545c2a7@openmailbox.org> (raw)
In-Reply-To: <87zizex9a7.fsf@gnu.org>
On 2015-10-20 02:56, ludo@gnu.org wrote:
> Eric Bavier <ericbavier@openmailbox.org> skribis:
>
>> On Fri, 16 Oct 2015 10:37:43 +0200
>> ludo@gnu.org (Ludovic Courtès) wrote:
[...]
>> + 'install 'install-fonts-dir
>> + ;; The X font server will not add directories to
>> the font
>> + ;; path unless they contain a "fonts.dir" file, so
>> add some
>> + ;; dummy files.
>> + (lambda* (#:key outputs #:allow-other-keys)
>> + (let ((out (assoc-ref outputs "out")))
>> + (for-each (lambda (d)
>> + (call-with-output-file
>> + (string-append out
>> "/share/fonts/X11"
>> + "/" d
>> "/fonts.dir")
>> + (lambda (p)
>> + (format p "0~%"))))
>> + '("75dpi" "100dpi" "misc"
>> "cyrillic"))
>
> So how did you settle on "0~%"? :-)
I ran 'mkfontdir' on an empty directory, and the "fonts.dir" file it
wrote
contained just a "0" on a line of its own. I'm not sure whether things
would
work with just an empty file.
>> From 45c524710742550013a8513b641e8d488806f7c9 Mon Sep 17 00:00:00 2001
>> From: Eric Bavier <bavier@member.fsf.org>
>> Date: Thu, 15 Oct 2015 17:34:26 -0500
>> Subject: [PATCH 4/4] gnu: Add evilwm.
>>
>> * gnu/packages/wm.scm (evilwm): New variable.
>
> [...]
>
>> + (arguments
>> + `(#:modules ((srfi srfi-26)
>> + ,@%gnu-build-system-modules)
>
> Note that %GNU-BUILD-SYSTEM-MODULES is the set of modules *imported* in
> the build environment (inputs of the derivation), not the set of
> modules
> visible in the build script. See ‘%default-modules’
> vs. ‘%gnu-build-system-modules’ in (guix build-system gnu) for the
> difference.
Thanks for the pointer. I saw some other packages using
%gnu-build-system-modules
and wasn't aware of the subtleties.
> So it should rather be:
>
> #:modules ((srfi srfi-26)
> (guix build utils)
> (guix build gnu-build-system))
I'll use that then.
> In practice it probably won’t make any difference.
I don't mind being pedantic. :)
> Otherwise LGTM.
Great! Thanks for the reviews. I'll push with those changes.
--
`~Eric
next prev parent reply other threads:[~2015-10-20 19:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 22:36 [PATCH 1/2] gnu: Add xlsfonts ericbavier
2015-10-15 22:36 ` [PATCH 2/2] gnu: Add evilwm ericbavier
2015-10-16 8:37 ` Ludovic Courtès
2015-10-19 11:55 ` Eric Bavier
2015-10-20 7:56 ` Ludovic Courtès
2015-10-20 19:37 ` Eric Bavier [this message]
2015-10-16 8:34 ` [PATCH 1/2] gnu: Add xlsfonts Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aec486aaab7fae20503f1a376545c2a7@openmailbox.org \
--to=ericbavier@openmailbox.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).