unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Léo Le Bouter" <lle-bout@zaclys.net>
To: Leo Famulari <leo@famulari.name>, zimoun <zimon.toutoune@gmail.com>
Cc: Guix Devel <guix-devel@gnu.org>
Subject: Re: Release 1.2.1: zstd 1.4.4 -> 1.4.9: grafting or core-updates?
Date: Tue, 16 Mar 2021 19:08:02 +0100	[thread overview]
Message-ID: <ae7e2e29b4b93d0072596d18de9f45436a73236a.camel@zaclys.net> (raw)
In-Reply-To: <YFDxLvQcaiJadhJJ@jasmine.lan>

[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]

On Tue, 2021-03-16 at 13:55 -0400, Leo Famulari wrote:
> I do agree that updating this program 5 versions in a graft was
> perhaps
> too much.
> 
> We should always try to cherry-pick bug-fix patches when grafting.
> 
> Otherwise the risk of breakage is too high. At least, these types of
> patches should be reviewed on guix-patches. Léo, can you send them to
> guix-patches in the future?
> 
> Sometimes it is okay to update things in a graft, but it depends on
> the
> situation.

1.4.4 and 1.4.9 are ABI compatible? At least that's the reason I
believed it wasnt risky. I can send them to the mailing list especially
with such a core package (GNU Guix dependency). But often it stays
there and no one is looking so. E.g. the unzip vulnerability patches,
nobody looked until I actually pushed them out of waiting for reviews,
I tried to hint multiple people on IRC during several days, no answer
still, so I ended up pushing it, turns out I had several mistakes in it
and because it was pushed well some people looked at it and helped
fixing which was welcome.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-03-16 18:35 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-06  5:09 GNU Guix (pull?) on i686 broke after zstd grafting Léo Le Bouter
2021-03-06  5:30 ` Léo Le Bouter
2021-03-10 10:37 ` Ludovic Courtès
2021-03-10 10:43   ` Léo Le Bouter
2021-03-11  2:11   ` Léo Le Bouter
2021-03-11  9:37     ` zimoun
2021-03-11  9:40       ` Léo Le Bouter
2021-03-11  9:58         ` zimoun
2021-03-11 10:05           ` Léo Le Bouter
2021-03-16 16:34 ` Release 1.2.1: zstd 1.4.4 -> 1.4.9: grafting or core-updates? zimoun
2021-03-16 17:06   ` Léo Le Bouter
2021-03-16 17:48     ` Leo Famulari
2021-03-16 18:03       ` Léo Le Bouter
2021-03-16 17:59     ` zimoun
2021-03-16 17:55   ` Leo Famulari
2021-03-16 18:08     ` Léo Le Bouter [this message]
2021-03-16 18:46       ` zimoun
2021-03-16 18:50         ` Léo Le Bouter
2021-03-16 19:04           ` zimoun
2021-03-16 18:19     ` zimoun
2021-03-16 18:26       ` Léo Le Bouter
2021-03-16 19:18       ` Leo Famulari
2021-03-16 19:25         ` zimoun
2021-03-16 19:29           ` Leo Famulari
2021-03-16 21:46             ` Security-czar needed? WAS: " Bengt Richter
2021-03-16 22:03               ` Leo Famulari
2021-03-17  6:24               ` Léo Le Bouter
2021-03-17 14:00                 ` zimoun
2021-03-16 21:47             ` Maxime Devos
2021-03-16 20:53     ` Tobias Geerinckx-Rice
2021-03-16 21:18       ` Vincent Legoll
2021-03-16 21:56         ` Leo Famulari
2021-03-17  6:40       ` Léo Le Bouter
2021-03-30  0:35   ` Léo Le Bouter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae7e2e29b4b93d0072596d18de9f45436a73236a.camel@zaclys.net \
    --to=lle-bout@zaclys.net \
    --cc=guix-devel@gnu.org \
    --cc=leo@famulari.name \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).