From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tobias Geerinckx-Rice Subject: Re: [PATCH] gnu: Add beep. Date: Wed, 4 Jan 2017 08:10:50 +0100 Message-ID: References: <3a11ef341fdc11ac1fc7c01cab446258@openmailbox.org> <4a4d6b34538d305bb75bbe64a03b6df5@openmailbox.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lJ9RuTjFd2UdElp8Hl28lCmfwILweaj4e" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60307) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cOfib-00055a-B3 for guix-devel@gnu.org; Wed, 04 Jan 2017 02:10:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cOfiY-0002Ez-4k for guix-devel@gnu.org; Wed, 04 Jan 2017 02:10:41 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:36399) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cOfiX-0002EX-Rq for guix-devel@gnu.org; Wed, 04 Jan 2017 02:10:38 -0500 In-Reply-To: <4a4d6b34538d305bb75bbe64a03b6df5@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: jmi2k@openmailbox.org Cc: guix-devel@gnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lJ9RuTjFd2UdElp8Hl28lCmfwILweaj4e Content-Type: multipart/mixed; boundary="IgxnaJl7EG8eRAEVGSTeGhWesbWwlkKC8"; protected-headers="v1" From: Tobias Geerinckx-Rice To: jmi2k@openmailbox.org Cc: guix-devel@gnu.org Message-ID: Subject: Re: [PATCH] gnu: Add beep. References: <3a11ef341fdc11ac1fc7c01cab446258@openmailbox.org> <4a4d6b34538d305bb75bbe64a03b6df5@openmailbox.org> In-Reply-To: <4a4d6b34538d305bb75bbe64a03b6df5@openmailbox.org> --IgxnaJl7EG8eRAEVGSTeGhWesbWwlkKC8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jos=C3=A9, On 02/01/17 20:33, Jos=C3=A9 Miguel S=C3=A1nchez Garc=C3=ADa wrote: > Add beep command. Thanks! > -;;; Copyright =C2=A9 2016 Jos=C3=A9 Miguel S=C3=A1nchez Garc=C3=ADa...= > +;;; Copyright =C2=A9 2017 Jos=C3=A9 Miguel S=C3=A1nchez Garc=C3=ADa...= Please keep both years: ;;; Copyright =C2=A9 2016, 2017 Jos=C3=A9 Miguel S=C3=A1nchez Garc=C3=AD= a... > (base32 "0bgch6jq5cahakk3kbr9549iysf2dik09afixxy5brbxk1xfzb2r")))) A bit long, easily solved by moving the hash string to its own line: (base32 "0bgch6jq5cahakk3kbr9549iysf2dik09afixxy5brbxk1xfzb2r")))) > ; It doesn't install without this I'd consider that implied, and just drop this comment. (Future note: since in-line comments like this one aren't considered full sentences, they don't start with a capital letter. Full-line comments beginning with ;; are, and do.) You're also doing more than patching the makefile here. Consider moving the =E2=80=98mkdir-p=E2=80=99 part to a separate, later phase (add-before= 'install). Sorry to ruin your =E2=80=98let=E2=80=99 factoring... > (synopsis "Command line utility for Linux that beeps the PC speaker.") > (description "Command line utility for Linux that beeps the PC > speaker.") I'll trust you that this is indeed Linux-specific: the manual mentions ioctls, and I can't get it to make a sound from within X :-( s/command line/command-line/ when used as an adjective. Descriptions should be between 5 and 10 lines where possible, use full sentences, and not repeat the synopsis ($ info guix "Synopses and Descriptions"). Luckily, the first paragraph of the man page makes a pretty good starting point: beep allows the user to control the PC speaker with precision, allowing different sounds to indicate different events. While it can be run quite happily on the command line, it's intended place of residence is within shell/perl scripts, notifying the user when something interesting occurs. Of course, it has no notion of what's interesting, but it's real good at that notifying part. I'd re-write the synopsis as =E2=80=98Linux command-line utility to contr= ol the PC speaker=E2=80=99. It does a tad more than just beep, even if it's the = musical equivalent of burping the alphabet. > (home-page "http://www.johnath.com/beep") ^^^ Your package is missing a few brackets. Did the patch get truncated? Kind regards, T G-R --IgxnaJl7EG8eRAEVGSTeGhWesbWwlkKC8-- --lJ9RuTjFd2UdElp8Hl28lCmfwILweaj4e Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEqBAEBCgAUBQJYbJ/6DRxtZUB0b2JpYXMuZ3IACgkQkczbm0hUG5mXvwgAuAb9 3kC2hqZFDDyO08TsSkNLXa7w2paa/ueucCy3PjJwFAuxgR/kQsxghykMiqdnu1g9 74igFeOCBzpUl90NaWaA2VGkCzDz6ew+4SBcuKM5hbMlXKiwfXuU8yHPHoBd2KIU EtDDhv2/Lj4kDFUSRGwjjUXwdH1ozMrxddGlzB/HsUS9muK+VLlIW2z8WrODhxb0 RrUAEGE1N6gmeWmeGqM3yQ8Jp+gg/c3I4HOHu7JGKWJmPDUEftiPVF5st7lsWUKA IEiU05rLVLIMqH5e8GzYEfqG4qzJWYxyOV2BaK7svkvAtovAAHWS1p8TsIDJ7+h9 xqtJRuToRdy5V+Nwug== =1Fdv -----END PGP SIGNATURE----- --lJ9RuTjFd2UdElp8Hl28lCmfwILweaj4e--