From mboxrd@z Thu Jan 1 00:00:00 1970 From: rennes@openmailbox.org Subject: Re: [PATCH 3/3] gnu: Add filezilla. Date: Tue, 14 Feb 2017 23:44:11 -0600 Message-ID: References: <20170209163618.1759-1-rennes@openmailbox.org> <20170209163618.1759-4-rennes@openmailbox.org> <87o9y64y0y.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=_b36bbd0af686790107a8630e649ffc87" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37283) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cdsO2-0002tZ-VK for guix-devel@gnu.org; Wed, 15 Feb 2017 00:44:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cdsNz-00058w-RV for guix-devel@gnu.org; Wed, 15 Feb 2017 00:44:19 -0500 Received: from lb1.openmailbox.org ([5.79.108.160]:57468 helo=mail.openmailbox.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cdsNz-00057o-Fj for guix-devel@gnu.org; Wed, 15 Feb 2017 00:44:15 -0500 In-Reply-To: <87o9y64y0y.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Maxim Cournoyer Cc: guix-devel@gnu.org --=_b36bbd0af686790107a8630e649ffc87 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed > Minor thing, and I'm not sure if we have a convention for this, but > it'd > be neat to keep the use-module statements ordered alphabetically. > Ordered alphabetically! > > Again, I'm under the impression that this should rather be gpl2+. I'd > be > happy to be proven wrong otherwise! > >> + (properties '((upstream-name . "FileZilla"))))) > > Otherwise LGTM (haven't tested though). Updated patch. Thanks --=_b36bbd0af686790107a8630e649ffc87 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0002-gnu-Add-filezilla.patch Content-Disposition: attachment; filename=0002-gnu-Add-filezilla.patch; size=2822 RnJvbSBjNDZhYmFhNzMxNGFhYzczYWQ4ZTdhMzY4ZTg2ZDkxZmExMjZiNGQzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiByZW5uZXMgPHJlbm5lc0BvcGVubWFpbGJveC5vcmc+CkRhdGU6 IFR1ZSwgMTQgRmViIDIwMTcgMjM6Mjc6MTEgLTA2MDAKU3ViamVjdDogW1BBVENIIDMvM10gZ251 OiBBZGQgZmlsZXppbGxhLgoKKiBnbnUvcGFja2FnZXMvZnRwLnNjbSAoZmlsZXppbGxhKTogTmV3 IHZhcmlhYmxlLgotLS0KIGdudS9wYWNrYWdlcy9mdHAuc2NtIHwgNTAgKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCA0OCBp bnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9m dHAuc2NtIGIvZ251L3BhY2thZ2VzL2Z0cC5zY20KaW5kZXggNjA2OTNhYWM2Li5kZGJmNWEwOGQg MTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9mdHAuc2NtCisrKyBiL2dudS9wYWNrYWdlcy9mdHAu c2NtCkBAIC0yOCwxMiArMjgsMjAgQEAKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMpCiAg ICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGF1dG90b29scykKICAgIzp1c2UtbW9kdWxlIChn bnUgcGFja2FnZXMgY2hlY2spICAKKyAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgY29tcHJl c3Npb24pCisgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGRhdGFiYXNlcykKKyAgIzp1c2Ut bW9kdWxlIChnbnUgcGFja2FnZXMgZnJlZWRlc2t0b3ApCiAgICM6dXNlLW1vZHVsZSAoZ251IHBh Y2thZ2VzIGdldHRleHQpCisgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGdsaWIpCisgICM6 dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGd0aykKKyAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2Fn ZXMgbGliaWRuKQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBuY3Vyc2VzKQotICAjOnVz ZS1tb2R1bGUgKGdudSBwYWNrYWdlcyByZWFkbGluZSkKKyAgIzp1c2UtbW9kdWxlIChnbnUgcGFj a2FnZXMgbmV0dGxlKQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBwa2ctY29uZmlnKQor ICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyByZWFkbGluZSkKICAgIzp1c2UtbW9kdWxlIChn bnUgcGFja2FnZXMgdGxzKQotICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBjb21wcmVzc2lv bikpCisgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHd4d2lkZ2V0cykKKyAgIzp1c2UtbW9k dWxlIChnbnUgcGFja2FnZXMgeG1sKSkKIAogKGRlZmluZS1wdWJsaWMgbGZ0cAogICAocGFja2Fn ZQpAQCAtMTgzLDMgKzE5MSw0MSBAQCBhcyByZXF1aXJlZC4iKQogICAgICAiVGhpcyBwYWNrYWdl IHByb3ZpZGVzIHNvbWUgYmFzaWMgZnVuY3Rpb25hbGl0eSB0byBidWlsZCBoaWdoLXBlcmZvcm1p bmcsCiBwbGF0Zm9ybS1pbmRlcGVuZGVudCBwcm9ncmFtcy4iKQogICAgIChsaWNlbnNlIGdwbDIr KSkpCisKKyhkZWZpbmUtcHVibGljIGZpbGV6aWxsYQorICAocGFja2FnZQorICAgIChuYW1lICJm aWxlemlsbGEiKQorICAgICh2ZXJzaW9uICIzLjI0LjAiKQorICAgIChzb3VyY2UKKyAgICAgKG9y aWdpbgorICAgICAgIChtZXRob2QgdXJsLWZldGNoKQorICAgICAgICh1cmkgKHN0cmluZy1hcHBl bmQgImh0dHBzOi8vc291cmNlZm9yZ2UubmV0L3Byb2plY3RzLyIgbmFtZQorICAgICAgICAgICAg ICAgICAgICAgICAgICAgIi9maWxlcy9GaWxlWmlsbGFfQ2xpZW50LyIgdmVyc2lvbgorICAgICAg ICAgICAgICAgICAgICAgICAgICAgIi9GaWxlWmlsbGFfIiB2ZXJzaW9uICJfc3JjIiAiLnRhci5i ejIiKSkKKyAgICAgICAoc2hhMjU2CisgICAgICAgIChiYXNlMzIKKyAgICAgICAgICIxYmFjcmw4 bGo5MGhxYmgxMjlocGJncWo3OGsxaTg0ajgzcmt6bjUwN2pueWtqNHg4cDl4IikpKSkKKyAgICAo YnVpbGQtc3lzdGVtIGdudS1idWlsZC1zeXN0ZW0pCisgICAgKG5hdGl2ZS1pbnB1dHMKKyAgICAg YCgoImdldHRleHQiICxnZXR0ZXh0LW1pbmltYWwpCisgICAgICAgKCJwa2ctY29uZmlnIiAscGtn LWNvbmZpZykKKyAgICAgICAoInB1Z2l4bWwiICxwdWdpeG1sKQorICAgICAgICgieGRnLXV0aWxz IiAseGRnLXV0aWxzKSkpCisgICAgKGlucHV0cworICAgICBgKCgiZGJ1cyIgLGRidXMpCisgICAg ICAgKCJnbnV0bHMiICxnbnV0bHMpCisgICAgICAgKCJndGsrIiAsZ3RrKykKKyAgICAgICAoImxp YmZpbGV6aWxsYSIgLGxpYmZpbGV6aWxsYSkKKyAgICAgICAoImxpYmlkbiIgLGxpYmlkbikKKyAg ICAgICAoIm5ldHRsZSIgLG5ldHRsZSkKKyAgICAgICAoInNxbGl0ZSIgLHNxbGl0ZSkKKyAgICAg ICAoInd4d2lkZ2V0cyIgLHd4d2lkZ2V0cykpKQorICAgIChob21lLXBhZ2UgImh0dHBzOi8vZmls ZXppbGxhLXByb2plY3Qub3JnIikKKyAgICAoc3lub3BzaXMgIkZ1bGwtZmVhdHVyZWQgZ3JhcGhp Y2FsIEZUUC9GVFBTL1NGVFAgY2xpZW50IikKKyAgICAoZGVzY3JpcHRpb24KKyAgICAgIkZpbGV6 aWxsYSBjbGllbnQgc3VwcG9ydHMgRlRQLCBGVFAgb3ZlciBTU0wvVExTIChGVFBTKSwKK1NTSCBG aWxlIFRyYW5zZmVyIFByb3RvY29sIChTRlRQKSwgSFRUUC8xLjEsIFNPQ0tTNSwgRlRQLVByb3h5 LCBJUHY2CithbmQgb3RoZXJzIGZlYXR1cmVzIHN1Y2ggYXMgYm9va21hcmtzLCBkcmFnIGFuZCBk cm9wLCBmaWxlbmFtZSBmaWx0ZXJzLAorZGlyZWN0b3J5IGNvbXBhcmlzb24gYW5kIG1vcmUuIikK KyAgICAobGljZW5zZSBncGwyKykKKyAgICAocHJvcGVydGllcyAnKCh1cHN0cmVhbS1uYW1lIC4g IkZpbGVaaWxsYSIpKSkpKQotLSAKMi4xMS4wCgo= --=_b36bbd0af686790107a8630e649ffc87--