From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0IpqA6wwR2J8BgEAgWs5BA (envelope-from ) for ; Fri, 01 Apr 2022 19:04:44 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id mLS8AKwwR2KDHgEA9RJhRA (envelope-from ) for ; Fri, 01 Apr 2022 19:04:44 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9249818DFF for ; Fri, 1 Apr 2022 19:04:43 +0200 (CEST) Received: from localhost ([::1]:40976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1naKhW-0005s0-FK for larch@yhetil.org; Fri, 01 Apr 2022 13:04:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43278) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1naKhE-0005re-Pz for guix-devel@gnu.org; Fri, 01 Apr 2022 13:04:24 -0400 Received: from [2a00:1450:4864:20::642] (port=42805 helo=mail-ej1-x642.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1naKhD-00080N-63 for guix-devel@gnu.org; Fri, 01 Apr 2022 13:04:24 -0400 Received: by mail-ej1-x642.google.com with SMTP id i27so234ejd.9 for ; Fri, 01 Apr 2022 10:04:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=yC15/ymt4zYzLfsToptbscCDdDXBRfm9QVU+SSqTJuo=; b=a3TcA6wthn3/bvMUr7xVgQ7BmPsjQJEf3wLJrsOADvWZjrEpStSBSgtxT5/Gq+dHbr vclgmkIG4GaaCUomox+3+NewY56k2MW9ZBX2+PGmfgCjVfYVM6edO59ZDEYyYS7fqzkP lcs9XxSeVCZ2Vi/UT00d9r8iGxpHcGNAS5cM9VxfW8m5zNXEpvUSjLlZfGhab6YmDsT4 Xe6YtgKLlaqn0tY8kgrmGfRH2milz/SaEuNSp1DFTkIEjAvAfxFjBLlB0LZncf+WFKMl /+1FN6Q09VYIVxfbqkW9AVA3fNkTxOcSfDxhRNLnjJpbSJUntKYEuaCSEBRmJjO0U5Uw BIqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=yC15/ymt4zYzLfsToptbscCDdDXBRfm9QVU+SSqTJuo=; b=DPZ58LkcjiE7ZT4RFpPA+MmLgq7ouQWlRJRviXV2UeR8hkmj96D7jBSVLBXNbPd0w5 QVGHcPG1FaaAlQReuep+AKvzvpcGbfTHh3UDRDEnHKa46Lpd5X0JsAs07DU6KudGMNPT Rwyn4lsUW9zViaBJch3nXpT03xmFWZcAM1H4pyrHhSSKq/C7TxmCk8DOcfPJpsLroowr d0emwh4nOO2gu1kUdjceAP7aQAHaTPRKTYiXsEb1L+QzSuDGPnQR5aj8gGyhPg+0YgH9 2KLz1oJrSnGiI7F9A93ogD1qZ4sDgxH99b0ReroNakJ2nHVX7v8HaEYon8goKPwEKzYT u6Jw== X-Gm-Message-State: AOAM533tcr49bTFfJJ3NIKetbCQhs9An15jT72irGZqG4zxPqWWW7tiW cdZo2Az0Gn2/5rGpElMfHQg= X-Google-Smtp-Source: ABdhPJw9RmQBpLDBbc6QJuDxOk/S5bjpFqoS7Nk/3F4lN8yklnF11bwlv36+1590Selpp92hUEKXcA== X-Received: by 2002:a17:906:5d03:b0:6df:a042:d6d5 with SMTP id g3-20020a1709065d0300b006dfa042d6d5mr650521ejt.678.1648832630010; Fri, 01 Apr 2022 10:03:50 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id d24-20020a1709067a1800b006e021f4c1c3sm1221623ejo.166.2022.04.01.10.03.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Apr 2022 10:03:49 -0700 (PDT) Message-ID: Subject: Re: New review checklist From: Liliana Marie Prikler To: Maxime Devos , guix-devel@gnu.org Date: Fri, 01 Apr 2022 19:03:47 +0200 In-Reply-To: References: <0912e3091c2bc34866f2795ec4f0413fc0928bdc.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::642 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::642; envelope-from=liliana.prikler@gmail.com; helo=mail-ej1-x642.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1648832683; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=yC15/ymt4zYzLfsToptbscCDdDXBRfm9QVU+SSqTJuo=; b=bKtRawnU3DA4+U7iaBYd8wOtvdSr4CxQ3j1eGU19b7q+XtUkNarXw6wtU4jjxb34VzuWnG ld8LApCUdeKlHoB9CLkkiQOf4fsXyE3d9zDQPKEhv0K3C3xJ9I67RkOe9NNnu6Sz/kVUZR 7myoR3wgoY5kfwIaNRKe6u6GAUmPyO7GzPmhhg+GH2ZpeN6IHcvuzaloBunhJ4zXWMRnIO CeKnLsDOrCLpayrE+Jf5BgXQT46BIBsMOb5u18oTnvjOUH0PJEFoFW7pg0zeeJXCV42tug bfYit8q1TYM6gge4RISqzd/1NOFO1GKdsVLpHnvo1EUh+fxShif4iSLuzW1Vog== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1648832683; a=rsa-sha256; cv=none; b=quqbRgWOybidEggomJ3opjdpNRRKcA4VP/iWLjVxSnxDQO8rBZKfRun6e62Jm987JFyy3q x0zkB6wgQ/wVT2JmqhU8rOcvuljD8bYvJi97Wwj8biHKkdrySVRc2oEnvhKghjHB4Buqyd N7vplZ4QB0DY5tPi1QmKuFsvqR1e1/OpcYHuzBRjbiY4I5hocSAMyMRlKbrz+thfR7rRUj CVBtJJbtt+yGvvmeNJAVkXQ0D9SPEbUMCpnLXR9CVBJSvD0GU6N1q0y/sQE/x6rffyWRsz 7OQ+A4zmL7mgkPj4K04RLGjDeBXR0hDUNTRcv92O7qSKD7rgdA6SLyTsOTiO1Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=a3TcA6wt; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -9.37 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=a3TcA6wt; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9249818DFF X-Spam-Score: -9.37 X-Migadu-Scanner: scn0.migadu.com X-TUID: VCbtqyfen9FK Hi Maxime, Am Freitag, dem 01.04.2022 um 08:30 +0200 schrieb Maxime Devos: > Liliana Marie Prikler schreef op vr 01-04-2022 om 06:14 [+0200]: > > It won't be added to Guix.  Here's why it won't. > > You appear to believe that > > [...] > > [ ] hard-coding the commit field is a good idea > > Does the following count: > > (define-public foo >   (package >     (name "foo") >     (version "1.0.0") >     (source >       (origin >         [...] >         (file-name (git-file-name name version)) >         ;; Upstream does not tag versions, see >         ;; for which commit >         ;; corresponds to which version. >         ;; >         ;; (alternatively) >         ;; >         ;; Upstream deletes old tags every N months, >         ;; so explicitly write the commit here.; >         ;; >         ;; (alternatively) >         ;; >         ;; There is consensus that the benefits of explicit commits >         ;; outweigh the downsides, see >         ;; >         (commit "cabba9e...")) >    [...])) > > -- would the commit need to be let-bound here? This discussion has already been had elsewhere, but to reiterate, my reasoning is that if you can't trust upstream tags to remain valid, you need another proof that the VERSION <-> COMMIT equivalence holds. Referring to another authority (as can be done in the case of Minetest packages) is fine for me personally, but in the general case (e.g. your #2 without further context) I'd say that let-binding the commit leads to the least amount of surprises for everyone. In the particular case of Minetest, another plausible style would be (let ((commit ...) (revision ACTUAL-REVISION-OR-#f))  (package ... ;; tagged TAG as of DATE ;; For a complete list of versions, see (version "just the version") (source (origin ... ;; Upstream is known to yank tags, so always use commits. (commit commit))))) Cheers