From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brice Waegeneire Subject: [Help] Adding file-system utils packages to system profile Date: Mon, 06 Apr 2020 17:07:07 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=_231fb5def6ab3b0e49a1da5a744e0b19" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:56480) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLVDM-0005bw-BQ for guix-devel@gnu.org; Mon, 06 Apr 2020 13:07:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jLVDK-00049s-Ik for guix-devel@gnu.org; Mon, 06 Apr 2020 13:07:11 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:43255) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jLVDK-000490-97 for guix-devel@gnu.org; Mon, 06 Apr 2020 13:07:10 -0400 Received: from webmail.gandi.net (webmail18.sd4.0x35.net [10.200.201.18]) (Authenticated sender: brice@waegenei.re) by relay11.mail.gandi.net (Postfix) with ESMTPA id 0C25210000A for ; Mon, 6 Apr 2020 17:07:07 +0000 (UTC) List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org --=_231fb5def6ab3b0e49a1da5a744e0b19 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8; format=flowed Hello Guix, There was several discussions about adding file-system utils packages to the system profile based on the types in the “file-systems” field. I tried implementing this in the attached patch but I'm currently stuck and need some help. I've probably overlooked something basic but I can;t put a finger on it... Guix compile successfully with the patch and testing “file-system-utils” in “guix repl” returns a list of packages as expected. But when I try building a system/vm the packages aren't added to the system's profile as I expected. From what I understand, that function as used in “file-system-service-type” should get as arguments the list of file-systems defined in the operating-system and should return a list of packages, themselves appended to the system's profile list of packages. Halp! What am I missing? I also welcome any suggestion UI wise, currently the only change is the additions of the “utils?” filed in the “file-system” record. - Brice --=_231fb5def6ab3b0e49a1da5a744e0b19 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-services-Add-file-system-utils-to-profile.patch Content-Disposition: attachment; filename=0001-services-Add-file-system-utils-to-profile.patch; size=4862 RnJvbSA1N2E2ZGM4YzZiYTJmYjJiNWNlOTdiZmZhMjZkNjFhNDMwZDJjMTZiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCcmljZSBXYWVnZW5laXJlIDxicmljZUB3YWVnZW5laS5yZT4K RGF0ZTogTW9uLCA2IEFwciAyMDIwIDE4OjAwOjExICswMjAwClN1YmplY3Q6IFtQQVRDSF0gc2Vy dmljZXM6IEFkZCBmaWxlLXN5c3RlbSB1dGlscyB0byBwcm9maWxlLgoKLS0tCiBnbnUvc2Vydmlj ZXMvYmFzZS5zY20gICAgICAgfCA0MiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr Ky0tCiBnbnUvc3lzdGVtL2ZpbGUtc3lzdGVtcy5zY20gfCAgNiArKysrKy0KIDIgZmlsZXMgY2hh bmdlZCwgNDUgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9nbnUv c2VydmljZXMvYmFzZS5zY20gYi9nbnUvc2VydmljZXMvYmFzZS5zY20KaW5kZXggMDcwNzY1YWI4 My4uMTY1MTliNWE3YiAxMDA2NDQKLS0tIGEvZ251L3NlcnZpY2VzL2Jhc2Uuc2NtCisrKyBiL2du dS9zZXJ2aWNlcy9iYXNlLnNjbQpAQCAtNDQsMTMgKzQ0LDIwIEBACiAgICAgICAgICAgICAgICAg IzpzZWxlY3QgKGZpbGUtc3lzdGVtLXBhY2thZ2VzKSkKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFj a2FnZXMgYWRtaW4pCiAgICM6dXNlLW1vZHVsZSAoKGdudSBwYWNrYWdlcyBsaW51eCkKLSAgICAg ICAgICAgICAgICAjOnNlbGVjdCAoYWxzYS11dGlscyBjcmRhIGV1ZGV2IGUyZnNwcm9ncyBmdXNl IGdwbSBrYmQgbHZtMiBybmctdG9vbHMpKQorICAgICAgICAgICAgICAgICM6c2VsZWN0IChhbHNh LXV0aWxzIGJ0cmZzLXByb2dzIGNyZGEgZXVkZXYgZXVkZXYvYnRyZnMtZml4CisgICAgICAgICAg ICAgICAgICAgICAgICAgIGUyZnNwcm9ncyBmMmZzLXRvb2xzIGZ1c2UgZ3BtIGtiZCBsdm0yIHJu Zy10b29scworICAgICAgICAgICAgICAgICAgICAgICAgICB1dGlsLWxpbnV4IHhmc3Byb2dzKSkK ICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgYmFzaCkKICAgIzp1c2UtbW9kdWxlICgoZ251 IHBhY2thZ2VzIGJhc2UpCiAgICAgICAgICAgICAgICAgIzpzZWxlY3QgKGNhbm9uaWNhbC1wYWNr YWdlIGNvcmV1dGlscyBnbGliYyBnbGliYy11dGY4LWxvY2FsZXMpKQogICAjOnVzZS1tb2R1bGUg KGdudSBwYWNrYWdlcyBwYWNrYWdlLW1hbmFnZW1lbnQpCiAgICM6dXNlLW1vZHVsZSAoKGdudSBw YWNrYWdlcyBnbnVwZykgIzpzZWxlY3QgKGd1aWxlLWdjcnlwdCkpCi0gICM6dXNlLW1vZHVsZSAo Z251IHBhY2thZ2VzIGxpbnV4KQorICAjOnVzZS1tb2R1bGUgKChnbnUgcGFja2FnZXMgZGlzaykK KyAgICAgICAgICAgICAgICAjOnNlbGVjdCAoZG9zZnN0b29scykpCisgICM6dXNlLW1vZHVsZSAo KGdudSBwYWNrYWdlcyBmaWxlLXN5c3RlbXMpCisgICAgICAgICAgICAgICAgIzpzZWxlY3QgKGJj YWNoZWZzLXRvb2xzIGpmc3V0aWxzIHpmcykpCisgICM6dXNlLW1vZHVsZSAoKGdudSBwYWNrYWdl cyBtdG9vbHMpCisgICAgICAgICAgICAgICAgIzpzZWxlY3QgKGV4ZmF0LXV0aWxzKSkKICAgIzp1 c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgdGVybWluYWxzKQogICAjOnVzZS1tb2R1bGUgKChnbnUg YnVpbGQgZmlsZS1zeXN0ZW1zKQogICAgICAgICAgICAgICAgICM6c2VsZWN0IChtb3VudC1mbGFn cy0+Yml0LW1hc2spKQpAQCAtNTksOCArNjYsMTAgQEAKICAgIzp1c2UtbW9kdWxlIChndWl4IG1v ZHVsZXMpCiAgICM6dXNlLW1vZHVsZSAoKGd1aXggc2VsZikgIzpzZWxlY3QgKG1ha2UtY29uZmln LnNjbSkpCiAgICM6dXNlLW1vZHVsZSAoc3JmaSBzcmZpLTEpCisgICM6dXNlLW1vZHVsZSAoc3Jm aSBzcmZpLTIpCiAgICM6dXNlLW1vZHVsZSAoc3JmaSBzcmZpLTI2KQogICAjOnVzZS1tb2R1bGUg KGljZS05IG1hdGNoKQorICAjOnVzZS1tb2R1bGUgKGljZS05IHJlZ2V4KQogICAjOnVzZS1tb2R1 bGUgKGljZS05IGZvcm1hdCkKICAgIzpleHBvcnQgKGZzdGFiLXNlcnZpY2UtdHlwZQogICAgICAg ICAgICAgcm9vdC1maWxlLXN5c3RlbS1zZXJ2aWNlCkBAIC01MzUsNiArNTQ0LDMzIEBAIEZJTEUt U1lTVEVNLiIKICAgICAgICAgICAgICAgICAobWVtcSAnYmluZC1tb3VudCAoZmlsZS1zeXN0ZW0t ZmxhZ3MgZmlsZS1zeXN0ZW0pKSkpCiAgICAgICAgICAgZmlsZS1zeXN0ZW1zKSkKIAorKGRlZmlu ZSAoZmlsZS1zeXN0ZW0tdHlwZS0+dXRpbHMgdHlwZSkKKyAgIlJldHVybiBhIHV0aWxzIHBhY2th Z2UgZm9yIGZpbGUgc3lzdGVtIFRZUEUuIgorICAoZGVmaW5lIHBhdHRlcm4tPnV0aWxzCisgICAg YCgoImV4dFsyMzRdIiAuICxlMmZzcHJvZ3MpCisgICAgICAoImJ0cmZzIiAuICxidHJmcy1wcm9n cykKKyAgICAgICgiamZzIiAuICxqZnN1dGlscykKKyAgICAgICgiZXhmYXQiIC4gLGV4ZmF0LXV0 aWxzKQorICAgICAgKCJiYWNoZWZzIiAuICxiY2FjaGVmcy10b29scykKKyAgICAgICgieGZzIiAu ICx4ZnNwcm9ncykKKyAgICAgICgiZmF0IiAuICxkb3Nmc3Rvb2xzKQorICAgICAgKCJmMmZzIiAu ICxmMmZzLXRvb2xzKQorICAgICAgKCJ6ZnMiIC4gLHpmcykpKQorICAoYW5kLWxldCogKCh1dGls cworICAgICAgICAgICAgICAoZmluZCAobGFtYmRhIChhKSAoc3RyaW5nLW1hdGNoIChjYXIgYSkg dHlwZSkpIHBhdHRlcm4tPnV0aWxzKSkpCisgICAgKGNkciB1dGlscykpKQorCisoZGVmaW5lIChm aWxlLXN5c3RlbS11dGlscyBmaWxlLXN5c3RlbXMpCisgICJSZXR1cm4gdGhlIGxpc3Qgb2YgZmls ZS1zeXN0ZW0gdXRpbHMgcGFja2FnZXMgZm9yIEZJTEUtU1lTVEVNUyIKKyAgKGZvbGQgKGxhbWJk YSAoZmlsZS1zeXN0ZW0gcHJldikKKyAgICAgICAgICAobGV0ICgodXRpbHM/IChmaWxlLXN5c3Rl bS11dGlscz8gZmlsZS1zeXN0ZW0pKQorICAgICAgICAgICAgICAgICh1dGlscyAoZmlsZS1zeXN0 ZW0tdHlwZS0+dXRpbHMgKGZpbGUtc3lzdGVtLXR5cGUgZmlsZS1zeXN0ZW0pKSkpCisgICAgICAg ICAgICAoaWYgKGFuZCB1dGlscz8gdXRpbHMKKyAgICAgICAgICAgICAgICAgICAgIChub3QgKG1l bWJlciB1dGlscyBwcmV2KSkpCisgICAgICAgICAgICAgICAgKGNvbnMqIHV0aWxzIHByZXYpCisg ICAgICAgICAgICAgICAgcHJldikpKQorICAgICAgICAnKCkgZmlsZS1zeXN0ZW1zKSkKKwogKGRl ZmluZSBmaWxlLXN5c3RlbS1zZXJ2aWNlLXR5cGUKICAgKHNlcnZpY2UtdHlwZSAobmFtZSAnZmls ZS1zeXN0ZW1zKQogICAgICAgICAgICAgICAgIChleHRlbnNpb25zCkBAIC01NDIsNiArNTc4LDgg QEAgRklMRS1TWVNURU0uIgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgZmlsZS1zeXN0ZW0tc2hlcGhlcmQtc2VydmljZXMpCiAgICAgICAgICAgICAgICAgICAgICAg IChzZXJ2aWNlLWV4dGVuc2lvbiBmc3RhYi1zZXJ2aWNlLXR5cGUKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGZpbGUtc3lzdGVtLWZzdGFiLWVudHJpZXMpCisgICAg ICAgICAgICAgICAgICAgICAgIChzZXJ2aWNlLWV4dGVuc2lvbiBwcm9maWxlLXNlcnZpY2UtdHlw ZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmlsZS1zeXN0ZW0t dXRpbHMpCiAKICAgICAgICAgICAgICAgICAgICAgICAgOzsgSGF2ZSAndXNlci1wcm9jZXNzZXMn IGRlcGVuZCBvbiAnZmlsZS1zeXN0ZW1zJy4KICAgICAgICAgICAgICAgICAgICAgICAgKHNlcnZp Y2UtZXh0ZW5zaW9uIHVzZXItcHJvY2Vzc2VzLXNlcnZpY2UtdHlwZQpkaWZmIC0tZ2l0IGEvZ251 L3N5c3RlbS9maWxlLXN5c3RlbXMuc2NtIGIvZ251L3N5c3RlbS9maWxlLXN5c3RlbXMuc2NtCmlu ZGV4IDNiNTk5ZWZhOGUuLjliYzE2ODc2OTYgMTAwNjQ0Ci0tLSBhL2dudS9zeXN0ZW0vZmlsZS1z eXN0ZW1zLnNjbQorKysgYi9nbnUvc3lzdGVtL2ZpbGUtc3lzdGVtcy5zY20KQEAgLTEsNSArMSw2 IEBACiA7OzsgR05VIEd1aXggLS0tIEZ1bmN0aW9uYWwgcGFja2FnZSBtYW5hZ2VtZW50IGZvciBH TlUKIDs7OyBDb3B5cmlnaHQgwqkgMjAxMywgMjAxNCwgMjAxNSwgMjAxNiwgMjAxNywgMjAxOCwg MjAxOSBMdWRvdmljIENvdXJ0w6hzIDxsdWRvQGdudS5vcmc+Cis7OzsgQ29weXJpZ2h0IMKpIDIw MjAgQnJpY2UgV2FlZ2VuZWlyZSA8YnJpY2VAd2FlZ2VuZWkucmU+CiA7OzsKIDs7OyBUaGlzIGZp bGUgaXMgcGFydCBvZiBHTlUgR3VpeC4KIDs7OwpAQCAtNDIsNiArNDMsNyBAQAogICAgICAgICAg ICAgZmlsZS1zeXN0ZW0tY3JlYXRlLW1vdW50LXBvaW50PwogICAgICAgICAgICAgZmlsZS1zeXN0 ZW0tZGVwZW5kZW5jaWVzCiAgICAgICAgICAgICBmaWxlLXN5c3RlbS1sb2NhdGlvbgorICAgICAg ICAgICAgZmlsZS1zeXN0ZW0tdXRpbHM/CiAKICAgICAgICAgICAgIGZpbGUtc3lzdGVtLXR5cGUt cHJlZGljYXRlCiAKQEAgLTExMSw3ICsxMTMsOSBAQAogICAgICAgICAgICAgICAgICAgICAoZGVm YXVsdCAnKCkpKSAgICAgICAgICAgICAgICA7IG9yIDxtYXBwZWQtZGV2aWNlPgogICAobG9jYXRp b24gICAgICAgICBmaWxlLXN5c3RlbS1sb2NhdGlvbgogICAgICAgICAgICAgICAgICAgICAoZGVm YXVsdCAoY3VycmVudC1zb3VyY2UtbG9jYXRpb24pKQotICAgICAgICAgICAgICAgICAgICAoaW5u YXRlKSkpCisgICAgICAgICAgICAgICAgICAgIChpbm5hdGUpKQorICAodXRpbHM/ICAgICAgICAg ICBmaWxlLXN5c3RlbS11dGlscz8gICAgICAgICAgICA7IEJvb2xlYW4KKyAgICAgICAgICAgICAg ICAgICAgKGRlZmF1bHQgI3QpKSkKIAogOzsgQSBmaWxlIHN5c3RlbSBsYWJlbCBmb3IgdXNlIGlu IHRoZSAnZGV2aWNlJyBmaWVsZC4KIChkZWZpbmUtcmVjb3JkLXR5cGUgPGZpbGUtc3lzdGVtLWxh YmVsPgotLSAKMi4yNi4wCgo= --=_231fb5def6ab3b0e49a1da5a744e0b19--