From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id IFipKcSoemYyWAEA62LTzQ:P1 (envelope-from ) for ; Tue, 25 Jun 2024 11:23:48 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id IFipKcSoemYyWAEA62LTzQ (envelope-from ) for ; Tue, 25 Jun 2024 13:23:48 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=riseup.net header.s=squak header.b=oLiQr4c8; dmarc=pass (policy=none) header.from=riseup.net; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1719314628; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=qbDclACcYxriKLN0F+8EzugaRpcgSU2kYQJAWHRTejI=; b=CzSdoefWF0nA4u45DBwFznLg6OXkmjDYwiNAut1Iu6JTJDQfZhXewywWEw17Mpe8IylKYZ B2HT14eBe5QcArZn3tb8UGIYxh1KcZdCsnXoGrlXB64w4WMTI7cYw9mH9fw3Ny1T9OlBWN ukcS98qwrkDnPU31Nkw/naVNhwkj4DTn20Nf8EkqOAYwzKYPO7Lui8hgpsJkTLg/RNa0in XkTkbI65fKMho4WBlplMIhLTKgaJHSf0vNqP1UbgQ4m13dfViPvHFICzwabyMGRtqeSa/d jZStomEWgfnMC/4v1+k1Fy/xEOW1iW8mjdvq/ZRYepCV6wMdbZenyBPsLTPJgg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1719314628; a=rsa-sha256; cv=none; b=nMssuEAwbzy2yB/QLwbwiV08XI3OBNZWtaRELsomHaTC9fzL1g78TqsSbLlAXImpwDW0Sc smFHq3tGOpWiqbF2Yk366mHmiBSoTBxghjtIO5JG4Dd3i7Bwxe7n1vXciM5jMUM1e0YcVf 3/JNWVzkuoyKTcc7Qp8qOx4cWE5OR5AWUVugaVl4zApJ7gb6UGu+6R/6TV2VB+m+UhyQnL Heq3+CWzLds2UxRZwZF/GQEMiyNQAOrp1/INvotwdat5cVvonsnSfBnzAwhxauF7/EwFW8 uQtmtqNlGXmCwTrYl+XvZhUF2k0P0mIbInwz9M8uHLLj1iqQRcSkoEHnqBXhCg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=riseup.net header.s=squak header.b=oLiQr4c8; dmarc=pass (policy=none) header.from=riseup.net; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 58B5574ADE for ; Tue, 25 Jun 2024 13:23:46 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sM4GY-0007J7-SD; Tue, 25 Jun 2024 07:23:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sM4GX-0007Ic-Sj for guix-devel@gnu.org; Tue, 25 Jun 2024 07:23:13 -0400 Received: from mx1.riseup.net ([198.252.153.129]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sM4GV-00041x-MP for guix-devel@gnu.org; Tue, 25 Jun 2024 07:23:13 -0400 Received: from fews02-sea.riseup.net (fews02-sea-pn.riseup.net [10.0.1.112]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx1.riseup.net (Postfix) with ESMTPS id 4W7jB51SYdzDq76; Tue, 25 Jun 2024 11:23:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1719314589; bh=UDrywi2s4U2TwzzoXsyEQv95PnexPvnkmxxeS9pYn5k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oLiQr4c8GZrQi7XtNd/bZhIsBMC2qjRXk/moQUCCEiNnQiKGFMlSRpS5KNiEVO18d 6C9kNIjTy9vP7wQTIrToGH+vNrWsP8iuv2eOABaa1E/JuYPkIimjE0s4VlWccPhK8A wjQtD1ykqOwgA2h77zJAUs5ykFOegycpKJfmm114= X-Riseup-User-ID: E21C4AC7EAFEBE5E2E33117EA34F7FECD97AB1ECF642BF1B3B9F50346C33E345 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews02-sea.riseup.net (Postfix) with ESMTPSA id 4W7jB456qhzFvKV; Tue, 25 Jun 2024 11:23:08 +0000 (UTC) MIME-Version: 1.0 Date: Tue, 25 Jun 2024 11:23:08 +0000 From: raingloom@riseup.net To: Ekaitz Zarraga Cc: Guix Devel , Arun Isaac Subject: Re: git based code review In-Reply-To: References: <1c1c0b649bcccdf231503d971bdcb4d0@riseup.net> Message-ID: Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=198.252.153.129; envelope-from=raingloom@riseup.net; helo=mx1.riseup.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.97 X-Spam-Score: -7.97 X-Migadu-Queue-Id: 58B5574ADE X-Migadu-Scanner: mx11.migadu.com X-TUID: 0D8n5u7y+/xT On 2024-06-24 16:18, Ekaitz Zarraga wrote: > Hi, > > On 2024-06-24 11:31, raingloom@riseup.net wrote: >> Since the email based workflow has put off quite a few potential >> contributors, maybe this could be a good distributed alternative: >> https://github.com/google/git-appraise >> >> Disclaimer: haven't tried it myself, also haven't tried packaging it. >> The Go and Rust dependencies could be hard to package with Guix's >> current tools. >> > > Arun is also developing a similar thing but it's not based on the git-notes for the issue system. I don't remember the name, maybe he can talk more about it. > > Also `fossil` does all this but "better" integrated. > > It's a very interesting thing to test but also our repo is already kind of huge. If we merge all the issues and stuff in it... It might become even gigantic. > > Also, the Mumi based workflow described here: > https://guix.gnu.org/manual/devel/en/html_node/Debbugs-User-Interfaces.html#Command_002dline-interface > > ...is probably way better than using `git send-email` raw. WDYT? > > I started with `git send-email` not that long ago, and *I* didn't find the workflow hard to follow. In fact, *I* think it's even easier than the PR based thing that is widespread right now. > > I'm not saying it isn't true that there is people that was put off by the email based workflow, but I'd like to know how many. > > In any case, it's a very interesting link! Thanks for sharing! > > Cheers! This is specifically for code *review*, not issue tracking or simply sending patches. PR review was one of the major problems with the email tools that I've seen mentioned.