From: raingloom@riseup.net
To: Ekaitz Zarraga <ekaitz@elenq.tech>
Cc: Guix Devel <guix-devel@gnu.org>, Arun Isaac <arunisaac@systemreboot.net>
Subject: Re: git based code review
Date: Tue, 25 Jun 2024 11:23:08 +0000 [thread overview]
Message-ID: <a45a96e925639a05c4b419ae4036f3a8@riseup.net> (raw)
In-Reply-To: <d88a54c6-07b5-c94f-49bc-d6622124e8be@elenq.tech>
On 2024-06-24 16:18, Ekaitz Zarraga wrote:
> Hi,
>
> On 2024-06-24 11:31, raingloom@riseup.net wrote:
>> Since the email based workflow has put off quite a few potential
>> contributors, maybe this could be a good distributed alternative:
>> https://github.com/google/git-appraise
>>
>> Disclaimer: haven't tried it myself, also haven't tried packaging it.
>> The Go and Rust dependencies could be hard to package with Guix's
>> current tools.
>>
>
> Arun is also developing a similar thing but it's not based on the git-notes for the issue system. I don't remember the name, maybe he can talk more about it.
>
> Also `fossil` does all this but "better" integrated.
>
> It's a very interesting thing to test but also our repo is already kind of huge. If we merge all the issues and stuff in it... It might become even gigantic.
>
> Also, the Mumi based workflow described here:
> https://guix.gnu.org/manual/devel/en/html_node/Debbugs-User-Interfaces.html#Command_002dline-interface
>
> ...is probably way better than using `git send-email` raw. WDYT?
>
> I started with `git send-email` not that long ago, and *I* didn't find the workflow hard to follow. In fact, *I* think it's even easier than the PR based thing that is widespread right now.
>
> I'm not saying it isn't true that there is people that was put off by the email based workflow, but I'd like to know how many.
>
> In any case, it's a very interesting link! Thanks for sharing!
>
> Cheers!
This is specifically for code *review*, not issue tracking or simply
sending patches. PR review was one of the major problems with the email
tools that I've seen mentioned.
prev parent reply other threads:[~2024-06-25 11:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 9:31 git based code review raingloom
2024-06-24 14:18 ` Ekaitz Zarraga
2024-06-25 11:23 ` raingloom [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a45a96e925639a05c4b419ae4036f3a8@riseup.net \
--to=raingloom@riseup.net \
--cc=arunisaac@systemreboot.net \
--cc=ekaitz@elenq.tech \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).