From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tobias Geerinckx-Rice Subject: Re: [PATCH] gnu: Add mcelog. Date: Wed, 14 Sep 2016 17:03:43 +0200 Message-ID: References: <1473859239-8101-1-git-send-email-me@tobias.gr> <8737l2d282.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="NP1jb5jqmCP6FuVGgJILKNOA6twAS20T7" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkBj7-0006EC-Rz for guix-devel@gnu.org; Wed, 14 Sep 2016 11:03:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkBj4-0000JG-2U for guix-devel@gnu.org; Wed, 14 Sep 2016 11:03:52 -0400 Received: from relay2-d.mail.gandi.net ([2001:4b98:c:538::194]:51622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkBj3-0000Iv-SN for guix-devel@gnu.org; Wed, 14 Sep 2016 11:03:49 -0400 In-Reply-To: <8737l2d282.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: mbakke@fastmail.com, guix-devel@gnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NP1jb5jqmCP6FuVGgJILKNOA6twAS20T7 Content-Type: multipart/mixed; boundary="HWX4PDOCHR6xpmO6EqcBjX8F9G4Ge7i1r"; protected-headers="v1" From: Tobias Geerinckx-Rice To: mbakke@fastmail.com, guix-devel@gnu.org Message-ID: Subject: Re: [PATCH] gnu: Add mcelog. References: <1473859239-8101-1-git-send-email-me@tobias.gr> <8737l2d282.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> In-Reply-To: <8737l2d282.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> --HWX4PDOCHR6xpmO6EqcBjX8F9G4Ge7i1r Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Marius, On 14/09/16 15:45, Marius Bakke wrote: > It's not visible in the cgit interface, but it actually seems to=20 > support normal snapshot downloads:=20 > https://git.kernel.org/cgit/utils/cpu/mce/mcelog.git/snapshot/v141.tar.= gz I did not know that. Thanks for the tip! It still requires a snippet, unfortunately. > Tobias Geerinckx-Rice writes: >> + #:tests? #f)) ; tests must be run as=20 >> root > Does all tests have to run as root? Yes. Each test wants to load modules & inject synthetic MCE events. The daemon will even fail to start on an unsupported CPU like my current AMD laptop. > Also, could you reverse the order of the arguments to match other=20 > package definitions? Hm: *some* other. I rather keep them in approximate order of use. Unrelated: I see the =E2=80=98arguments=E2=80=98 indentation went funky. = Will fix. >> + (home-page "http://mcelog.org/") > Nit-pick: the trailing slash is unnecessary :) Oh, I know, I just have a thing for proper root paths in URIs. I'm seeing someone about that. >> + (synopsis "Machine check monitor for x86 Linux systems") > If this is x86-only, perhaps we should set (supported-systems)? Indeed. Thanks! Kind regards, T G-R --HWX4PDOCHR6xpmO6EqcBjX8F9G4Ge7i1r-- --NP1jb5jqmCP6FuVGgJILKNOA6twAS20T7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCgAGBQJX2WbQAAoJEJHM25tIVBuZUbMH/2PqXOfE/hjug5eruRyZLy+I eAxp1ixEun1smiXYnJS0I2DTOndOeBut8SC9jExiCoaFS3dyMUefrfP3ZLNCgEGi zScoswp55Q6sL3XtLclwfTKPDE4/PsqJbWiMKF/6SXEtTXNG41cM1+VCCE/3o+DU JrYMjbwPc27teMDCO03IkhzX8IxKB1y+liVwOvClPrUtAA5UkqKjefYAu2MlwkNh HhKW8Ez/1J3wnKiYK+EinYMPm6j0HfMSQ+nn9o5W2IR9qUJ9RIP+FvLjh1rikpe5 NRhBwnkgqNRvI5Mvu4PsMEiM2RUDFgqMZfWSh94lLf3+xi1x0dsgMW0rf2jb1nE= =SN50 -----END PGP SIGNATURE----- --NP1jb5jqmCP6FuVGgJILKNOA6twAS20T7--