From: Leo Famulari <leo@famulari.name>
To: Vagrant Cascadian <vagrant@debian.org>
Cc: "Ludovic Courtès" <ludo@gnu.org>,
"Simon Tournier" <zimon.toutoune@gmail.com>,
guix-devel <guix-devel@gnu.org>
Subject: Re: ‘core-updates’ is gone; long live ‘core-packages-team’!
Date: Fri, 6 Sep 2024 14:06:37 -0400 [thread overview]
Message-ID: <ZttErY_GnAJd9iBe@jasmine.lan> (raw)
In-Reply-To: <87y144oew9.fsf@wireframe>
On Fri, Sep 06, 2024 at 10:44:54AM -0700, Vagrant Cascadian wrote:
> Is it just me, or is rebasing branches disconcerting, as it likely means
> the person signing the commit is not necessarily the original person
> pushing the commit? This is worst for the now deprecated core-updates
> branch with many rebased commits... are people still updating the
> signed-off-by tags or whatnot?
In Guix, the "signed-off-by" tag gives credit to the reviewer of the
patch, but doesn't indicate anything about authority to push to
guix.git.
In all cases, a commit that is pushed to guix.git will be signed by an
authorized committer. The signature system ensures that.
If we are concerned about long-running branches being rebased and
commits losing their "original" signatures, I think it's not really
something to worry about. That's because the signature *only* tells us
that that the commit was signed by someone who is authorized, and it
tells us *nothing* else. The code-signing authorization is extremely
limited in scope. It doesn't tell us that the code works, is freely
licensed, is not malicious, etc. So, it doesn't matter who signs a
commit, as long as it is signed by an authorized person.
Does this respond to your concerns? Or have I misunderstood?
next prev parent reply other threads:[~2024-09-06 18:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-31 13:03 ‘core-updates’ is gone; long live ‘core-packages-team’! Ludovic Courtès
2024-09-01 16:34 ` Steve George
2024-09-01 17:06 ` Christopher Baines
2024-09-03 14:02 ` Christopher Baines
2024-09-06 9:01 ` Ludovic Courtès
2024-09-09 15:30 ` Simon Tournier
2024-09-04 12:58 ` Simon Tournier
2024-09-05 8:39 ` Marek Paśnikowski
2024-09-05 9:40 ` Ricardo Wurmus
2024-09-06 9:11 ` Ludovic Courtès
2024-09-06 10:09 ` Andreas Enge
2024-09-06 11:35 ` Marek Paśnikowski
2024-09-06 13:25 ` Andreas Enge
2024-09-06 13:17 ` indieterminacy
2024-09-26 12:52 ` Ludovic Courtès
2024-09-06 17:44 ` Vagrant Cascadian
2024-09-06 18:06 ` Leo Famulari [this message]
2024-09-06 20:29 ` Rebasing commits and re-signing before mergeing (Was: ‘core-updates’ is gone; long live ‘core-packages-team’!) Vagrant Cascadian
2024-09-07 17:45 ` Leo Famulari
2024-09-08 2:33 ` Vagrant Cascadian
2024-09-06 19:49 ` ‘core-updates’ is gone; long live ‘core-packages-team’! Christopher Baines
2024-09-09 17:28 ` Naming “build train” instead of “merge train”? Simon Tournier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZttErY_GnAJd9iBe@jasmine.lan \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
--cc=vagrant@debian.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).