Re: 02/02: gnu: linux-libre: Update to 6.9.

Re: 02/02: gnu: linux-libre: Update to 6.9.

[Ludovic Courtès]

Hi Leo,

guix-commits@gnu.org skribis:

> commit 5d3edff1a604414a3c42b89fcbc007e9d573993d
> Author: Leo Famulari <leo@famulari.name>
> AuthorDate: Sun Jun 2 16:48:44 2024 -0400
>
>     gnu: linux-libre: Update to 6.9.
>     
>     * gnu/packages/linux.scm (linux-libre-version, linux-libre-gnu-revision,
>     linux-libre-pristine-source, linux-libre-source, linux-libre): Update to 6.9.
>     
>     Change-Id: I7383faceaf4679802047752088533e5deaa0d7f1

It seems that it broke ‘x86-energy-perf-policy’ and ‘zfs-auto-snapshot’:

  https://ci.guix.gnu.org/eval/1374635?status=newly-failed

Thanks for taking care of kernel upgrades, as always!

Ludo’.

Re: 02/02: gnu: linux-libre: Update to 6.9.

[Leo Famulari]

On Tue, Jun 04, 2024 at 08:41:47AM +0200, Ludovic Courtès wrote:
> It seems that it broke ‘x86-energy-perf-policy’ and ‘zfs-auto-snapshot’:
> 
>   https://ci.guix.gnu.org/eval/1374635?status=newly-failed

Aha, a new feature in the CI web interface! Wonderful!

The failure of 'x86-energy-perf-policy' appears to be spurious, caused by
the builder running out of memory, which happens often on our i686-linux
build environment on ci.guix.gnu.org:

------
xz: (stdin): Cannot allocate memory
------
https://ci.guix.gnu.org/build/4794093/details

But the failure of 'zfs-auto-snapshot' is real:

------
checking whether bdev_open_by_path() exists... configure: error: 
	*** None of the expected "blkdev_get_by_path()" interfaces were detected.
	*** This may be because your kernel version is newer than what is
	*** supported, or you are using a patched custom kernel with
	*** incompatible modifications.
	***
	*** ZFS Version: zfs-2.2.3-1
	*** Compatible Kernels: 3.10 - 6.7
	
error: in phase 'really-configure': uncaught exception:
------

As menitoned in the error message, this package does not support kernels
newer than 6.7. And, development appears to be suspended:

https://github.com/zfsonlinux/zfs-auto-snapshot/issues/117

Re: 02/02: gnu: linux-libre: Update to 6.9.

[Kaelyn]

Hi,

On Wednesday, June 5th, 2024 at 11:27 AM, Leo Famulari <leo@famulari.name> wrote:

> 
> 
> On Tue, Jun 04, 2024 at 08:41:47AM +0200, Ludovic Courtès wrote:
> 
> > It seems that it broke ‘x86-energy-perf-policy’ and ‘zfs-auto-snapshot’:
> > 
> > https://ci.guix.gnu.org/eval/1374635?status=newly-failed
> 
> 
> Aha, a new feature in the CI web interface! Wonderful!
> 
> The failure of 'x86-energy-perf-policy' appears to be spurious, caused by
> the builder running out of memory, which happens often on our i686-linux
> build environment on ci.guix.gnu.org:
> 
> ------
> xz: (stdin): Cannot allocate memory
> ------
> https://ci.guix.gnu.org/build/4794093/details
> 
> But the failure of 'zfs-auto-snapshot' is real:
> 
> ------
> checking whether bdev_open_by_path() exists... configure: error:
> *** None of the expected "blkdev_get_by_path()" interfaces were detected.
> *** This may be because your kernel version is newer than what is
> *** supported, or you are using a patched custom kernel with
> *** incompatible modifications.
> ***
> *** ZFS Version: zfs-2.2.3-1
> *** Compatible Kernels: 3.10 - 6.7
> 
> error: in phase 'really-configure': uncaught exception:
> ------
> 
> As menitoned in the error message, this package does not support kernels
> newer than 6.7. And, development appears to be suspended:

As a ZFS user, I'd like to offer a bit of clarification: zfs-auto-snapshot doesn't depend on any specific kernel versions, but zfs itself does. For example, zfs 2.2.3 supports up to kernel 6.7, and zfs 2.2.4 supports up to kernel 6.8 (ref: https://github.com/openzfs/zfs/releases). I suspect zfs is failing to build with the default kernel as a dependency of zfs-auto-snapshot.

Cheers,
Kaelyn

P.S. If there is interest, I can see about submitting my custom ZFS packages. I split it so that the "zfs" package is just the user-space tools without the kernel module (which should also make it substitutable since it no longer includes binaries with combined GPL and CDDL code), and created a function "make-zfs-for-kernel" that generates a package containing just the kernel modules, built for the given kernel package. This also addresses the issue of the zfs package depending on a kernel package that may or may not be needed (and which it may not compile against), and the user having to create a custom non-substitutable version--including all of the user-space tools--for the specific kernel they are running.

> 
> https://github.com/zfsonlinux/zfs-auto-snapshot/issues/117

Re: 02/02: gnu: linux-libre: Update to 6.9.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 3086 bytes --]

On Wed, Jun 05, 2024 at 09:00:59PM +0000, Kaelyn wrote:
> Hi,
> 
> On Wednesday, June 5th, 2024 at 11:27 AM, Leo Famulari <leo@famulari.name> wrote:
> 
> > 
> > 
> > On Tue, Jun 04, 2024 at 08:41:47AM +0200, Ludovic Courtès wrote:
> > 
> > > It seems that it broke ‘x86-energy-perf-policy’ and ‘zfs-auto-snapshot’:
> > > 
> > > https://ci.guix.gnu.org/eval/1374635?status=newly-failed
> > 
> > 
> > Aha, a new feature in the CI web interface! Wonderful!
> > 
> > The failure of 'x86-energy-perf-policy' appears to be spurious, caused by
> > the builder running out of memory, which happens often on our i686-linux
> > build environment on ci.guix.gnu.org:
> > 
> > ------
> > xz: (stdin): Cannot allocate memory
> > ------
> > https://ci.guix.gnu.org/build/4794093/details
> > 
> > But the failure of 'zfs-auto-snapshot' is real:
> > 
> > ------
> > checking whether bdev_open_by_path() exists... configure: error:
> > *** None of the expected "blkdev_get_by_path()" interfaces were detected.
> > *** This may be because your kernel version is newer than what is
> > *** supported, or you are using a patched custom kernel with
> > *** incompatible modifications.
> > ***
> > *** ZFS Version: zfs-2.2.3-1
> > *** Compatible Kernels: 3.10 - 6.7
> > 
> > error: in phase 'really-configure': uncaught exception:
> > ------
> > 
> > As menitoned in the error message, this package does not support kernels
> > newer than 6.7. And, development appears to be suspended:
> 
> As a ZFS user, I'd like to offer a bit of clarification: zfs-auto-snapshot doesn't depend on any specific kernel versions, but zfs itself does. For example, zfs 2.2.3 supports up to kernel 6.7, and zfs 2.2.4 supports up to kernel 6.8 (ref: https://github.com/openzfs/zfs/releases). I suspect zfs is failing to build with the default kernel as a dependency of zfs-auto-snapshot.
> 
> Cheers,
> Kaelyn
> 
> P.S. If there is interest, I can see about submitting my custom ZFS packages. I split it so that the "zfs" package is just the user-space tools without the kernel module (which should also make it substitutable since it no longer includes binaries with combined GPL and CDDL code), and created a function "make-zfs-for-kernel" that generates a package containing just the kernel modules, built for the given kernel package. This also addresses the issue of the zfs package depending on a kernel package that may or may not be needed (and which it may not compile against), and the user having to create a custom non-substitutable version--including all of the user-space tools--for the specific kernel they are running.

I imagine this would be a nice change for people who use ZFS.
Considering how often a kernel version update brakes the zfs package I
could also see switching the 'default' zfs package to use the default
lts kernel.

-- 
Efraim Flashner   <efraim@flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: 02/02: gnu: linux-libre: Update to 6.9.

[Leo Famulari]

On Wed, Jun 05, 2024 at 09:00:59PM +0000, Kaelyn wrote:
> As a ZFS user, I'd like to offer a bit of clarification: zfs-auto-snapshot doesn't depend on any specific kernel versions, but zfs itself does. For example, zfs 2.2.3 supports up to kernel 6.7, and zfs 2.2.4 supports up to kernel 6.8 (ref: https://github.com/openzfs/zfs/releases). I suspect zfs is failing to build with the default kernel as a dependency of zfs-auto-snapshot.

You're right, it was ZFS itself failing to build. I'm sorry I missed
that and didn't include sufficient info in my earlier message:

------
checking whether bdev_open_by_path() exists... configure: error: 
	*** None of the expected "blkdev_get_by_path()" interfaces were detected.
	*** This may be because your kernel version is newer than what is
	*** supported, or you are using a patched custom kernel with
	*** incompatible modifications.
	***
	*** ZFS Version: zfs-2.2.3-1
	*** Compatible Kernels: 3.10 - 6.7
	
error: in phase 'really-configure': uncaught exception:
%exception #<&invoke-error program: "./configure" arguments: ("--with-config=all" "--prefix=/gnu/store/x5sg337jfb7d7q26a1fv7zwc4mxpy6d8-zfs-2.2.3" "--with-dracutdir=/gnu/store/x5sg337jfb7d7q26a1fv7zwc4mxpy6d8-zfs-2.2.3/lib/dracut" "--with-udevdir=/gnu/store/x5sg337jfb7d7q26a1fv7zwc4mxpy6d8-zfs-2.2.3/lib/udev" "--with-mounthelperdir=/gnu/store/x5sg337jfb7d7q26a1fv7zwc4mxpy6d8-zfs-2.2.3/sbin" "--with-linux=/gnu/store/yi2cs6akr2anyci1bzqn6sfwwmrw1q9d-linux-libre-module-builder-6.9.3/lib/modules/build") exit-status: 1 term-signal: #f stop-signal: #f> 
phase `really-configure' failed after 42.6 seconds
command "./configure" "--with-config=all" "--prefix=/gnu/store/x5sg337jfb7d7q26a1fv7zwc4mxpy6d8-zfs-2.2.3" "--with-dracutdir=/gnu/store/x5sg337jfb7d7q26a1fv7zwc4mxpy6d8-zfs-2.2.3/lib/dracut" "--with-udevdir=/gnu/store/x5sg337jfb7d7q26a1fv7zwc4mxpy6d8-zfs-2.2.3/lib/udev" "--with-mounthelperdir=/gnu/store/x5sg337jfb7d7q26a1fv7zwc4mxpy6d8-zfs-2.2.3/sbin" "--with-linux=/gnu/store/yi2cs6akr2anyci1bzqn6sfwwmrw1q9d-linux-libre-module-builder-6.9.3/lib/modules/build" failed with status 1
builder for `/gnu/store/a3ag0m0hk2pqw446c3j5b7axzrg10h38-zfs-2.2.3.drv' failed with exit code 1
------

Should we change something about zfs-auto-snapshot? Or is the status quo
okay?

> P.S. If there is interest, I can see about submitting my custom ZFS packages. I split it so that the "zfs" package is just the user-space tools without the kernel module (which should also make it substitutable since it no longer includes binaries with combined GPL and CDDL code), and created a function "make-zfs-for-kernel" that generates a package containing just the kernel modules, built for the given kernel package. This also addresses the issue of the zfs package depending on a kernel package that may or may not be needed (and which it may not compile against), and the user having to create a custom non-substitutable version--including all of the user-space tools--for the specific kernel they are running.

I'm aware of the licensing issues around ZFS, but I haven't used ZFS so
I don't know anything about the finer points of how it is packaged and
distributed for Linux / Linux-libre.

If you think your packages would be useful to people using Guix System,
and that they satisfy the Guix project's commitments under the Free
System Distribution Guidelines, then I do recommend you submit them!

https://www.gnu.org/distros/free-system-distribution-guidelines.html

Re: 02/02: gnu: linux-libre: Update to 6.9.

[Andreas Enge]

Am Sun, Jun 09, 2024 at 09:19:14PM -0400 schrieb Leo Famulari:
> You're right, it was ZFS itself failing to build.
> 	*** ZFS Version: zfs-2.2.3-1
> 	*** Compatible Kernels: 3.10 - 6.7
> Should we change something about zfs-auto-snapshot? Or is the status quo
> okay?

Somebody has suggested an update to zfs, which apparently solves the
problem; both zfs and zfs-auto-snapshot now build according to QA:
   https://qa.guix.gnu.org/issue/71392

I have just pushed it (forgetting that the author is a new committer,
sorry).

Andreas

Re: 02/02: gnu: linux-libre: Update to 6.9.

[Kaelyn]

Hi,

On Monday, June 10th, 2024 at 2:26 AM, Andreas Enge <andreas@enge.fr> wrote:

> 
> 
> Am Sun, Jun 09, 2024 at 09:19:14PM -0400 schrieb Leo Famulari:
> 
> > You're right, it was ZFS itself failing to build.
> > *** ZFS Version: zfs-2.2.3-1
> > *** Compatible Kernels: 3.10 - 6.7
> > Should we change something about zfs-auto-snapshot? Or is the status quo
> > okay?
> 
> 
> Somebody has suggested an update to zfs, which apparently solves the
> problem; both zfs and zfs-auto-snapshot now build according to QA:
> https://qa.guix.gnu.org/issue/71392
> 
> I have just pushed it (forgetting that the author is a new committer,
> sorry).
> 
> Andreas

I saw that ZFS update patch as I was prepping my ZFS package changes for submission--I had the 2.2.4 update as part of the series, and decided to wait until the already-submitted package update landed to send in my ZFS package rework.

My package rework is issue #71482, and I think is a better solution since packages like zfs-auto-snapshot depend on the zfs user-space tools. Additionally, the updated ZFS package is only a temporary fix as ZFS 2.2.4 only supports up through Linux 6.8 kernels (and linux-libre 6.9 was recently made the default).

Also, thank you Efraim and Leo for a bit of encouragement, which motivated me to finally submit my reworked ZFS packages for upstream inclusion. :)

Cheers,
Kaelyn

P.S. For my patch, I didn't include any calls to 'make-zfs-for-kernel' for any of the linux-libre kernels, since the resulting packages aren't substitutable and the kernel version needed would be use-case dependent.