gnu: xkeyboard-config: Upgrade to 2.41.

gnu: xkeyboard-config: Upgrade to 2.41.

[B. Wilson]

[-- Attachment #1: Type: text/plain, Size: 582 bytes --]

Note that the canonical location for sources has changed from
ftp.freedesktop.org to x.org. See the below discussion on the xkeyboard-config
issue tracker:

https://gitlab.freedesktop.org/xkeyboard-config/xkeyboard-config/-/issues/353#note_2431606

The old location still works, but it remains several versions behind upstream.

On my machine, the referrers of xkeyboard-config are:

    libxkbcommon
    setxkbmap
    xkbcomp
    xorg-server

What's the proper procedure when updating packages to check that its reverse
dependencies aren't broken by the change?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-xkeyboard-config-Upgrade-to-2.41.patch --]
[-- Type: text/x-patch, Size: 1416 bytes --]

From 9ed36ee6ea9479007108e696afa389d5030c2280 Mon Sep 17 00:00:00 2001
From: "B. Wilson" <elaexuotee@wilsonb.com>
Date: Fri, 31 May 2024 08:58:07 +0900
Subject: [PATCH] gnu: xkeyboard-config: Upgrade to 2.41.

* gnu/packages/xorg.scm (xkeyboard-config): Upgrade to 2.41.
---
 gnu/packages/xorg.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
index c13a1f4215..6b7a66bf51 100644
--- a/gnu/packages/xorg.scm
+++ b/gnu/packages/xorg.scm
@@ -3771,15 +3771,15 @@ (define-public xkbutils
 (define-public xkeyboard-config
   (package
     (name "xkeyboard-config")
-    (version "2.38")
+    (version "2.41")
     (source (origin
               (method url-fetch)
               (uri (string-append
-                    "ftp://ftp.freedesktop.org/pub/xorg//individual/data/xkeyboard-config/"
+                    "https://www.x.org/releases/individual/data/xkeyboard-config/"
                     "xkeyboard-config-" version ".tar.xz"))
               (sha256
                (base32
-                "0wn8asnbz111194ksi2mysa6ikn4kqgd9rpfydl8icc6mcdsk406"))))
+                "13vjvyg1fjvsqzqkpxzigvv94v154mcb2gba4d80spi9aywxcb7h"))))
     (build-system meson-build-system)
     (inputs (list libx11 xkbcomp-intermediate))
     (native-inputs (list gettext-minimal libxslt perl pkg-config python))
-- 
2.41.0

Re: gnu: xkeyboard-config: Upgrade to 2.41.

[Andreas Enge]

Hello!

Am Fri, May 31, 2024 at 09:21:07AM +0900 schrieb B. Wilson:
> What's the proper procedure when updating packages to check that its reverse
> dependencies aren't broken by the change?

You can run this:
$ guix refresh -l xkeyboard-config
which replies with
Building the following 1876 packages would ensure 4038 dependent packages are rebuilt: localed@241 wlgreet@0.4.1-1.7e79d60 ...

Which means that once you have run "guix build localed", "guix build wlgreet"
and so on 1876 times successfully, then all dependents will have been built.

In this particular case, one should probably create a branch with a number
of related changes and have CI build it.

Andreas

Re: gnu: xkeyboard-config: Upgrade to 2.41.

[Felix Lechner via Development of GNU Guix and the GNU System distribution.]

Hi B. Wilson,

On Fri, May 31 2024, B. Wilson wrote:

> What's the proper procedure when updating packages to check that its
> reverse dependencies aren't broken by the change?

In Guix, the standard is that consuming packages build.  It's a low bar
because upstream changes and packaging errors can also break the runtime
performance of consuming packages.

As Andreas pointed out, our CI infrastructure builds the packages for
you.  CI also runs some build-time tests but those are stop-gaps that do
not catch packaging errors or many other problems.

That being said, xkeyboard-config is a very mature package. A change of
upstream locations should have no effect (and would immediately fail to
build).  The version bump probably also has no effect, although that
software has seen a fair amount of activity lately. [1] We would also be
jumping several versions, from 2.38 to 2.41.

It would be nice if you have time to rebuild everying locally, but I
would simply commit the patch to Guix provided the new version builds,
and run with it.  We can always revert.

Thank you for your contributions to Guix!

Kind regards,
Felix

[1] https://gitlab.freedesktop.org/xkeyboard-config/xkeyboard-config