On Wed, Apr 24, 2024 at 11:58:22AM -0400, Jason Conroy wrote: > > Efraim Flashner writes: > > On the other hand, by generating it during the build of each package we > > make sure to pull in all the crates which exist in the build, so we > > could add into a profile/manifest just the crates listed in a Cargo.toml > > and then each crate would pull in its own dependencies, and then the > > profile hook could combine them all together. > > Thanks. Just to make sure I understand: it sounds like you're saying that by > creating the JSON index files up front, we'd be preserving some knowledge > about a package's dependency graph that isn't easily recovered later by > recursively walking through inputs and cargo-inputs for the package specs in > a manifest/profile? If we create it upfront it may be easier to keep track of the cargo-dependencies, but I suppose it would mostly depend on the implementation. I'm not sure that'd actually be the case, so don't worry about it too much. Whatever we end up with will be better than what we have now, and we can always make it better later if it needs to change. -- Efraim Flashner רנשלפ םירפא GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted