From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id aF7JOPgnKWbzRAEAe85BDQ:P1 (envelope-from ) for ; Wed, 24 Apr 2024 17:40:41 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id aF7JOPgnKWbzRAEAe85BDQ (envelope-from ) for ; Wed, 24 Apr 2024 17:40:41 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=QhBPfSwS; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1713973240; a=rsa-sha256; cv=none; b=G5sCKjOKY6ZuXoiCYtCA99Q+qjdQxj3ol/cNqOo3O00f5mMFp1c0lgYxu6XR61LpGt0wlS 8X11xbAh5ZWSFEwMavluKuLiPlGs9nFg1wRThV6mdkQ3n41gGmAjCPLHXMEGuMNwj0RwvL 54jmnFxdqvbibg2kPWQwjHWH0sDWBE+4XBh21KWqBj+oeYnZVbKJX7Z8ukCzYePSJnO1zU 0DxVOjhfw6DBWTL6NU6QKVv/mCUMDxPR1zKFDeqSd3qFeoyMQuqeNZ4oku/rW/hpuEPh/I bAZ/JGsiGXGLplFsb6uZL5JNwuZDCRhMI4h/D3CQw4Ipx3PdJwfEQLRLlxOIUA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=QhBPfSwS; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1713973240; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=rTzeNwj4QHZkuSAFfLPyx0LDcwlIbcFt3YD/6GhebWk=; b=EymCaRKbrlGhRpGKB6qNJFNzS7KShh2gzoPpZ8+iaoGgVlf0SWtskvBvAsx/uiAcE/TxZF vwDDcnjrCJSmWQpLzT1jOsKRrhpLGEHxyTTUmBXCRFQ/qMD7IgjB6MgYcJ1sGKMcWRhYsz Lrc0echlVLhbpLZtcZsC2Vx8T/hJc7Mz9gPxR62lAjIH1Kdnh+SG+JryduGAPvXA5pzZ1u EwCCcXaJk+lZGZfISzP4f4Vuh0xtjQN/twS2rXLDoJkbTACADbcZoANOgvgmklMC7H8YMD Ljw/8Bar5CKRjH0Nn8PyPaXlx2Lkms2uY0k0mDTbS63CFrOlqoRoN/Jl9lQNgQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 59E6EE99A for ; Wed, 24 Apr 2024 17:40:40 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rzeio-0002rG-K2; Wed, 24 Apr 2024 11:39:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzeie-0002U1-HQ for guix-devel@gnu.org; Wed, 24 Apr 2024 11:39:37 -0400 Received: from mail-qk1-x732.google.com ([2607:f8b0:4864:20::732]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rzeic-0005w6-6a for guix-devel@gnu.org; Wed, 24 Apr 2024 11:39:36 -0400 Received: by mail-qk1-x732.google.com with SMTP id af79cd13be357-78f04924a96so531879385a.0 for ; Wed, 24 Apr 2024 08:39:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713973173; x=1714577973; darn=gnu.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=rTzeNwj4QHZkuSAFfLPyx0LDcwlIbcFt3YD/6GhebWk=; b=QhBPfSwSMH/s0uPNmd2UwaX5WG7q99H0KYdtC5LbrkcPP0SMB9pzS7CIMGgCyQSkek V98dwfLJa5ycdpI2mDAvrL+t0xlmOcvzXOyn96F+mj3nqZeGZQ98KE4sg7m82XkEJioC J7toSaO4iGYaaZA1ivVYNprlS83TL+EwLEKhXkmOoYPiyDPrUg9d6ogz+7yw2Bag1cxV pa6rXkcbhca93O0BFDD070YzFTfP3Q3oKgiQ0zAO90UqZiswZWumYBiXWQjWsae1h9wJ HWTmuiCLR7yF8/qz3uELpWtIjxqxpZ7RPcUVXfrJIt4CIT78i+aQqZfIt0laj/Z+5fEc SQTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713973173; x=1714577973; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rTzeNwj4QHZkuSAFfLPyx0LDcwlIbcFt3YD/6GhebWk=; b=Peo6j9RHYdN+9e0lLBANRUspcZ5mHADS5xu6EtC28o03sCSnCLKTGAfxEiw6fTO682 TuEj0EyiiEU1/JuaX/rVLs2p5T73bie9AeiHuka13uN5EpJOiLkIHfsFBCxoPNSO6IDd KJZ2hfYqNCQDpk4kkXyP935n/ZvOEvZdbXzX0eyA3+9Gp6y7R/8WEiygLVzANjQna/Qu PS6oSj9z+160Qd4bvMdJjD1cpZiMMEiIsaTOz6VonGJv/K/K0KPsekmLBMSEdbiCoLyE IHm872gmxaUIaBPftef3OJJcysICuCDmq2DpzWUXygVWLWwAmF/vi5B3XgWLOkcGCic1 AhRg== X-Gm-Message-State: AOJu0YyQcqsvJP2sKpgnk26Y2YnqGR9RdFgkh3d/P3ChumwoFwSjKNEQ hl+oa6a4WiWJ/J2Tap+hwE7R1sN4WyG3frRA4u0Luwc4LD2Pu6av X-Google-Smtp-Source: AGHT+IHgywrDo/SeNxf3ABbVPvKo1LYcplosB2SjhU2FphyuRc2K6Fl48Cmxx9/IhKjsUWHIwtdohQ== X-Received: by 2002:a05:620a:891:b0:78a:724b:af30 with SMTP id b17-20020a05620a089100b0078a724baf30mr2723229qka.24.1713973172449; Wed, 24 Apr 2024 08:39:32 -0700 (PDT) Received: from localhost (ool-ad039216.dyn.optonline.net. [173.3.146.22]) by smtp.gmail.com with ESMTPSA id h14-20020a05620a10ae00b0078d6303c099sm6208011qkk.112.2024.04.24.08.39.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 08:39:31 -0700 (PDT) Date: Wed, 24 Apr 2024 18:39:31 +0300 From: Efraim Flashner To: Jason Conroy Cc: guix-devel@gnu.org Subject: Re: rust-team branch merged Message-ID: Mail-Followup-To: Jason Conroy , guix-devel@gnu.org References: <21GRCQ0Z0K9NXCO1IEDLT7V9RGQLRCVDMN1TT5B106HNS6E4S@tscripta.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mMg4GS2Uox3PJZWX" Content-Disposition: inline In-Reply-To: <21GRCQ0Z0K9NXCO1IEDLT7V9RGQLRCVDMN1TT5B106HNS6E4S@tscripta.net> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Received-SPF: pass client-ip=2607:f8b0:4864:20::732; envelope-from=efraim.flashner@gmail.com; helo=mail-qk1-x732.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: -6.99 X-Migadu-Queue-Id: 59E6EE99A X-Migadu-Spam-Score: -6.99 X-Migadu-Scanner: mx10.migadu.com X-TUID: g+qBiKT7xouJ --mMg4GS2Uox3PJZWX Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 18, 2024 at 12:54:02PM -0400, Jason Conroy wrote: >=20 > Efraim Flashner writes: >=20 > > Currently if you were to pull in rust-rand-0.8 and rust-rand-0.7 then > > you'd have both rand-0.*.crate files in the registry but only one of > > them would be listed in share/cargo/registry/index/ra/nd/rand. I need to > > adjust the generation of that file to combine multiple sources if they > > exist, and sort them (I'm not sure it's necessary, but wouldn't be > > surprised if we hit undefined behaviour if they were listed multiple > > times or out of order). >=20 > Hi Efraim, >=20 > I'm currently investigating this limitation of your proposed patch. >=20 > Did you have a strategy in mind for how to fix it? I see that the index > files are currently generated during a phase of cargo-build-system, rather > than as a profile hook. So, to build an index that properly reflects the > contents of a profile, it would seem that the two simplest options are: a) > keep your existing index-generation logic during the build, and merge the= se > per-package index files when building the profile; or b) move your patch's > index-generating code out of the build phase and into a profile hook, so > that we build each index file in a single pass (for all versions of a > package) rather than merging the files from each package output. >=20 > On the surface option (b) seems cleaner, but maybe you had a reason for > generating the index contents during the build? I like the idea of moving the code into a profile hook much better than what I have now. What's there was more of a proof-of-concept of how it might work. On the other hand, by generating it during the build of each package we make sure to pull in all the crates which exist in the build, so we could add into a profile/manifest just the crates listed in a Cargo.toml and then each crate would pull in its own dependencies, and then the profile hook could combine them all together. The down side is we'd have to have the logic to combine the overlapping rand-0.7/rand-0.8 paths both in the build system and in the profile. Overall it doesn't seem that bad though, since we could then add packages either as a regular input or as a cargo-input. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --mMg4GS2Uox3PJZWX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmYpJ6wACgkQQarn3Mo9 g1HdPhAAvL/Bb7CwqDi1wfJEnydBO2ImzAJODhAifal/V5k4SwQjtMr7YvoyM3+j 6NXBsZfQQYLP+Be7Ab8euBCBC9ZnyKBs0rNK1bJDE746w1OUqaNxlYLtn9G5sRn0 tAf+F0ss8DWC8JkSLQgh27ibU01bskL4Clv12YWG041ygX3to3hyRa3mVVqA7B09 1W6gVLpRGTveIDcStXoPGVij+nWIg/NM/8rfZqYMhvzhJa3G1Jy6mB5B9J74G3Fb nv1Jdu24LzH9f0aOMVvlY1/w4xtxtmPDxepYoNgzxWMZwsj0BL00+b9kbzDEn9dF 9USPn35UjbmOEWA0ceNHt73OKB+P4VpjuQ3E89mokKtjv8QP8kwzH0S5eK2OCjuY gjyApK61dFbsoczDHQeVmAOmWk3s3LCQbu1C/1OcGZN5AVUrFgltbE3Piu8+uOM9 6iQPRG9d3w4nr1KAh3s2/cM6jJiPkiixwiy0kb0YixFvrfz4kYYQkehVEi5bDcbV WcoL/V34q/xKY4SD6CkvNpH4LakZLlLQf0a13P/x0+iyQcY+d3A2FPL7INRxpz/Z r3zduplNsF7Y9oAbgLDqaD1ize+Z6PlA4vwxxusAJV/JJ1hHAAn8VPKqpmKfGhoQ bIWy0o7SeLPCf/mM55mpwRvd97VSe0skpF8dYWt9O7IHDgMF/yw= =Xs28 -----END PGP SIGNATURE----- --mMg4GS2Uox3PJZWX--