From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id 6It+A46uD2b4WgEAqHPOHw:P1 (envelope-from ) for ; Fri, 05 Apr 2024 09:55:58 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 6It+A46uD2b4WgEAqHPOHw (envelope-from ) for ; Fri, 05 Apr 2024 09:55:58 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=futurile.net header.s=selector1 header.b=O8821hg6; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1712303758; a=rsa-sha256; cv=none; b=Gv/dIOEDvdZaUpDJP/R5M6lgZ0ufiNsufzZvyF4/adi+fDfK0jQ+SzCY+rwqgEHd0CZ3VB rVabNpiCxzZEUDjUSVaha931KchAj+rl88cHXC1a+lsbOge/YJUCGI92E3mrQgpFnizSmb 03StPaJtqvCFsEObVjr/fYKMuBSfzn7nIzbjcGDx9QGim0lhkWZis8KbYhE7uXUQiI1Oid G8mN9bb8V4hvB4ul5dwXjs3LUgtbCLXOmE1HW+WBVUJ9zxw6nRlW+GEmHgWuJFFNw3QdAs wecm1k6axdku8ONMiUO4X8TgEGE2dDol13z7IyDQHVFoHP6qiOA4gW4xQt/x0w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=futurile.net header.s=selector1 header.b=O8821hg6; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1712303758; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=rjAoEf60QnR1oZOr+Aoo6BLQ8o1ykcLcuRmSKZi1wG8=; b=DoYmVg4cTlt+8XJMFqOJ3nR8b308/gxN+tqug7LDL5Sd6o9Jn9JPZ9l1qQFhqv1IYIOJDW NeOjyhIiPVGicgzTlJqbBoA+8eybVlTTOm/isVXb4BHikoXqwurqD/xRzn64lwf8ufQlg6 hQqWUZHYx6CnWl7y9W/2iSziJYUdZlCAHUTz7DuE14LXqzq6gWwJCOYu8jAmJ0hO73WhMN IRGbZPObYWCoCu0YKcIxLEPpkWDupujO84UTWFOYzs+m6Gi5JV2WTvsBm8UysfS6W+3GNI AxMfSEF2MeBL8Sgy6jkWXW/LCTG5Uq43Sju3h3QD6cilGgBfHHD9K2FnzlsxWQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 89E33246ED for ; Fri, 5 Apr 2024 09:55:57 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rseQ2-0007Mw-Eb; Fri, 05 Apr 2024 03:55:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rsePz-0007IW-Gx for guix-devel@gnu.org; Fri, 05 Apr 2024 03:55:23 -0400 Received: from mailtransmit05.runbox.com ([2a0c:5a00:149::26]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rsePu-0003LD-3p for guix-devel@gnu.org; Fri, 05 Apr 2024 03:55:21 -0400 Received: from mailtransmit02.runbox ([10.9.9.162] helo=aibo.runbox.com) by mailtransmit05.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1rsePo-002oFM-7S; Fri, 05 Apr 2024 09:55:12 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=futurile.net; s=selector1; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date; bh=rjAoEf60QnR1oZOr+Aoo6BLQ8o1ykcLcuRmSKZi1wG8=; b=O8821hg6scqZDlje8jv0p1ylKV 1ot3pKUXhKXf+T6q4gebKCYBieQGbCBVpim4E1xYw9PCZmFeo05d5QB2DUFjcdHllMplaIp21V4gP R2UC3x9byFoFfNivwV+sVaP2gJRe1hQ+cb9DlVfiHorHPmKqsWEacgIQrzW7+S4bZLEK144Jjhrqj m1pZvCOmf/H+hINh+jKzpAzd7yseA2ToYmzWnAkk3lSEXJ729Z1jc7wO6h5dStKoj/oDFxLpyE7Ru U3/lqJAS2/O+ovfybga2kATN0+Xxd0gqryAIt9hB9lEF4R/+AkG6/L0pdETWFtNJ7nppZbIhQYlBa FC8/YecA==; Received: from [10.9.9.74] (helo=submission03.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1rsePn-0003GW-C5; Fri, 05 Apr 2024 09:55:11 +0200 Received: by submission03.runbox with esmtpsa [Authenticated ID (641962)] (TLS1.2:ECDHE_SECP256R1__RSA_SHA256__AES_256_GCM:256) (Exim 4.93) id 1rsePb-003WqC-UW; Fri, 05 Apr 2024 09:55:00 +0200 Date: Fri, 5 Apr 2024 08:54:59 +0100 From: Steve George To: Christina O'Donnell Cc: guix-devel , efraim@flashner.co.il Subject: Re: Coordinators for patch review session on Tuesday Message-ID: References: <55f9be63-419e-57ba-7bd8-691cf80ab012@mutix.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Received-SPF: permerror client-ip=2a0c:5a00:149::26; envelope-from=steve@futurile.net; helo=mailtransmit05.runbox.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, T_SPF_PERMERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: -8.76 X-Migadu-Queue-Id: 89E33246ED X-Migadu-Spam-Score: -8.76 X-Migadu-Scanner: mx10.migadu.com X-TUID: yL6tAZbRbLJu On 4 Apr, Christina O'Donnell wrote: > Hi, > > Thanks for your reply, > > > 1. Changing the tag to reviewed-looks-good > > > > It doesn't look like this worked. The way to do this is in the instructions are 4. 'Set a user tag' [0], probably the easiest way is to send an email (I do get funny results sometimes with my email client): > > > > Subject: setting usertag on 65938 > > > > user guix > > usertag 65938 + reviewed-looks-good > > quit > > > > The first line is important it has to be 'user guix' for it to appear on the patch review reports [1]. I think I messed up the instructions in the Wiki - you have to have a + in between the bug number and the tag you want to set (sorry about that). Please try again. > > Ah I got it this time. I was missing the 'user guix'. I didn't read the wiki > and tried to look it up from the debbugs documentation. > > > This is really just a way of signalling that reviews are happening - so trying to keep us in sync. The usertags we're using are: > > > > - patch-review-hackers-list > > - under-review > > - escalated-review-request > > - waiting-on-contributor > > - reviewed-looks-good > If I change the patch quite a lot, should I mark it as > 'escalated-review-request' instead of 'reviewed-looks-good'? Since a maintainer will look at it anyway before it's committed, and you are going to 're-roll' it as a v2 (which they will see) I wouldn't bother. I've been using 'escalated-review-request' for (a) ones I see that are just too hard for me, (b) if I personally think there's some outstanding issue with the patch that I can't solve. > > And should I remove them from the patch-review-hackers-list after I've > responded Yes please - if you remove it from that list, and you make yourself the owner then I hope we'll keep people co-ordinated! > > The patch changes all look reasonable to me, you've already done a lot: > Great, thanks! Good to know I'm doing things vaguely right! > > 1. You should add a reviewed-by trailer: > > Reviews are contributions from our community (and work!) so we should recognise them and add trailers. It also helps the maintainer know who did the review and therefore the level of confidence. > > > > Basically just add 'Reviewed-by: A Person - [2] > Sure, do you want me resubmit these patches to add that? No - I think you're all good, it looked they were both going to the build system last night. > > It looks like your updated patch retriggered QA, so if you look here and the foolow the Data Service link on the right you can see it's building it: > > > > https://qa.guix.gnu.org/issue/65938 > > > > The last step will be for a maintainer to see that it's built correctly, see your review and to apply it - great job for a first patch review! > Wonderful! The first of many, I'm hoping. (...) Keep an eye on them in QA, and see if a maintainer sees them. If nothing happens after 10 days consider pinging on IRC. Thanks, Steve