From: Andreas Enge <andreas@enge.fr>
To: Tanguy LE CARROUR <tanguy@bioneland.org>
Cc: Christopher Baines <mail@cbaines.net>, guix-devel@gnu.org
Subject: Re: QA is back, who wants to review patches?
Date: Fri, 9 Feb 2024 15:30:44 +0100 [thread overview]
Message-ID: <ZcY3FMcBotVsQo8b@jurong> (raw)
In-Reply-To: <170748683930.31258.93939168966791516@bioneland.org>
Am Fri, Feb 09, 2024 at 02:53:59PM +0100 schrieb Tanguy LE CARROUR:
> Quoting Christopher Baines (2024-02-09 14:44:25)
> > Tanguy LE CARROUR <tanguy@bioneland.org> writes:
> > > Can I safely close it?!
> >
> > Yep, this unfortunately looks like a case where there was a duplication
> > of effort and the original patch got ignored.
> >
> > It looks like the issue has been closed now.
> Not me! 😁
As the old German saying goes, "two idiots, one idea" :-)
I also immediately jumped to this easy looking patch, came to the same
conclusion as you and closed it. This is a lot of review work for a patch
where there is nothing to do...
Actually the next patch I tried to apply was also already there, and the
committer had just forgotten to close the issue.
Andreas
next prev parent reply other threads:[~2024-02-09 14:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 10:44 QA is back, who wants to review patches? Christopher Baines
2024-02-09 12:43 ` Clément Lassieur
2024-02-09 13:31 ` Tanguy LE CARROUR
2024-02-09 13:44 ` Christopher Baines
2024-02-09 13:53 ` Tanguy LE CARROUR
2024-02-09 14:30 ` Andreas Enge [this message]
2024-02-09 15:08 ` Tanguy LE CARROUR
2024-02-11 8:01 ` Andreas Enge
2024-02-09 15:04 ` Andreas Enge
2024-02-09 15:57 ` Christopher Baines
2024-02-10 8:28 ` Vivien Kraus
2024-02-10 9:42 ` Christopher Baines
2024-02-10 8:40 ` Vivien Kraus
2024-02-10 9:43 ` Christopher Baines
2024-02-12 0:21 ` Ian Eure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcY3FMcBotVsQo8b@jurong \
--to=andreas@enge.fr \
--cc=guix-devel@gnu.org \
--cc=mail@cbaines.net \
--cc=tanguy@bioneland.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).