From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 6M8fClr4wGUwKgEAqHPOHw:P1 (envelope-from ) for ; Mon, 05 Feb 2024 16:01:46 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 6M8fClr4wGUwKgEAqHPOHw (envelope-from ) for ; Mon, 05 Feb 2024 16:01:46 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=wolfsden.cz header.s=mail header.b=CQ6B1Y1s; dkim=pass header.d=wolfsden.cz header.s=mail header.b=Ww+xbCa7; dmarc=pass (policy=none) header.from=wolfsden.cz; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707145306; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Gl2yFrH/sTgIAiVvd/3dPvwPuOFsj74Ui4rLgqxkhRk=; b=cE4O3uqifX3A/n/fUYeCweijMw+Fbl6xC0sUi10ltV10gTxd5u9XKAhcrb0vTW8YNNBn+4 1a2bROolqizlfdn7qN24Zg8q91n2LPUg0MA6Yyd10ZN9hHht2aBLL6UBdGeu2uWnWV5ajy AyzaUIJui6saS0EoebC/pcQegZ4211S/irscs9fCgUwh0BAtiJsQRmp530GlxspFmASsZ3 227hvIhx+brIkgy56dml5gvRAi7rAKpV9ld1V4cM/0dZMVQqEY2TIhdvGKVUYtTG+sE5m9 7W87Yg79GggXBpy+m6qqKckbEvl8BI9EXvY9m31CF5M1h4GSYUo/Eyrtupv85Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=wolfsden.cz header.s=mail header.b=CQ6B1Y1s; dkim=pass header.d=wolfsden.cz header.s=mail header.b=Ww+xbCa7; dmarc=pass (policy=none) header.from=wolfsden.cz; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707145306; a=rsa-sha256; cv=none; b=QtT2BZPsqY6lLxcpoZG0DHB/Z5Su3Ef3r8jErXGxgtEF0B9ytZHNFGH0NAdReGLtSTx1AZ 5pYZGrK/IzOEDm/gIHabVMPXudp0gT1DrMy3lRX1QaTw+qog6QTkmUV+448a2vcoYBPGdm jK0l307p9FS2pY52h2tPWwcYaf7wivYfXqwcHN9iEujBK6LHWc/Qvv1C8FGWUU2D1p5qah 0KsLgKsdShdn3QvtZo9vGBgMpiFLN5Z9WIumhS7+kiiQVUY6DxRR4ozOG0C7r1hLZo4Fsb azySrMhj1gPYxbGOVQrvp918RZK5+Fp2B+RQ5klsBKpqNu62W2h4oZCj56q7GQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 13D92200FD for ; Mon, 5 Feb 2024 16:01:45 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rX0Sv-0004fW-4Z; Mon, 05 Feb 2024 10:00:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1rX0So-0004ej-SK for guix-devel@gnu.org; Mon, 05 Feb 2024 10:00:54 -0500 Received: from wolfsden.cz ([37.205.8.62]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1rX0SX-0002yN-Eh for guix-devel@gnu.org; Mon, 05 Feb 2024 10:00:50 -0500 Received: by wolfsden.cz (Postfix, from userid 104) id 083ED28A04D; Mon, 5 Feb 2024 15:00:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1707145215; bh=TAUF1ri4Hr3d6sW950G1t9tVlChAoiwMfJ9tpKbGo/U=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=CQ6B1Y1syBaGn1BPaCmS0G27XPAwolD1JJlNSiVcrdl4xx8AwwUYeweifzGaAsqnT cpqm20bx38BJZAdCBwu4b20M9FpQ5gBdoSskLdf3gEGlV9E0eOjYcWJQ6oEUSeKNYb 55NvAaQQM8g1eKZrOD6yeuOpKWJV8YcNZQY4BFpdmNsyrE+IyAnB492KPu5k/Vz1gr lMEo2QkfnhaUuq5vkawaBC1mU64DPFMMxW9OBgvJH0oZb7qMhsIEF3QhhLziPN7lDv nXFG1zhyWpn+x1TDh6NdEL2hpa/17MxFRq8KUt9StOOzDPaKnk8aN+khsk1VQTMP5D xCCeGiMne8YuoHlsSuvHCAiUMM9Gb3m/PESNcg5CWgvMHWIuxRDmRs0AMIt/oHPpBw /nciqnJ8wv0nR7MB+iZRgn188rF+Wyxv4O7j4UJI4b4GNP7Ps0i15zLXxxlreZateD ZItU6gjYbHpE8KPbTx3EXBZ60oXBKM8rBH/7IxHHXnyXdz07Hm+sBCWhdjXcxf6Oxx RNsVVQsJOfaAywkfvs7PRdCI2KjPMEzi9PNct/IQyfnF0SZSDQ9ddzjfxgZyQHjdk6 AxuE/vCVoeneYY9QEhd/bycsrv5A76O0xV27rAK5+ErgUSlca4+C8qaDh8WDcMvc3l kva1V2uwJq+Cn86tUMh2IOy0= Received: from localhost (unknown [81.17.16.75]) by wolfsden.cz (Postfix) with ESMTPSA id 95E2028A13A; Mon, 5 Feb 2024 15:00:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1707145213; bh=TAUF1ri4Hr3d6sW950G1t9tVlChAoiwMfJ9tpKbGo/U=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Ww+xbCa7kVdSo0UzMJNPZ7+3gFuwyHO44hJl+7K+sF2SfelgCUnG2mXkuGPWSD9RA BsDraZx2AA/cs/3Nrl5THYDe9zXcJopQi8kHSOb11EcY6PQMGCyxReIIvWMdZjxc/5 tHrJ9akNvvscV1sr571B3ubcs+TUGlzwrQofmfyq4G2pIcZ8LQsVGe/+nOZz/6CrHZ 9lCzbhsFPUtijrUvTujU03GvoOAG43LgAO+rdtz1WcKYZZJwrnVJ0SHlyribWUah4d FlUY9f2toI9JLna/vobX2EL7ZaLGa+lEMx6W1cazj0D1Dvy6t1VC6LIYUFqvDLS6WG txAgPgWII9PBCIbRFYVpcc88ukFCt68IfEj2p6Hl+OX76XR9DW1u5/d8y1m2/w2Fpx +NAWWEAgsYdePFgoodi869gxl/ZWbSl2nqpJpqAao0NdgEREhXPA0yV+ADqnVR6eRr dhIIEI73to3GspKChq3NFwcnbDOYb8g4/FuU2n4GZV1ythCGbelKO5rKijOyGN96V1 nfDSNYTIt/0nrRXEzXh6VI7tY53teyrWH4AxSj6hMfXng1iF5AOd17ciB0lgasut+L jIg7Q9l0XRCeSQhAogpFhdiaqZLkxiZW/x7QQajYeLtbewacQO4XU/NUCAtvnOLrWM JdOZ5ClavcW0peuJW05e1ZOQ= Date: Mon, 5 Feb 2024 16:00:12 +0100 From: Tomas Volf <~@wolfsden.cz> To: Leo Famulari Cc: Steve George , guix-devel@gnu.org Subject: Re: Guix Days: Patch flow discussion Message-ID: Mail-Followup-To: Leo Famulari , Steve George , guix-devel@gnu.org References: <10c82db7-6fc6-4fa0-8213-e207fa54db58@futurile.net> <646ed226-7002-49b5-84c9-4f4be2425636@app.fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tOPXjvmEXYEvlMrp" Content-Disposition: inline In-Reply-To: <646ed226-7002-49b5-84c9-4f4be2425636@app.fastmail.com> Received-SPF: pass client-ip=37.205.8.62; envelope-from=~@wolfsden.cz; helo=wolfsden.cz X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -9.00 X-Spam-Score: -9.00 X-Migadu-Queue-Id: 13D92200FD X-Migadu-Scanner: mx12.migadu.com X-TUID: jUaY9BH4nadK --tOPXjvmEXYEvlMrp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On 2024-02-05 09:07:05 -0500, Leo Famulari wrote: > However, I think the question assumes that all contributions should be accepted, and that the entire problem is that we are not accepting them efficiently enough. We should not unconsciously accept this assumption. > > Guix can reject contributions, either in a general way (we don't want that type of thing in Guix), or due to specific reasons (the code is not idiomatic, the contributor can't work effectively with the rest of the group, etc). And I believe that is fine and completely within the rights of the committers. However, in my experience contributing, the issue is not that people explicitly tell me to go away, but that the patches are just ignored. I would say that the outcome (for any specific patch) from the proposed "review session" can very well be patch just being closed, or tagged as "need-more-work" (or whatever tag is Guix using). In ideal world, there would always be *some* reaction from the project, even if that reaction would be "we do not want this change". Even if it would be just an auto-close (for the "contributor can't work effectively..." case). Or, to put it in a different way: The problem is not that too few patches get merged. The problem is that too few patches get reviewed. Have a nice day, Tomas Volf -- There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors. --tOPXjvmEXYEvlMrp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmXA9/wACgkQL7/ufbZ/ wake1A/9EWHN95jJwYpLEdOI6NAPceu94/0FSUf1XfQrVxVho9qW2JTSiU7QdMRa ScctVgZGOEyJB9n0YEreQM2aOky9dKm+jss4oEwcpJTezZnRknIZbIuSIXFRciw0 kXNyREO/U26jMnodPqcxG6si3LYKQHDuoqEJsR4ozbmgBSC3Lx+DqmRi+2blri9T KMBkEN3ivmi3UqQ/tJz2cWo3ETz6lK8OAF/0Ydi42/n+f8jSP21D4s9IL6in13+w 5IJHb5djVAHyR6PHhrS8WGid6qJ06cNACLeaH8aoEJg2iWSSMWxA8yJ1/d39wnnL bwckM30xyoXzfS6m8WVCv5xs9lGuRqCI2ld8V8bCMtNupbrwW713Fz0MmNhWVxUO LoKU0Fogpe+ah/NSk77aemY0O/jPLe736AwX6xuu/RzBKi0x7UwShMJMvQsRlHqF jENurx3mBT6iDqP4e8tc1WAt1L2bAaz2iy9uttDjPONbf6py6UrBOn0wH3+Tzsk7 OHPLZWT0PRqfPQHbBBwofM0rHGWw62N5RlEa+M7YWICs27L8zMhs/GMh32V98z8x AtkxzRMNW9X1R2gEiG2eg0mx/rUl0mBnrk3mkxObsvfnH4LxGJ4llvbscrKC3nFx YQ5AvA6shDvB5jxUIFSgbYKv426T1A0OfE6QWB1yfPrN17aZAi8= =QiDt -----END PGP SIGNATURE----- --tOPXjvmEXYEvlMrp--