From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id +Ap0M7llpmXYUwEAe85BDQ:P1 (envelope-from ) for ; Tue, 16 Jan 2024 12:17:14 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id +Ap0M7llpmXYUwEAe85BDQ (envelope-from ) for ; Tue, 16 Jan 2024 12:17:13 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=wolfsden.cz header.s=mail header.b="OM/VLv2n"; dkim=pass header.d=wolfsden.cz header.s=mail header.b=dw1DfptE; dmarc=pass (policy=none) header.from=wolfsden.cz; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1705403833; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=yK4u/+ajP2gpnS7U6btpuPm84dHNtRsIA+Z0JNIFLuM=; b=U14lppG2VYgTugaWwFhn1FUJKoXEug2fNO7NH/b6XWsbmYFBXxmO2tLLOlAL5EoCr73Zqf 3/cXiWc/e2DH2UIBCwosMcRq1RmlVgfYoWWxDNWeWll3Q/90u6DJImUrm6ByZRkEh0exrz cyGflHyJKxK9urY0fiGhU/beEiOngjMvucsAts/k+qMdeBVvJPYJcU6yQZ/+LVY+KazF8w Or9tEUug1mFWVr0tex14ybKG1yTEDIvFTX2NE/N4eDoxfyu+ePCRcDHNCjPMpHwz1+b6zs UD/xu7i6fpes/rBgqlHdPVYtspNIWsIx/oB7fvavxdGX3dgeOkQE/5puGN9l8w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1705403833; a=rsa-sha256; cv=none; b=MaD83GAjNoN7Cwyv0gfGj1/VdHxYmNUD7JICL47TkuEm0a3T+IbK2KSuXqhmUxHQbbJK5G HdrnsntNnQypG3f1MbeOVFJrMBWYouV5uXYNy09BYJ9Gj4xp18LN658Uy8EyAd9mX7Ptki dNTABaTC9aQXxX2WsGTSTw6TubfJeFg9AdsukNp3b8Pk7IwSYuYXBH15CYZ1uon3GPam7C F/qTFRKaOGnADyJ90WnhAsffbfkTCJyw+p+kES5IGyoO9qGq5dDg9qjPVLPSupFLmQotoM 74OLVcjQ5V5Tlcw1dIt1lGo/yf+SnfTeQ576RzGFS2Ya8WUIjIHkVQuX3CNIUg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=wolfsden.cz header.s=mail header.b="OM/VLv2n"; dkim=pass header.d=wolfsden.cz header.s=mail header.b=dw1DfptE; dmarc=pass (policy=none) header.from=wolfsden.cz; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4BEC620E6F for ; Tue, 16 Jan 2024 12:17:13 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rPhQh-0005ee-Mo; Tue, 16 Jan 2024 06:16:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1rPhQb-0005eG-Pe for guix-devel@gnu.org; Tue, 16 Jan 2024 06:16:21 -0500 Received: from wolfsden.cz ([37.205.8.62]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1rPhQY-0003ng-53 for guix-devel@gnu.org; Tue, 16 Jan 2024 06:16:21 -0500 Received: by wolfsden.cz (Postfix, from userid 104) id 8CA65255DCC; Tue, 16 Jan 2024 11:16:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1705403771; bh=qqlUn7vry2YLsulCIUvNQPrcZTE5t1z5FCSp75hPBdg=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=OM/VLv2nRvw6SH+V9RF4Avnm9zU/O3UEjasZYuSe7j8/oZ4zKt2G+DcpRDVYc/zLC M2Z3vPDSQWlLx9074rn2biqfvsraP9aMxcv7MiOMmn9Gzl4wBwlC+cYs0LlPTFYrsm 6dIHiCz4fK+pSe7+GGW2RYE83tJO8pTbbtDw/uwN9zZLpg1Vj2al2VHXfboq6S6yAt X+p8yey3ME4/GzS6vWaq7PaewHndUIusdOXpjK0V6iG3D4FSPgxiH7B4NBxarES9zV ryn6s8GGBEGd83KtmspPFxel9tg32ogzm7hXmVDQ2PDOAalkVNyU3Xcs0mdUqLd5Fb jCgX/egvToKZGw+XG3/b3jI44jqPSfLfU9oIGrLBsx+/E1XbSc2Krpu/QvImUvP4RJ 1l993VgW317LPrdZrZvIkQe0zKBa34HmNbCEX8gQ7waE0CucDyrM/K9DCcsyANIF+O IlizRBAjRxbvcra+gKulio0OZ43cZ9POVGXFLGZikUN9ZCT1Ad8VfpNy7wMIN3w2qf 5DbRzXwudce77CfVPUGuXWn97wilCvw9lrz6GpM9SDO59CPoWbOhmwBtVc6r8ApCbu Y6ndBDCNC/BwUdUOIIVY+r26ZZ5OqrfUpHOMLM0eOw0uWNKms3RLum41MRUu2NWkb4 JwUwRnFISNAJcDM5N3Jf05GY= Received: from localhost (unknown [81.17.16.72]) by wolfsden.cz (Postfix) with ESMTPSA id 6A997253045; Tue, 16 Jan 2024 11:16:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1705403770; bh=qqlUn7vry2YLsulCIUvNQPrcZTE5t1z5FCSp75hPBdg=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=dw1DfptEIikYyYjE+/bWaaHPg1A1tggAZKiImMIDakH6LLa/UiKW1EwgaccK1fwEI I74YfdtlcsRwR1cwB3rq1f0jbWJHqlE/m5w4QxE7l6GW3bjgFcZ4lGyo9Z0mUiiM1e O+W2iLJN3Jo2CN3x/szxWVCtTG1NaoGxB0k6IjLYwDnWrSHRwhyFpFggI8ZGLWvgqf 8np3T/sDs7wfijBH6KEoIHQYWHMdc6XAB01SVGPGgt30Sy0em1mYQDvfRNQqLLN2P7 1OaymNqMRMVd2aiQDpl68EW7jmTYmPVQHi58YDI9osFMpjh+d99X2zVqzZolOt1Aux NzdgyIHpOA46ELgON+EaHb9OjTwK50DNAXmTVd6JJwc8d3bnOgRQL5Su4p30Igz5Ps YLKKNNg4H8zQFvLSIi6qhj4WgtfpuXPyYuPdE+5XGQKkkwXPeoDn9UlLLK98SoVtl6 KO2FZm0VBzAfiCUzVBPTneDN0Qtatq6zcetk7hW6W0A5TnSujHJuUybcKIYjRd2gcJ WL1j9MPoDA/c4R2QDtmJMmaM6ylbBcNGJf9/D10i2ESjzzWOXqNobC6kEV9Y3KmmdO +Y0FtDTxdQQbupj5spDaZW7Oz/eVioFhEhSahcb3y14WjsHB0JiXuegIkSlVtelZk7 XtNFB3ruKHC6u7DC99q1jedo= Date: Tue, 16 Jan 2024 12:16:08 +0100 From: Tomas Volf <~@wolfsden.cz> To: Troy Figiel Cc: guix-devel@gnu.org Subject: Re: Golang check phase skipping some tests? Message-ID: Mail-Followup-To: Troy Figiel , guix-devel@gnu.org References: <65b75d58-e27b-4d02-80be-d87b86bf0342@troyfigiel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5KW/Zqb0DJL7rdYg" Content-Disposition: inline In-Reply-To: <65b75d58-e27b-4d02-80be-d87b86bf0342@troyfigiel.com> Received-SPF: pass client-ip=37.205.8.62; envelope-from=~@wolfsden.cz; helo=wolfsden.cz X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -10.88 X-Spam-Score: -10.88 X-Migadu-Queue-Id: 4BEC620E6F X-TUID: 3EIm7G6U6CAb --5KW/Zqb0DJL7rdYg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2024-01-14 22:12:38 +0100, Troy Figiel wrote: > Hi everyone, >=20 > When looking into the Go build system, I noticed the default check phase > runs (invoke "go" "test" import-path), which only runs the tests in the > root directory of the source. Running the tests in all subdirectories > would require something like this instead: >=20 > --8<---------------cut here---------------start------------->8--- > (define* (check #:key tests? import-path #:allow-other-keys) > "Run the tests for the package named by IMPORT-PATH." > (when tests? > (invoke "go" "test" (string-append import-path "/..."))) > #t) > --8<---------------cut here---------------end--------------->8--- >=20 > For example, if the -v flag is added (which might be a better default?) > to the check phase of go-github-stretchr-testify, it can be seen that > only `TestImports' runs, none of the tests in assert, http, etc. > However, the source code in these subdirectories is still recursively > copied to out during the install phase. >=20 > Is this desired behaviour? I assumed it isn't, because it looks like we > are skipping a lot of tests during the check phase. However, I might > also simply be overlooking something here as I am new to packaging > Golang with Guix. I tend to agree (on both accounts). I am not aware of anything Guix specif= ic here that would prevent it, but maybe someone from golang team will chime i= n. Have a nice day, Tomas Volf --=20 There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors. --5KW/Zqb0DJL7rdYg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmWmZXgACgkQL7/ufbZ/ wamaFhAAoEXA7mdg8r6Guvc5geZlE1qyOxSbhE8uF0c3DnYjRyWGDlBPfX4SRYex QqgMLG2kILJiHgAt1Ev2YCB9eytJQ6Z/8grPNNitPIgwxkSxByU7iLUIiQj/xy3q 0HMK66UZbwqLK8ePpAhjlW7LA4jSZNix/xnoxQCpf9UdvPAMbQD/z71ORCt029/q mc2UBsfJgkSUz7Y1fAJh6co191uNJHNqTgSr+lV1L74yYkOfKk6fetVZR0KJA6vG H3p5ZmdVO5zpBbfMZQc39Tf1u30aDwlR4aF9prTbcdY+xG503FGw6RnsbPctHVvG nwjnM1nYl05NAw+VSG638vS9Rc4kGmL1NC3VfWqdLAHFvc93P0msHaOYjcf7q9O8 qSiSkVYnm2fe/FuqMxu0+Ogp+JNWYeWcDAHEdS3Ryk2vDYG3+W3lCZPR883Us5Kv XYzxX5seuPikgynEB7XD5sHtpEy95FxUefjnedaoT8opC1coPrH/gZJgwCIlfa3F 7rNlkn4DZTaxgg7efvbK5fZfXGI16v0ieVOWCLRI96nOqFpeSXuv2qQPrZNu0kh6 jqt9au9a+B2bdvb4IUOM89CrMjR9y3cyknSyNp7Mw3LaPeyg70/ojlmKAbx3UwMK nJWUOFBCe6ESN8CvMqHx46IoXlnjvK1Ohax9zA+JVsft234+FFE= =vc4A -----END PGP SIGNATURE----- --5KW/Zqb0DJL7rdYg--