From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id WKgfK+/wpGWIWQAAqHPOHw:P1 (envelope-from ) for ; Mon, 15 Jan 2024 09:46:39 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id WKgfK+/wpGWIWQAAqHPOHw (envelope-from ) for ; Mon, 15 Jan 2024 09:46:39 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=a9OPGeEG; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1705308399; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=YfunnLufWhU38S4OPzMstudC2kGzlVmhtS+6j1zSDVk=; b=MUhFfQJSF29swJFBAsuebACjw8RR41gY4WpNHtWpqiqrwAJ1yoT12/rohHoG740R7J7Ks1 XNfdh0+jsxKeiBNdq8JjP4QdiiCI/kd/41BGX68jtBW159ys3YxtGgxM29KLboaSclRil0 CpMKl+dH5xEtWFzWqkuC1r2c5LfLVPlMu4K6MbGszfG+ASUEdDqxtLOhNQ0EQrAwxmwrwF WgKQYBhKfj88p/ajVnpnoD2Uob5uB1fjmyWrbOxYlhT7a/XAp1FIRYJwKaDWfwKREwYH9n lE0GgQrwicXrxPrZ0qKcCv0efeu8kW+TD7qmPL55xSdbGMMkgBxEbIpHSnjzLQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=a9OPGeEG; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1705308399; a=rsa-sha256; cv=none; b=mL5oMwSrydBKsdFHBmyndy/N5bhaah0Lc+a9vJ1admI6At3WPPaeG84AHerXbt8ubY1+R8 O6l4Nat5Qt8eREKT/+84MH7wgKJ/R/nHKFj6azKxfCeCD36C907t36SpTh46MBvYfQCRkO gsixqy0gPqjZR7w06C6KtzKPZyKOcmZCDOiDoqe2jlj+v65mkqv9oyI5wfPENXTlHhi/h3 gBo2BXwDfYuO8y12ac50zow8VgOR8Gh4lIYaGcR2y1ZMn00onPJ560bqNmN2bSTvd0nZ/9 Wf5WEDVDeMBA7WtMlbmp54y1hFySZy4KYx7qop8CES/3JoWp8rS0qFIeyCALtA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 44458227A1 for ; Mon, 15 Jan 2024 09:46:39 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rPIbb-0007n9-Fc; Mon, 15 Jan 2024 03:46:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rPIbZ-0007mt-KK for guix-devel@gnu.org; Mon, 15 Jan 2024 03:46:01 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rPIbX-0006Ht-J7 for guix-devel@gnu.org; Mon, 15 Jan 2024 03:46:01 -0500 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-40e779f0273so6929675e9.2 for ; Mon, 15 Jan 2024 00:45:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705308358; x=1705913158; darn=gnu.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=YfunnLufWhU38S4OPzMstudC2kGzlVmhtS+6j1zSDVk=; b=a9OPGeEGBYY81fe3zp5PUilHYFPDyMJA1+vfCrn1pGEbFmZ2WNsG/CeqfcQjamgmc7 RkS/WgCyQO1ZaTjo97NcYG0BhQCXELW5ktPpUqHrw/EuUUT4fqovJ1k15oD22nhpoLNd Dq4Pi5dX4vDcg3yPbqflSl/Pkpe3X3GGylL4/b8+9Q9fFCVrPy1XWliHk8hoJEOs+TbH 2Uuek1JrtLT5I1JeFcRAqP9ntjyFJjkRAHaNde3HzO4a0xwsAhDRmG4gWrEMwjPSk4SQ wQFa9nIGMMJYX778WOkfZGcW/aWZ+LBG4QUqVAm+X1Iv4R8iF0oIc3Fiwgd8TU5cs/cC 8pSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705308358; x=1705913158; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YfunnLufWhU38S4OPzMstudC2kGzlVmhtS+6j1zSDVk=; b=PvuKhBZUwa9a5G4uK4TmnfI/UuDjzDkk/47eBmb+ebJkwyiNcPGUfseNNobocQmOTg 7BmtWpdCtSmXnUtWoq7yaED9Ad6W9DXAU33StVOgFoba89xFvW0Qp3lD6oSCUsxxR6tJ tRXOZyzY2CNdSgG6Z8uu8a8LPEqV741rhE38HbgnuoH+BgvU4tT6psBqtivH2CInJGrj CDKxH9hDGHcD80vpKZI1x5S9jksjFLQ3NzRz6nxgwG+QIcQMWx2CVqxgunXJPHtjWVBj kuBLCmek5DCWRAWV3Qv8BbTh24ToJmRVoJrEeCspBdGgboLoyp5/WS/KrsM2ZF32n1dI PjUA== X-Gm-Message-State: AOJu0YzJvYtnIV4NUiZ21JSjbwrrMOhQnqNipVxiOHTRNq0NgYtSpl/p ItdYfNmJ9fsc57VCj/F75ag= X-Google-Smtp-Source: AGHT+IHKMcys4Mj7e9Y6u7jZxSZ0ktUhX4Ttl9muIcmhNVFp2bn0kqmOxkldmepA285gmBh9pqZ3jw== X-Received: by 2002:a05:600c:2492:b0:40e:67e9:ac6 with SMTP id 18-20020a05600c249200b0040e67e90ac6mr2057656wms.104.1705308358006; Mon, 15 Jan 2024 00:45:58 -0800 (PST) Received: from localhost ([141.226.15.142]) by smtp.gmail.com with ESMTPSA id g14-20020a05600c310e00b0040e398f8cafsm15094854wmo.31.2024.01.15.00.45.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 00:45:57 -0800 (PST) Date: Mon, 15 Jan 2024 10:45:53 +0200 From: Efraim Flashner To: =?utf-8?Q?Cl=C3=A9ment?= Lassieur Cc: Sharlatan Hellseher , guix-devel@gnu.org Subject: Re: Commit Access: Sharlatan Hellseher Message-ID: Mail-Followup-To: =?utf-8?Q?Cl=C3=A9ment?= Lassieur , Sharlatan Hellseher , guix-devel@gnu.org References: <87zfxbtzj3.fsf@gmail.com> <87a5pabjz4.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Dob3I32k7dtMmMjq" Content-Disposition: inline In-Reply-To: <87a5pabjz4.fsf@lassieur.org> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=efraim.flashner@gmail.com; helo=mail-wm1-x335.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -4.29 X-Spam-Score: -4.29 X-Migadu-Queue-Id: 44458227A1 X-Migadu-Scanner: mx12.migadu.com X-TUID: I9R8nUCGwrNb --Dob3I32k7dtMmMjq Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 12, 2024 at 05:21:51PM +0100, Cl=C3=A9ment Lassieur wrote: > On Thu, Jan 11 2024, Sharlatan Hellseher wrote: >=20 > > Hi Guix! > > > > I am happy to have been granted commit access and I am ready to help > > review pending issues and prepare queued packages for GNU packages in > > astronomy. I would like to concentrate on the packages covered by the > > Go, Lisp, Python, and Science teams. > > > > I would like to thank the Guix team for allowing me to become a > > committer member. I am looking forward to continuing our collaboration. > > > > If anyone has a good patch review workflow using Emacs, Gnus, and Magit, > > I would appreciate it ;-) >=20 > Hey, welcome. >=20 > I use this Emacs code to apply patches, with emacs-debbugs and Gnus. >=20 > --8<---------------cut here---------------start------------->8--- > (defun my-apply-patch-or-abort () > (interactive) > (my-apply-patch-internal "git am || git am --abort")) >=20 > (defun my-apply-patch () > (interactive) > (my-apply-patch-internal "git am --reject")) >=20 > (defun my-apply-patch-or-abort-attachment (n) > (interactive "P") > (my-apply-patch-attachment-internal "git am || git am --abort" n)) >=20 > (defun my-apply-patch-attachment (n) > (interactive "P") > (my-apply-patch-attachment-internal "git am --reject" n)) >=20 > (defun my-apply-patch-attachment-internal (cmd n) > "C-u M-x my-apply-..." > (let ((git-dir "~/src/guix")) > (save-window-excursion > (gnus-article-part-wrapper > n > (lambda (handle) > (let ((default-directory git-dir)) > (mm-pipe-part handle cmd))))))) >=20 > (defun my-apply-patch-internal (cmd) > "Works with a selection of articles." > (let ((git-dir "~/src/guix") > (articles (gnus-summary-work-articles nil))) > (save-window-excursion > (while articles > (gnus-summary-goto-subject (pop articles)) > (with-current-buffer gnus-summary-buffer > (let ((default-directory git-dir)) > (gnus-summary-save-in-pipe cmd)) > (gnus-article-hide-headers)))))) > --8<---------------cut here---------------end--------------->8--- >=20 > Just my 2 cents, I imagine every person here has their own workflow. I'm going to suggest 'git am -3' that someone else here suggested to me. When a patch fails to apply cleanly git will try harder and leave the failed-to-apply bits inside the code, making it easier to clean-up the patch than to manually apply it. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --Dob3I32k7dtMmMjq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmWk8L0ACgkQQarn3Mo9 g1G9bA//b+8OuqFv1cq+JOkZPglWG4/7GZyRv5xTaNGzlRyuoYzXpakTaPt+LPAD Q5W1t1Ip6fs1BsDwHYQMUXAJEHTrldzI2DggU7MKkdnlqs1W09MSXlVLdqOg90jf PMqOADnL9G4OWQE1/zWQhi09Lvb18S8CWvuN7Vk0nqNYimj2c2HxeHWoVA/7fIDx uG6TJzNiOw/6nWGoozDO9VlHZaIvEIGoFz15zg06OYVa8I7pnpo99NXlN4djQcM9 T9wOTxTRkH0FZR9kJxp+WyAS3plqS/jz0CY/WkJ1Y6gBqlPhx6sRQ955N3VodeyC oX0zMhg8w5NaEnxaGaTPSe2geBxI8HkLmlOFwpEUjkxzfsEeL4qfdQy26eXJ9r3l lJ94A2SSkVKLB1474+E/OKmlOT+nrNfnMGhBlCwHIwyOn+0OS9E0s/0yvy5jV2sc lA27ShP3SLCwAiwQYnWt+uAc5bXqavhO43/DYNvYHSlLg2nBTR2Q+zfYdU5oqN8m aG8vW6Maq1N3jBsLegmeJH0jNwdaQuBlzOJVd9StsI5TZVgnMwM/v1ebKBlI/uQN UTJRbdf3KyNSgjGtr3YRuFuwrpXPAkU0dQ9CyQDc4uauk8wp+vip5vxEEr2jdGiB hZZpaZETfoQanMBx5/GdZllEPsBxrPSKp6XeUSFO3qNm4X+7KzU= =4W+s -----END PGP SIGNATURE----- --Dob3I32k7dtMmMjq--