From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id YNlAHHF2mWV9ZgAAkFu2QA (envelope-from ) for ; Sat, 06 Jan 2024 16:49:05 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id 2CNtGXF2mWWDzAAA62LTzQ (envelope-from ) for ; Sat, 06 Jan 2024 16:49:05 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=wolfsden.cz header.s=mail header.b=RP4K9HZn; dkim=pass header.d=wolfsden.cz header.s=mail header.b="v0n/bxIJ"; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=wolfsden.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1704556145; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=IlkDzc/ZhwXkTMPXNTiw9QbQT6DuOD15+lQfz02/Yvc=; b=e5w7tlkENB3T5FLlRe81LuPCA76ptVtB0K6HuOKjlEqHag+Ft2hMxY8advfxnWffe0EueV pfUO+Tr4m1rFl09NktWg6TZYSzgMXIWKu3b6gAaoOjctZuOe/8FHBYFzHno5bGJtiM6x+l DzrkB6A1HQ/Lo+YoXuGG6NZYOvXDhHA0zgFAsjG+fnCDYdmMrn/l2xlLdGh4VjC2HrcaHf g6TTq9UVxLM0spR4/j5uYhFAgIbUjPHFxa2KGU2AEyqEvKgSvhUNMEKsJBW2SGN6Kf3O4u QSs4SjynITEOMszbduODL443WeevfsxtTzbQYPdSBiCMDIWbR5CmQlJv2PjlrQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1704556145; a=rsa-sha256; cv=none; b=bIAVHL1JoTf5dDEMieZU8eJNvzy3Y91kJ5efpAy/7pckqcl0NkgI0bkyl0C4+cM553GXt4 /2ZxbFW82aEr9CfsvEYbANBSbeIUqVHuK5Hxtwv3ypaAwAXpFYh1SYp8wo3wmxLs2eLYTw eqDMYiG8P7nJLMT37NGnyIUADqJwgcg7idQWx/YfH1X+BUB+nCEP9WBjKrqHNfqaR1WM/w ZMkYccjYfgB5GzHH1AHiNmqJSPs8PTDTPI6vUTYf3MgTXBIowly/BwDL9y0PJAe6/sbPJ3 PJIylHchgLg14AQrFLhZS4uP6wrGgZwpX+oJ0twcgYp5LB1iBi8/MjKHXnuzmg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=wolfsden.cz header.s=mail header.b=RP4K9HZn; dkim=pass header.d=wolfsden.cz header.s=mail header.b="v0n/bxIJ"; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=wolfsden.cz Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4B72131A91 for ; Sat, 6 Jan 2024 16:49:05 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rM8uN-0002ku-Oy; Sat, 06 Jan 2024 10:48:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1rM8uM-0002ke-13 for guix-devel@gnu.org; Sat, 06 Jan 2024 10:48:22 -0500 Received: from wolfsden.cz ([37.205.8.62]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1rM8uJ-00027L-U8 for guix-devel@gnu.org; Sat, 06 Jan 2024 10:48:21 -0500 Received: by wolfsden.cz (Postfix, from userid 104) id 52359244CFB; Sat, 6 Jan 2024 15:48:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1704556096; bh=shn/egN5057jl+iLJ8CMRrU4rahe8peAZzfYXtC6Fvw=; h=Date:From:To:Subject; b=RP4K9HZnb9lUkFCRJ6qGQviGdMVXWpMY1W9RKtIjzy+3F/Kaq+PqV6xyrk0wjzNws fqouYV2Bvvreh+o3mPgy7Lke10Ebf5CAQBiZPT1QOBSf61kVjMYv59b9Pio86SJyeH p1sNVs/nKEujm6Vx64nFcEbl6jf8oQBsF+SgO4DM43w2i7anJAXNCzESrUi1LOa4n6 z5jfY+GmcichJxYQr1jtLOk1d4WBijpADVuCkpQ695DddOcTHEpfHPvKKuDM82Yfqw gmVuyHrtqkaPRAh6GKgvQ8khT7A66C5bQs+rHt/5UlMlx8Zr0QkAkoUkcNOqNJfcNy HfPUa4JKPn4NygpRpDTycnqb8c2/vwEi5HIz+lyORwWuNJ6IKvbsyKdCj0U1N4tQCH j2s1emyp7b0ZPW4BFVBCwImeC8lTM3i8ebU6ZbJ5/QCE9PLzoYjopOuOTRnv6BKFzP mEWcw7aoBnUfWTkOJ8Yjm0rZDBD2W6xdFURBUAlJR3T3/TSJiJsk+ToK7OWvCXSs5P /Mhp0sgtHRZgIsuBkNgnjC6nQGkKu4LLj/W2jBlhsm1xGQHFcCOkJD4dCIcruWUNoV uQTCE7ObsCMNi/sXZ5rLmdn661G/6fnKps2b9ykAICYlJ+os6kKnDyX43cPd2CwYx9 S4H2HkQiqXkySVka0yh/6c30= Received: from localhost (unknown [193.32.127.155]) by wolfsden.cz (Postfix) with ESMTPSA id 6B7F52448D9 for ; Sat, 6 Jan 2024 15:48:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1704556095; bh=shn/egN5057jl+iLJ8CMRrU4rahe8peAZzfYXtC6Fvw=; h=Date:From:To:Subject; b=v0n/bxIJTqZn3BvdukoEw21W0M/hWVuZ4xEZ6+LKg463N3+RgijWvVWHFpXQn8PKC Nb6ZXytJbzw5qwaj4JjQrJQP3IyaNnGqY8ckL1Ed/xpt5woGCZKoIaSVdhivNLJ0+k H2qdOB7807+M+gcl0DmxglBMkwv2cbt5JMMhACDoPb5NqkP/2pgqZxI+d7zsiUhWd1 Qd0noc9rpFDuRLqrobLyZZF893MUV21il+PwWAU73V0FdSzsSK2GEb4kMRX8/hvXGz bsvjXXbvreo6P2VKxRWerD60gRXm5jGwnJhTwkmJ5MU473JcVoOnQ5TrjhM/18zG8X gNt8RQG+OK0BL+PJAodSZxnbiJLtzCH5hkKNJ9a/NDq4GmSZak/zxq1flbYrRfHfAM zbZBnh7EEZVGbcD2uFneDVHZaWZEM803bn5uQInf/oXl244n0d40Q79gv4bBnJKjzy LvPTnVcLhqa2lyUylfWrfRSPbAFm3PZgYzgqCOGDP3TdNAjA74aifGvpvkOGus7GQD /rA7/aF1nn2IwjfKQiTnZO6wKNyS0kmKion1pu1YenTVzbxIQ9bBFOlzHjIh7N4mAU zS7MC6MNpsW07x3k+e2L+9lxQtCndBccXuLELbmNKH770EpkCvpwJZMHDuLG8cfSew Na9/hzKphaUxo+74hRAJu+n8= Date: Sat, 6 Jan 2024 16:48:14 +0100 From: Tomas Volf <~@wolfsden.cz> To: guix-devel@gnu.org Subject: How/where/when to ask for a patch review? Message-ID: Mail-Followup-To: guix-devel@gnu.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="so9+8Qu7by2OcGtv" Content-Disposition: inline Received-SPF: pass client-ip=37.205.8.62; envelope-from=~@wolfsden.cz; helo=wolfsden.cz X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.47 X-Spam-Score: -7.47 X-Migadu-Queue-Id: 4B72131A91 X-Migadu-Scanner: mx12.migadu.com X-TUID: C49nxKNZiQwZ --so9+8Qu7by2OcGtv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hello Guix, I would like to inquire what is the proper channel to ask for a patch review and how long should one wait before doing so. Bit of backstory: At the beginning of the August 2023 I sent a patch to the mailing list. However it had no interaction at all (well, one user tried it and deemed it working and useful). So I am unsure what to do about it and how to push it forward. What I tried so far: 1) Asking on the IRC (2x). Once I even got a review, but from a non-committer. 2) Sending email directly to the main author of the edited source file. No response. Technically I even mentioned it to the main author directly in person, but it was at a conference, so I can hardly blame them for it just slipping by. :) Just to be completely clear, I do not feel entitled to a review. If there is no interest (from Guix), that is fine and within your rights. But I realized there is a mistake in the patch (code is fine, commit message is off), and before I spent more time on it, I would like to know if it even makes sense to send v2. I assume it will just sit in the same void, therefore this inquiry. Thank you and have a nice 2024, Tomas Volf PS: This patch being ignored was the last push I needed to start my personal fork, so technically I should be grateful I guess, but still, I would like to diverge as little as possible. -- There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors. --so9+8Qu7by2OcGtv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmWZdj4ACgkQL7/ufbZ/ wamzYhAAqCGu6mgV01d+tG/oKIdqI2u0xQutnZaP4GtYhWu7dcKTKYVqoHjGyS5j Ww4QJ8K8zi2uv2uF5+NQ0JZgldaG86PCeTFosFbRn9K/NFm7KaZR7/wOMBe/Ftfp zb04Yf41SK85FiE3u/5xjY6b6//5F9rCvp5PZWVC6LC2ylDwO3soEhdyFh6QgAai coxqHYaP3Fx+WAHrXQqxvYu/Ou4E8Bu0CxKF0vqAW5xF0uv+fdzg/U02HSluNitn 1ZRetNydlw/FeE0R2EOcjXER/FO97MWg6Kza/2irIjRQHlmu/8NdMJxg8s4Z+tfs 2mRBwFgM911z31KmHbH5SYrq6vAchBxszjuC4rNyKKgXYs/Px3gdy8MCgZApdTkV qcsH6KaZUhj6l7Wtj5wOOEtZY6gLm0pvEt7MgtyFLB0NjSoFpYqSLPRiJncqodmb 2jZI/DftNTpdn2SnO3WcdWwjlCbl4gX6+W2daC1gg8xjwCXQjxp22r4GTHUlb4Vi gH9tBLUSVjtX7KrWhw7DLpW4L/45gGyyK6HFbujPNW9JvhYv65abSGg7C9M7DAp4 6Zh9U9WNfzPUAoqBUhVKIGy3287LTZ02plD1VlriNRB9Q/Chol9Frxh61BfC05oH 8xhQ9e7q9jqYjbSZyq4jNTeF7OSSLzTXgYmkhwCBjC/nnRVph84= =rN65 -----END PGP SIGNATURE----- --so9+8Qu7by2OcGtv--