From: Tomas Volf <~@wolfsden.cz>
To: guix-devel@gnu.org
Subject: How/where/when to ask for a patch review?
Date: Sat, 6 Jan 2024 16:48:14 +0100 [thread overview]
Message-ID: <ZZl2PvBe-fTnt_kj@ws> (raw)
[-- Attachment #1: Type: text/plain, Size: 1478 bytes --]
Hello Guix,
I would like to inquire what is the proper channel to ask for a patch review and
how long should one wait before doing so. Bit of backstory:
At the beginning of the August 2023 I sent a patch to the mailing list. However
it had no interaction at all (well, one user tried it and deemed it working and
useful). So I am unsure what to do about it and how to push it forward.
What I tried so far:
1) Asking on the IRC (2x). Once I even got a review, but from a non-committer.
2) Sending email directly to the main author of the edited source file. No
response.
Technically I even mentioned it to the main author directly in person, but it
was at a conference, so I can hardly blame them for it just slipping by. :)
Just to be completely clear, I do not feel entitled to a review. If there is no
interest (from Guix), that is fine and within your rights.
But I realized there is a mistake in the patch (code is fine, commit message is
off), and before I spent more time on it, I would like to know if it even makes
sense to send v2. I assume it will just sit in the same void, therefore this
inquiry.
Thank you and have a nice 2024,
Tomas Volf
PS: This patch being ignored was the last push I needed to start my personal
fork, so technically I should be grateful I guess, but still, I would like
to diverge as little as possible.
--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next reply other threads:[~2024-01-06 15:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-06 15:48 Tomas Volf [this message]
2024-01-07 3:22 ` How/where/when to ask for a patch review? Felix Lechner via Development of GNU Guix and the GNU System distribution.
2024-01-07 9:41 ` Nicolas Goaziou via Development of GNU Guix and the GNU System distribution.
2024-01-09 23:33 ` Ludovic Courtès
2024-01-10 14:17 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2024-01-10 16:59 ` Tomas Volf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZl2PvBe-fTnt_kj@ws \
--to=~@wolfsden.cz \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).