From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:5f26::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 0HZNOVzNnmXqfAEAkFu2QA (envelope-from ) for ; Wed, 10 Jan 2024 18:01:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id IC9fM1zNnmWEXwAAqHPOHw (envelope-from ) for ; Wed, 10 Jan 2024 18:01:16 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=wolfsden.cz header.s=mail header.b=kT6qlfg+; dkim=pass header.d=wolfsden.cz header.s=mail header.b=kT6qlfg+; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=wolfsden.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1704906076; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Eoz1ry/WnZxo3jEisUWI6VIavMSTrPZWsW2ghn7bl6M=; b=IV3IQNUQUJoUeU/JVn+XBlXFeGr9r44UjGlPvrBN29NWDO/SYJxpslyAhpZLPuS4iREEgZ 6/Aop9SDYGO7SZV1ctj8SCU9JxujzvcK9IGNksJy9OpNauZ4zkp9BggSeNzQCKl+Dpeybt C4ONhDgfo1alV671iXg39R3vC4EIZv4NMRUYDswCtFndFYYIVWdEHSfKyuw5hC7iqIlQno hhhkZYWIuk1WNf/m4F0fpXvqU5itrhY8Te57X/0HdlFhXIoP+BcCvzBvvKDWqZs/MhJZOy BQHAFSourNYXAfFhux2Go9wSMCZDV254hUfgS62BXpGwlm7jBwDYrLpzJCyKIg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1704906076; a=rsa-sha256; cv=none; b=py9JKiYAPByxVUCgWXdNj6HJxi9KxgpjLbVAFagPIsoVeO64YMcIAZhayn3BE2N4D8F23a h1f79u3i/9Yit9an7SkiSS61xEh1DOgZ+2K5e6vhDyT/WG87haQUln3TlGiMV3QNyD2n6Q 52I2JlE/87WqM/1oAV/klKD8bh3TUYR1lHqFpXUsJg6iPDEPQsQkyOSYHzPVn5Skzk/yMu vdbzaGSdPYXE+UpGcZcSMfDxq3Dq+yA3SQX4oOJ8n59I7st8QCKwYwegjxnsM306HeYbaA BnjJP5cUNOIpDf4fRyWS5FFwtBpzBGyy9gs6jatxhUs3tzcXzRlEqq3D2KM8rw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=wolfsden.cz header.s=mail header.b=kT6qlfg+; dkim=pass header.d=wolfsden.cz header.s=mail header.b=kT6qlfg+; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=wolfsden.cz Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A9D526B66C for ; Wed, 10 Jan 2024 18:01:16 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNbvp-0001Vf-71; Wed, 10 Jan 2024 11:59:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1rNbvn-0001VX-CG for guix-devel@gnu.org; Wed, 10 Jan 2024 11:59:55 -0500 Received: from wolfsden.cz ([37.205.8.62]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1rNbvi-0001kp-GN; Wed, 10 Jan 2024 11:59:55 -0500 Received: by wolfsden.cz (Postfix, from userid 104) id E12FA24E3C6; Wed, 10 Jan 2024 16:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1704905985; bh=lxmYZcgNefqBwKdtyNCYi63542pTwZeCFcicFZG7RSw=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=kT6qlfg+z2DxS+jxpD5pS9Sq2eDdWRg4ldYc+trzuUmZ2yc4AGc6sV59iCXmrO3cj Xfocd7O+QrhJ3njmAF6sOqts7W/sHvB+Zj2u0ibFFeHSNjAQi9T968TA/NhcvC5C4c 6y4/rIG8SbME4vBVas8kcuSAY7HBUKnnwt3t1OuslnqO5xapzvvkV/ZB9ekau91z8j I9LzjnCQP42iIkaSh2jsFq/CK5uHziz/PZ+xP+ZqwlWccSMFUKXCAl6jQ0yUb7qOo6 eMYirW0ML8olTijImq9ZFYdEoRW1mgVCkuBEORh7jajBUjo+/KkNEeqrjpuTxA10rw RzH8Io1SID6ojU8mXTGavR6kpsjZSpLXwJVWiYeAuZnOcfUnHzyQJ0AqWsq/58C55o mvmbUS+5m5euzpQ1Dix2z8otV5yR/fxz7dyEqC/pC0+aFtFJPHuu8ggb3KfGPg0QNs 5VYHtGkDZ/LU8mAfHsguELVSD/sp9PiN4kcDdsxr5yWtd+8WPlJAWEEpPXV2v9lVzz qgeVKJ6KoQuPHJbPnwTJInLZ/smNFD2FLLqZRd4xib2OlVlHe9i5OuCI9V36m7dQiw CC2bX5kxxXqmVriUes670txjQPwnKO4Wj5+mm7pD8/TlA/25laIPWwNXIBEr+qGPp4 TdJ2z6dFpsgcZW+9UN2EIQpE= Received: from localhost (unknown [193.32.127.158]) by wolfsden.cz (Postfix) with ESMTPSA id 48C0C24E637; Wed, 10 Jan 2024 16:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1704905985; bh=lxmYZcgNefqBwKdtyNCYi63542pTwZeCFcicFZG7RSw=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=kT6qlfg+z2DxS+jxpD5pS9Sq2eDdWRg4ldYc+trzuUmZ2yc4AGc6sV59iCXmrO3cj Xfocd7O+QrhJ3njmAF6sOqts7W/sHvB+Zj2u0ibFFeHSNjAQi9T968TA/NhcvC5C4c 6y4/rIG8SbME4vBVas8kcuSAY7HBUKnnwt3t1OuslnqO5xapzvvkV/ZB9ekau91z8j I9LzjnCQP42iIkaSh2jsFq/CK5uHziz/PZ+xP+ZqwlWccSMFUKXCAl6jQ0yUb7qOo6 eMYirW0ML8olTijImq9ZFYdEoRW1mgVCkuBEORh7jajBUjo+/KkNEeqrjpuTxA10rw RzH8Io1SID6ojU8mXTGavR6kpsjZSpLXwJVWiYeAuZnOcfUnHzyQJ0AqWsq/58C55o mvmbUS+5m5euzpQ1Dix2z8otV5yR/fxz7dyEqC/pC0+aFtFJPHuu8ggb3KfGPg0QNs 5VYHtGkDZ/LU8mAfHsguELVSD/sp9PiN4kcDdsxr5yWtd+8WPlJAWEEpPXV2v9lVzz qgeVKJ6KoQuPHJbPnwTJInLZ/smNFD2FLLqZRd4xib2OlVlHe9i5OuCI9V36m7dQiw CC2bX5kxxXqmVriUes670txjQPwnKO4Wj5+mm7pD8/TlA/25laIPWwNXIBEr+qGPp4 TdJ2z6dFpsgcZW+9UN2EIQpE= Date: Wed, 10 Jan 2024 17:59:44 +0100 From: Tomas Volf <~@wolfsden.cz> To: Ludovic =?iso-8859-1?Q?Court=E8s?= Cc: guix-devel@gnu.org Subject: Re: How/where/when to ask for a patch review? Message-ID: Mail-Followup-To: Ludovic =?iso-8859-1?Q?Court=E8s?= , guix-devel@gnu.org References: <87cyuaw094.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bmoCs0nQrPj4Ehwl" Content-Disposition: inline In-Reply-To: <87cyuaw094.fsf@gnu.org> Received-SPF: pass client-ip=37.205.8.62; envelope-from=~@wolfsden.cz; helo=wolfsden.cz X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: A9D526B66C X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -10.49 X-Spam-Score: -10.49 X-TUID: j5KCNFy263Lz --bmoCs0nQrPj4Ehwl Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2024-01-10 00:33:11 +0100, Ludovic Court=C3=A8s wrote: > Hi again Tomas, >=20 > Tomas Volf <~@wolfsden.cz> skribis: >=20 > > What I tried so far: > > > > 1) Asking on the IRC (2x). Once I even got a review, but from a non-co= mmitter. > > 2) Sending email directly to the main author of the edited source file.= No > > response. > > > > Technically I even mentioned it to the main author directly in person, = but it > > was at a conference, so I can hardly blame them for it just slipping by= =2E :) >=20 > Uh, I think I=E2=80=99m the guilty party, my sincere apologies! Do not worry about it! I will not pretend it is not a bit frustrating to h= ave patches just sit there, but I do realize how busy your are and much you do already. I do appreciate all the work you do on Guix and around it. It is unavoidable that some things just slip through. >=20 > I have to admit I have a hard time keeping up. I review tons of > patches, but I also like to do stuff by myself, which means I tend to > select =E2=80=9Ceasy=E2=80=9D patches. >=20 > As a project, the ratio of available reviewer time to incoming patches > remains chronically small. I feel like there are more people reviewing > and pushing patches these days, but there=E2=80=99s also more patches com= ing > in=E2=80=94a good problem to have, but certainly also a source of frustra= tion. I do not propose any magical solution, because I do not have one. :) Let's hope it keeps getting better. >=20 > The good news is that I=E2=80=99ve now reviewed > and it looks almost ready to me. So > perhaps you=E2=80=99ll have to ping me or some other committer one last t= ime, > but I encourage you to not give up, not so close to the finish line. Thank you very much for the review, I will send the next revision sometime = this week. Have a nice day, Tomas Volf --=20 There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors. --bmoCs0nQrPj4Ehwl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmWezQAACgkQL7/ufbZ/ wamMfQ/+Oa8Fx4AqnAAMZYOqjTwDTo5aIgAGtwUGI+NL/9Ayk2BgsxicvI0TF1Fu s7TgrWOEG53142FujKqfrFov3TTQACDg+5a8Rdefuu4oaE1onMvbVB5IAoMvpeH2 hmlkBRBX2gqkOl+nomCbBLNdGTgINUlGlxybBthDndcTVygzZI9CI7AyVv69+/Oe bKGLMhbyAuHKRXQMLO7Abl3xf27iWzj1qUHGPcrYPjTkhQHk0SqgZLKIMB4ZRZJZ lgHPp8zBz3pX4FWhoI8sFSJCXOVvo4G3ZoSh/IoIOssUy3CnOY7K1uFfDL37G92c //cJkaTieh2xglsCJ4jFH2WJh2Hz2VBYFtQXYNde6dEdaF1zdGLjydF9VSFqJDFN koxJ1RaI+YbD1uAzEGskdxbtcldkgQ+RAuTIZ4HyB6WHfaErATJMTXkKrhckgTUp 28CTP5B94HxFbs9SWPyMWxNYDlXEuV+TDTYLREWpnA9evZ6zEnTOr+hA71k4mNl4 A/9tWhZ14+Bpu9Ehfs4hufA42Amu54A9GB2YE45IGDirmhgJNJ1eK0/JFL3ccU/u AhB5sy0lis5KqwYnWABswFhMmyG/LSjyMwmzJx+z0yrwQ0Lfya3DrJclB1dzQv1A N5/U+J52IKg2ZyFtcd3WlPU1OFNrpNtZwgK3nwH1LEW/qQL6FqQ= =oKAa -----END PGP SIGNATURE----- --bmoCs0nQrPj4Ehwl--