From: Tomas Volf <~@wolfsden.cz>
To: Saku Laesvuori <saku@laesvuori.fi>
Cc: guix-devel@gnu.org
Subject: Re: Should commits rather be buildable or small
Date: Fri, 8 Dec 2023 12:41:21 +0100 [thread overview]
Message-ID: <ZXMA4YWKx6CM-jiE@ws> (raw)
In-Reply-To: <mcickgfi73ljvgxa7krdtuobuvfo3lvr5d67zqke2f2fbjj4sj@tutctuqoy7ce>
[-- Attachment #1: Type: text/plain, Size: 910 bytes --]
On 2023-12-08 10:42:07 +0200, Saku Laesvuori wrote:
> Hi,
>
> I'm planning on refreshing Guix's haskell packages as my fix for
> https://issues.guix.gnu.org/66347 requires rebuilding all of them
> anyway. Should I try to keep commits small with only one update per
> commit (which is more work but managable if I don't care about the
> commits being buildable) or should I try to keep them buildable (i.e.
> update everything in one commit)? It is quite certain that most of them
> will not build after updating ghc or a subset of their dependencies, so
> making many small commits would cause nearly all of them to be
> unbuildable.
If for not other reason then to make git history bisectable, I think each commit
should be buildable. But this is just a opinion from the peanut gallery.
Tomas
--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-12-08 11:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 8:42 Should commits rather be buildable or small Saku Laesvuori
2023-12-08 11:41 ` Tomas Volf [this message]
2023-12-08 12:05 ` Lars-Dominik Braun
2023-12-08 16:35 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-12-08 15:44 ` Liliana Marie Prikler
2023-12-10 15:28 ` Saku Laesvuori
2023-12-10 15:50 ` Liliana Marie Prikler
2023-12-10 17:02 ` Attila Lendvai
2023-12-10 17:50 ` Ricardo Wurmus
2023-12-10 23:20 ` Attila Lendvai
2023-12-10 23:56 ` Philip McGrath
2023-12-11 10:51 ` Attila Lendvai
2023-12-11 11:51 ` Ricardo Wurmus
2024-03-04 21:38 ` John Kehayias
2024-03-05 4:32 ` dan
2024-03-05 5:19 ` Liliana Marie Prikler
2024-03-25 1:15 ` John Kehayias
2024-03-25 3:23 ` dan
2024-03-25 3:23 ` [bug#69461] " dan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXMA4YWKx6CM-jiE@ws \
--to=~@wolfsden.cz \
--cc=guix-devel@gnu.org \
--cc=saku@laesvuori.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).