From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id IH0jJtuxHmVm/wAAG6o9tA:P1 (envelope-from ) for ; Thu, 05 Oct 2023 14:53:47 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id IH0jJtuxHmVm/wAAG6o9tA (envelope-from ) for ; Thu, 05 Oct 2023 14:53:47 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7FC6846D7E for ; Thu, 5 Oct 2023 14:53:47 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=S3DlODcg; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1696510427; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=tuEGvMMzuyQlfV3zysALV9crRP0DkYVroh6RaXled4M=; b=JzVAJxH5pw9MNGOE0GUPzqOx6IlBQzFJietyHHN3WPr7qvQbYAiyg8Hy2sHj467JK0qQwq r8/NlAGZeE3rw3VdM4uUCvOvaSQFjRxinBzDbXD69a0TtiPxyK6HLOWD6iOaXZ2NzncKJC Ew5sfdPklKadrdPZk4aBvpfPIj71zMog2B+z6n3wfzhUMvJ4lpliUaZhy+wu6kr+VDl8GV gI8tPeLWNEZEbcoxcwiRtOgap4QXbyhdwmGM50axrXFsZLEhhlPAvY4I7AdhyON3XIRqaw U2JkJbwIYS6docwz1wEivgoM8mQG6HC9ns+5/AAG+gIRKXt7Yzs5YyfJI+rYtQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1696510427; a=rsa-sha256; cv=none; b=CRfoFR6ia8bfrg1ZitLSDz3oVopSw2uzkxpk7msfQrGZCgo3fHDLvr/SorFzl821nkI/Gy nzzoOaF3HWngM7u1Ix1bQzIGptK4ul++JC3UViZ18VvNGUpcHqlIEchzkXmD7ccYqdG69f Q0mCqPllNdpw0kS9uuOLaN+BnDywMMFf5N78urmS5fhyc3HVeI1uNQ3I/UaE+DoeqeS6JG 3zARz+zmgarW9rt7RCBSpl6FPxS1nm6CgQfSylcWC+c3s0R/lHzftAVajFgtYy6pUvQGtR eXCmQzNIiRu0B5EZyVNsNL9bq6WHpTzqqrXK1wKu6dGvqwW96HZ7ZS8FInFfTw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=S3DlODcg; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qoNqY-0001bj-1L; Thu, 05 Oct 2023 08:52:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoNqW-0001UY-3W for guix-devel@gnu.org; Thu, 05 Oct 2023 08:52:52 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qoNqU-0005Zk-8s for guix-devel@gnu.org; Thu, 05 Oct 2023 08:52:51 -0400 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-327b7e08456so953842f8f.2 for ; Thu, 05 Oct 2023 05:52:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696510368; x=1697115168; darn=gnu.org; h=content-disposition:mime-version:mail-followup-to:message-id :subject:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=tuEGvMMzuyQlfV3zysALV9crRP0DkYVroh6RaXled4M=; b=S3DlODcgBvaMCJ6pbE38VE0oDZTIvxSCEyQI7hIe0MQ7nS6Hz52y9LpAxVvRTUTO/F aE1Gbdt+9tTQGwXWYES+BGwHWBBjyaftdQXXlgNVPo7jo2mDbKfwhk9j6KowtMQxFouG 6vIG/fjgDYZmlrKLfmqqTNGxnwbf/NJbNxgX44q5IOKljHxzB9T9pKzk24Odou6CWe0e E9f1hdbDZhKl5LZ77bMIKYcvC2X3TSXyVlpr9gfT+PF0YuLeC44CHUt5/dWg4tAWXFCO qyhMpiZdQ+4S1AzEBnRH5sURbV3myt1e5/eEG1OzpZSYxYeXehSFqh8MDi1PIBdlRHQn lkuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696510368; x=1697115168; h=content-disposition:mime-version:mail-followup-to:message-id :subject:to:from:date:sender:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=tuEGvMMzuyQlfV3zysALV9crRP0DkYVroh6RaXled4M=; b=WxdIVB4U2JCo27SUZS9IaUarTS9HRzI9tdwUo5alhhqtnoFOQF7AXUr37D+rqEg/CQ McWFuJLjw4vQTTu2tORwNX4HvupD9Gxsb5pWRIBQOCqOo6Exxb+VTW67wgHoEI//RhM6 LSyVvQIzgo+ndq6rH7eWLlyCCqgc2q0QxAM7XoYIwWGHjjt3sh/pAVw0GqCUEzd8o5uu FKxJpzr/U2Sx9hxDL0Ad33W4iaEf2szA7nNYmaQ2lO3XjWJ0sR5F3UbtM7n7Aio/hoo/ FNTRKWCCQX+oQMnb5EM0WvNAvYWo6T1EMu/Qo38DtANdtL4uf/yaX1Ncekpns4c2xqED DCew== X-Gm-Message-State: AOJu0YwTWqmB6C8BYhKPRIKLbUeN9v8dX+rqY0AIzP1g6XrS44jxh+1e b1OpfzIPFGRtNc1JPF0rR4afihh1BhipzA== X-Google-Smtp-Source: AGHT+IFGitW/JNp/TDztDzVJ0TTw8rQ/9B4QVmOmrsgqf1GDpgwikMIbiwNa2ZyWrKJoStm2UvNFrA== X-Received: by 2002:a5d:4087:0:b0:31f:ec06:204 with SMTP id o7-20020a5d4087000000b0031fec060204mr4415578wrp.52.1696510368405; Thu, 05 Oct 2023 05:52:48 -0700 (PDT) Received: from localhost ([2a02:ed3:916:6300:c3db:b80e:a694:a54f]) by smtp.gmail.com with ESMTPSA id t14-20020a5d49ce000000b0030647449730sm1733780wrs.74.2023.10.05.05.52.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 05:52:47 -0700 (PDT) Date: Thu, 5 Oct 2023 15:52:46 +0300 From: Efraim Flashner To: guix-devel@gnu.org Subject: [RFC]: Skipping rust crate tests by default Message-ID: Mail-Followup-To: guix-devel@gnu.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZNerMkWw/7FJF5Ef" Content-Disposition: inline X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=efraim.flashner@gmail.com; helo=mail-wr1-x430.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -3.84 X-Migadu-Spam-Score: -3.84 X-Migadu-Scanner: mx1.migadu.com X-Migadu-Queue-Id: 7FC6846D7E X-TUID: 4GmsnYwlZ7Ys --ZNerMkWw/7FJF5Ef Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Currently for for rust crates we build the crates, run the tests, and then in %output we only have the license files and a repackaged version of the source. The build system goes: unpack source unpack crates patch shebangs patch checksums of the crates 'build 'package 'check 'install 'install is clear, it does whatever the install command is. 'package repacks the source crate, after we've done any changes to it in the snippet and later if we've gone and patched paths to binaries or libraries. In theory this is useful with using these crates in a GUIX_ENVIRONMENT 'check runs the test suite, which fairly often seems to need some massaging to skip the odd test which fails or to try to skip the doc tests, which fail far too often. 'build sounds like it just builds the package. The first thing it does it makes sure that all the necessary crates are included in the build environment. IMO the 'build phase is the most important one, it's the one that lets us know if all the cargo-inputs and cargo-development-inputs are correct. We don't care if rust-rand-0.6 or rust-nb-connect-1 builds, we only care that it has the correct inputs so that when we pull it in for an actual binary or library everything builds correctly. I propose changing the cargo-build-system to have '#:tests? #f' by default and then enable them for packages which have a "clear output". It will keep the benefits of knowing we have the correct inputs without worrying about test errors we don't care about. If it fails to build during its own 'build phase that's actually worth looking into. It will also cut down the amount of time the CI spends building unneeded rust crates, and lets us see which ones are actually broken. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --ZNerMkWw/7FJF5Ef Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmUesZsACgkQQarn3Mo9 g1FYKxAAvBw+LCUB1/r/B2yUoVjwEr17e23ftF6E2bopwBRIKgY8LF0bYrLwKnJu B0fIwEAp6dDGl6wdBv32MelGagVJHQQYejpkmn47UgsDzXYOPAJG8Jou8nAGkD5q IqHakTnxKPG61h1/AodZhUOmcn82NLsfxn08Xoh9SYfyWez8yzIi/PlzhLiwZeIM A+h0Lg59T5d5RYU6iXsK7YNdlNV5997Sg88LY+M9zBu5FyKpz30IItaVZrm0InRU niDlP+50D1qO2thNB4KNCPWI5Dop7Oeskckwt9zYng96FXTmYCcbhBRKdy4NyqpQ yTo5RHdSTadXHr8NLkuFxEhQ25mdNAbJqpYnJ+6PHkUKz43amzFP3SCDOAFKMGeD kxhp+SSeMArVv1KUZqqUmlqF7e/PIESCNYUaZW2O7ndxMqFLY0DqR8csqDvkMPQW wBklHRViTy62csR2FgssEA4IC9UNeAsrtnoT+tZQ2V45wCZsQPoLMyW7g/v5nfSO UQKvtp2r4CCyW0EZmoP7k4CAB+PEG43/t8K8pvRJniIQjUAhmhAgzSEp5J1cKMvs xYkVrcNpcqK1iHFv9fNvyHNjXEKSsi11i6BJ4gU5V0XtcJW5CSArhrtkSLaXdbQ2 OVDB4uu93qDhlgUbLe4+fgsNy4z2dUyg1BCDBxLznhOo+OQFF1g= =MvHV -----END PGP SIGNATURE----- --ZNerMkWw/7FJF5Ef--