From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id OHk8DSoP+2RN1QAAG6o9tA:P1 (envelope-from ) for ; Fri, 08 Sep 2023 14:10:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id OHk8DSoP+2RN1QAAG6o9tA (envelope-from ) for ; Fri, 08 Sep 2023 14:10:18 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CADEE445AD for ; Fri, 8 Sep 2023 14:10:17 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=sSRKR6GZ; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694175017; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=KMnsLhsqL/sYYc9w2l4vCheRJRcntOBblgD81HQ/7hQ=; b=Brh9J6lntqc/ATrzi56kNEvE7X1pT5qaisJl8bB2pZVKhxFt+gqUkiTV2oz/gSpXQDuyD9 AALTQn/q+kPPr6UhuRTNvPatL/BRYfV6RYtxBpbDA9uqWmcadknnO34g+6MWsIg0H5fGlu YmP+BHj9xm5IeKtgeA7Qvt3w0Ry8NCtCakgnd676G8ELOaT+NQMh07XlKlieI6qvKk0lUC vELMI3FbEMIc+EenkGWczRp+qJoL4JHMA/4kZBZ5RTaQXG1wu6eotM+Du1cFdHmW36BBW8 9cVdr/DZYhuIShwj91VoHj+n2eoMQQ+WkTH4weORdjOXtuFhQg0y3BDxIC0DGg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694175017; a=rsa-sha256; cv=none; b=ZBd0vDigI5f46yr/+GxGW59TGC7ZxDGuAQSWwMKaQ2hkwog1NuL7rol6nlBqtCHE0JnzRW kcVTH4P6V6Mtp9NjRGRMLzfnBABKZbbXeu5eMtOirTcbnDT91Wwmtlj8U+DFUL/Nqsj7Tv fw60SZ/SPOLNm42JlhpF+ajDMGZtJTUMDpd+FVvVN1EVWz0W0mqYUK+0Y0w7FBuSCwtgnt zZxvBvLf5CuHy+Lxiscy1LxcZzoq+O/I4zazJxkjX97jFWrO8qSuNg77+ejfvOW3Rb41xS aCfqdS/AUfK3BjlSzgl5UTCY/YW2EJ0dDHRSE6JtCToHi5WkLs2IRqfa8PLREw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=sSRKR6GZ; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeaIu-0000YA-B7; Fri, 08 Sep 2023 08:09:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeaIq-0000XS-Mr for guix-devel@gnu.org; Fri, 08 Sep 2023 08:09:36 -0400 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qeaIm-0002GT-Ca for guix-devel@gnu.org; Fri, 08 Sep 2023 08:09:36 -0400 Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-68a410316a2so1758492b3a.0 for ; Fri, 08 Sep 2023 05:09:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694174968; x=1694779768; darn=gnu.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=KMnsLhsqL/sYYc9w2l4vCheRJRcntOBblgD81HQ/7hQ=; b=sSRKR6GZKRG0OpsRuIKsnTwWDWedWBBNv07jemXuR3ZmI3AcABFf8fLzU9kh552tgz HNIsMKog6hn5+CY5kMMnwH2UVnxDeHbamAyC+OY0bBCfETpeBWr/AnlkOAb0Ld3cdEWD Yquh/nicf0yYV1C3iqs1nurzJADjEWFrlw29AeDT8lEPnvjB6O/x0/94IqlqkW3651Go xj4CF1qUNbQpo5v5h3nosAY6CA5GNnQyXM8XzakMSX61LhM+IZQr3mdC/FMXaNymBEU5 a0/onJQcIGEGM1WPprIUQViidvX6YuApd47Ltr+34l3S7LwqPEkvpI049Dgv+/VD0Z2L SAfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694174968; x=1694779768; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KMnsLhsqL/sYYc9w2l4vCheRJRcntOBblgD81HQ/7hQ=; b=Ol8LfRPke/48sZJSNP9OFYiu4kq22aSgcHO6gyNCAUkhUgbenN+I1GLKGSnB13oSSG LiAVkZ0oh+4oNUKacktRLR/6Zo8xeKxr8C0QfVUDFRk6p2qjhOP4j8ylJKlbClCL+VPw tqWA1guijkbKn4M0Ej3p80lk0Lv8MRLLJvSkvtdKS5aG5b5S1HYN43xUfHAVDXuFpgn5 uQ+6fPkmA2PonbCOkD6U2eKWADClYZT2wTxnGoDBAHaH/m9F7pwAs30k1nGla9YCa1g7 NxhCYZo7MGn2MxTdcub4E2z+s0UtRywsgE5i9WRmR4jmrx07n/qb5Cm9cR1n9XMldU90 c+fw== X-Gm-Message-State: AOJu0YzQAZN3sNhR3iZGSvGsAUpCZLM3Rlug6bs1jc3XcQRBpQ9w6byf 5OqvF0fpVSbignBTFdkk8rE= X-Google-Smtp-Source: AGHT+IG6MOB91IyU951K25LZVZEjz404uC5U1+z1WTutfzsUOdWPOTC23UUglm9PTTVSA43zs3edQQ== X-Received: by 2002:a05:6a00:1ad0:b0:68a:4b8c:4e91 with SMTP id f16-20020a056a001ad000b0068a4b8c4e91mr2244144pfv.19.1694174968488; Fri, 08 Sep 2023 05:09:28 -0700 (PDT) Received: from localhost ([115.110.84.132]) by smtp.gmail.com with ESMTPSA id h15-20020aa786cf000000b0068a13b0b300sm1265078pfo.11.2023.09.08.05.09.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Sep 2023 05:09:27 -0700 (PDT) Date: Fri, 8 Sep 2023 15:09:03 +0300 From: Efraim Flashner To: Giovanni Biscuolo Cc: Katherine Cox-Buday , Simon Tournier , guix-devel@gnu.org Subject: Re: How can we decrease the cognitive overhead for contributors? Message-ID: Mail-Followup-To: Giovanni Biscuolo , Katherine Cox-Buday , Simon Tournier , guix-devel@gnu.org References: <20230827135726.y33t55w4cvq6zsvb@X-kone> <874jkift8v.fsf@gmail.com> <867cp4sj7k.fsf@gmail.com> <38242808-2f06-4674-3842-aea1a5378d05@gmail.com> <86v8cop6sy.fsf@gmail.com> <87v8cldm8o.fsf@xelera.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lzvS7894sOrh4qzn" Content-Disposition: inline In-Reply-To: <87v8cldm8o.fsf@xelera.eu> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Received-SPF: pass client-ip=2607:f8b0:4864:20::42a; envelope-from=efraim.flashner@gmail.com; helo=mail-pf1-x42a.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -4.33 X-Spam-Score: -4.33 X-Migadu-Queue-Id: CADEE445AD X-TUID: bcUVrXsaPRUF --lzvS7894sOrh4qzn Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 08, 2023 at 11:53:43AM +0200, Giovanni Biscuolo wrote: > Hello Katherine, >=20 > Katherine Cox-Buday writes: >=20 > [...] >=20 > > By "standard" I mean the GNU Changelog format > > (https://www.gnu.org/prep/standards/standards.html#Change-Logs). As > > in: it's expected that commit messages use this format. >=20 > [...] >=20 > > In my response I was trying to point out a flaw in your comparison: tha= t=20 > > with style guidelines, which are also complicated, there is usually a= =20 > > formatter that will do it for me, or a linter that will tell me that=20 > > something is not meeting the standard. This is because languages have= =20 > > grammars, and linters have higher-order system grammars. >=20 > AFAIU you are talking about the "Formatting Code" /subset/ of a "Coding > style", because there is no linter that will tell you if you are > following the subset called "Data Types and Pattern Matching" [1]: am I > wrong? >=20 > Back to the git commit message formatting: please can you provide us > with one or two examples of how a commit message should be formatted and > what linter is available for that syntax? >=20 > [...] >=20 > > Here is my channel with things I intend to upstream, but haven't, > > largely because of this friction. >=20 > By "this friction" you mean you miss a linter for commit messages? >=20 > Or do you mean you do not agree with the style requested by Guix (and > GNU) for the commit messages? >=20 > You are obviously free not to contribute your patches upstream but the > fact that you decided not to because it's "too hard" (my executive > summary about your complaints about Change Log content rules) to write > commit messages suitable for contribution it _not_ a Guix maintainers > fault, not at all. >=20 > Obviously everyone is free to comment, ask for clarifications or > proposing **patches**, but it's not fair to say "I'm not contributing > largerly because I've a specific friction with the rules about commit > messages" (again, my executive summary). >=20 > [...] >=20 > Ciao, Gio' That wasn't my read of it at all. I too have many packages which I haven't upstreamed. One of the major pushes that I did was cleaning up mailman and pushing them to Guix. I had just finished working on it earlier in the week and it turned out I didn't actually need it anymore, but I figured better in Guix than out. It was either one or two 8 hour days of reviewing my own patches, making sure they all built correctly, and then finally committing them. I also have almost 500 go packages which I don't intend to upstream. I'm package them and update them occasionally when trying to package some big application like gitea or keybase or tailscale or gotosocial, but the effort to go through and see which packages are ACTUALLY needed and to clean up everything, it's just too much for me. I suppose this could be construed as "I'm not contributing these packages because I don't like go" but that's not the whole of it. And by rephrasing it like that takes out the nuance of other bits of why I haven't worked on those packages and neuters the discussion about why these are my packages instead of our packages. As far as commit messages, I've found that the script in etc/committer.scm to be very nice, even if there are plenty of cases where it doesn't do the job. I do think there's room for improvement and that may be one of the things we can do to make contributing easier. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --lzvS7894sOrh4qzn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmT7DtYACgkQQarn3Mo9 g1Hh7Q/+IDxh2ngTGQpziXgTGE6ZIFHpDLyWkGOznruF42Wsbbh3bjx2NFm920c+ v9uGuqmhXOikdyVjvRC68CWfaMlweSQ8IaIN/xm3q7NBaV1qyIiY73HeMX5Lz7xw gowlL4Bu+vCwSt+zawxrCMxhgSac/mcpbX/Q0+CR4jy7J7oXisLCceNNKLp7Fg8k 42ocyoDyQfUvWnKeTOUo+k7hu5+st3P7t8Cdj5m4Rn0Kgts18Oj4DpLsaiIsfSLM 1HnCYm2iJndKZHX5HmZ6E1/kXbmtUrw3HiTole1dt7bOCmFD28ecqGsYLKEBBJaP tvQtuIlUnRnl4PX7iFkWzYNijaEYysaw2EOQ4dIEtXoBErnDBTcnMG8tQzf69TFt AKzkkj8CkPZ9NPm4qceawYqgS0PpdE8y5eGTsnB/k3FM7Zzq9IzsH27RmlD15YRV RxWCEhdlMaMKokBL6eRS0xgxrcsfqincjZyGxmfJ14e+95qnS6MR5UDXGmwCxxc7 hzfsi6UJ4S7OVnonsUHOtv7Mxqy3PCeDXyNA9oegJtry0s09dbSIxqDgZ9G+62UK u5xzQcB2CfVvxvAQPB+jr/Wfm0BFqELmcqLsLgv8LaL5KMYNkPjT7GGSFDjyJyLJ mgHGH1eCZ/psCPtV7MNlVDKCGu4TzZCLkGT0Xevm3151kExCuOE= =FHLI -----END PGP SIGNATURE----- --lzvS7894sOrh4qzn--