From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id oAHQOAAJ62S1FwEA9RJhRA:P1 (envelope-from ) for ; Sun, 27 Aug 2023 10:27:45 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id oAHQOAAJ62S1FwEA9RJhRA (envelope-from ) for ; Sun, 27 Aug 2023 10:27:45 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8C9C26ABE9 for ; Sun, 27 Aug 2023 10:27:44 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693124864; a=rsa-sha256; cv=none; b=IQDh1JAW4D7wla55NmRTdqzz2th4LMtHDS5mUwGQ7Cfbg6Yg5rNmKv+uoodkeBdw4mSLtE VfC6nP+f6RiMja2gXcDZlyXYjLf9PTZu9gVnKE/WWmdaTzbZzPA+/W+W74vA55nSBFHViQ Hpv1u9z6ShIAd/m2mCQ8Zl3OVCvMW0yEUeVzUORSs9C8gWSthx6+TbBKJjHS4saL6SvKYF ZvCJJEiGehNRg+ZQuWtJprQPHW2K9Kj+/Nx4Y81kx2TRxKPb7r4Tugd58jHzbFUBt0l9yL QDZUOBIF+0fagdVAKtn/78Gpq8Lkd1IoV2trPRnbaDKpfykonC8osrZRjT7QHA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693124864; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=BPLWmgSBqo8V3fAgJe0JCCCHdaVmqtUDv8ksihh+PFw=; b=KB8cNXB6ei+diICBEG2j0mwSO822+UO9iNUdxgDBGbmX6ULDTIOX2tc0mHSzHumtKSbvXs IxAA8NaJdlap4A4MG4bpdhjYjD9NcPgor12DpO9PEDPE5W394H/MlgqFsf+unjH6BGHyYt OAUW5Ic5DJc61qd42STALiYLIf6eEQV9ScQV3DdK+0oZGoKVrgTVF/hYtBLgiaPEpNW8pJ r/wjo7+tGadsr62fv41b0kqd3kjNWM4PEcHvUi3qLMTqr6lRrVq9mJiL0dxV22Gmvzp58b lWrM93OHaDL98b/oId2T0pmrwUJho0Enx7jXWQ8lBdYtOUJmlIyaqhc9mdUpxA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qaB6z-0003DK-8W; Sun, 27 Aug 2023 04:27:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qaB6x-0003Cp-82 for guix-devel@gnu.org; Sun, 27 Aug 2023 04:27:07 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qaB6u-00021N-SK for guix-devel@gnu.org; Sun, 27 Aug 2023 04:27:07 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id C08084FD; Sun, 27 Aug 2023 10:27:01 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PmVDp2NN7GHi; Sun, 27 Aug 2023 10:27:01 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 0545614F; Sun, 27 Aug 2023 10:27:00 +0200 (CEST) Date: Sun, 27 Aug 2023 10:26:59 +0200 From: Andreas Enge To: kiasoc5@disroot.org Cc: Attila Lendvai , Wilko Meyer , Katherine Cox-Buday , guix-devel@gnu.org Subject: Non-committer comments on patches Message-ID: References: <8735084vv2.fsf@wmeyer.eu> <0e88ad722f88591d5e79da9793a2a64e@disroot.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0e88ad722f88591d5e79da9793a2a64e@disroot.org> Received-SPF: pass client-ip=185.233.100.1; envelope-from=andreas@enge.fr; helo=hera.aquilenet.fr X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx0.migadu.com X-Spam-Score: -3.88 X-Migadu-Queue-Id: 8C9C26ABE9 X-Migadu-Spam-Score: -3.88 X-TUID: 8XKxY22tQ6hH Hello, Am Sat, Aug 26, 2023 at 07:42:13PM +0200 schrieb kiasoc5@disroot.org: > I would like to hear from committers if non-committer reviews are helpful, > because I don't really know how or what I can comment on for incoming > patches on packages I'm not really familiar with. > Also do "this builds and works locally" comments help? +1 for Liliana's comment on "works locally". "Builds locally" is superfluous, as I always rebuild packages I commit (and there is QA). As a member of the science team, I end up being "responsible" for packages I do not use and cannot really judge. So having a second person comment that a change works as expected, or that an old version can be dropped, or cannot be dropped because everyone in the community uses it, or anything indeed related to the use of the package, is a big help. I have even ended up solliciting comments by people who have worked on the package in the past. I can also imagine a go team, say, of non-committers, and then committing on their behalf when two team members agree with a patch, for instance. (With the goal of adding committer(s) from the team eventually.) Andreas