From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id AMPJIkt072TBZgEAauVa8A:P1 (envelope-from ) for ; Wed, 30 Aug 2023 18:54:35 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id AMPJIkt072TBZgEAauVa8A (envelope-from ) for ; Wed, 30 Aug 2023 18:54:35 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 52E0E39B49 for ; Wed, 30 Aug 2023 18:54:35 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693414475; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=03S18vUiVLLf9FRqWxd5v7K8kbWuSPN2mWw3qn1l1uo=; b=Pac3JG425oruHyVqt4aPhWMXAowK0jP+oRiC4f+hJRcgP0Je7RoF5XAwVkZzyvOBFN1Sgx VJiQn+zoOT3rz9XlbaMdhOKwPcXptApruUj/g6wmDRGai01qm+BmkDCE/EMq0Y9AivVIHh rBP/1Y9wx9Wb0pku9jMU877rlXasw9qAfM3b4ygJUv5Y+22bIjQEGo3uafJPEdVQwNXzQ4 7+xr179q2JdaummjHP88g7/73QyDUE8iw11nWLbKR4vbjA1v97piY7TAYmVd5zh2RUukIh I+CeaCOOLTFXwrhzpZtZtdkjzH09gwtu66Ve0zt3nSUOwqliO3o8QDqHvXFSrQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693414475; a=rsa-sha256; cv=none; b=Y9+dHhjIJhIPTSovyqKrBWN8r0svwT/XlrlFfKc4HgRpMmQPRu7gXQJbvJeIRH+/3IpjCo O0bwzw+cgkWXU8VLAVPODtdsGDZSqbMJ9dAgjdtfonhqf/NM/7yIQU+azAYv8Sr4sKDroC ZemJR8HbSyzxH4S1IRlQ2rfzNfy0BFuje7I4TOZRBEefbvCbuwc6a1XG4Pds2+qcPvsNut MOuSXjYrjWjqR18u4QqJnu4IU2Tc/qod84rZT+oDxglQGJE96OvtC+R27B9vRpboW+/4wa 4/hadHIgY5F+r5si4/pC51Ew53aaXMaIw2isim3k8+L6L71Y2YB3ZZS7Uw5pXQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbOS5-0007Ag-6i; Wed, 30 Aug 2023 12:53:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbOS4-0007AT-5M for guix-devel@gnu.org; Wed, 30 Aug 2023 12:53:56 -0400 Received: from hera.aquilenet.fr ([2a0c:e300::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbOS1-0004Jg-J6 for guix-devel@gnu.org; Wed, 30 Aug 2023 12:53:55 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 54E8E1550; Wed, 30 Aug 2023 18:53:49 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UWseahfGQjUl; Wed, 30 Aug 2023 18:53:48 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64]) by hera.aquilenet.fr (Postfix) with ESMTPSA id AB1871477; Wed, 30 Aug 2023 18:53:48 +0200 (CEST) Date: Wed, 30 Aug 2023 18:53:47 +0200 From: Andreas Enge To: Katherine Cox-Buday Cc: Simon Tournier , guix-devel Subject: Re: How can we decrease the cognitive overhead for contributors? Message-ID: References: <871qfsuvad.fsf@gmail.com> <8e74c4ac-a6f3-9127-7e13-593a2eb70432@gmail.com> <87a5ubqxm6.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Received-SPF: pass client-ip=2a0c:e300::1; envelope-from=andreas@enge.fr; helo=hera.aquilenet.fr X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: -4.32 X-Spam-Score: -4.32 X-Migadu-Queue-Id: 52E0E39B49 X-TUID: qlcNRtmt9Ajl Hello Katherine, thanks for your summary, which contains many points I would agree with and actionable items (disclaimer: I do not promise to act on them). Am Wed, Aug 30, 2023 at 10:11:02AM -0600 schrieb Katherine Cox-Buday: > Here's my understanding of the process to contribute a patch: My process is actually a bit easier... >   5. Create a git worktree for your patch >   6. Run `./bootstrap`, then `./configure --localstatedir=/var > --sysconfdir=/etc` You can drop 6 assuming you do not create a new .scm file. Instead of 5, I usually just branch off from master, or simply work on master itself (for instance, for a simple package update). In the latter case, after creating and sending the patches, a "git reset --hard origin/master" drops all my work. >   8. Make your changes >   9. Build to ensure your changes are workable. >   10. Try and determine how your changes should be factored into individual >       commits (sometimes it's not always so clear when changing two things > might >       need to be done atomically). >   11. Try and get each commit message close to correct and commit. Usually I start with 10, and then make the changes incrementally. For instance, today I wanted to update a package and change an input. I simply changed the input first, built and made a commit. And then I updated the package, built and invoked ./etc/committer.scm. Admittedly, I also do not do all the checks you mention, like closure sizes or reproducibility of the builds. Andreas