From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id AIkgJIU5MWS0fwAASxT56A (envelope-from ) for ; Sat, 08 Apr 2023 11:53:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 0LkuJIU5MWQgCgEA9RJhRA (envelope-from ) for ; Sat, 08 Apr 2023 11:53:09 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4263C1E5BD for ; Sat, 8 Apr 2023 11:53:09 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pl5FT-0002al-Fj; Sat, 08 Apr 2023 05:52:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pl5FP-0002aH-H3 for guix-devel@gnu.org; Sat, 08 Apr 2023 05:52:39 -0400 Received: from hera.aquilenet.fr ([2a0c:e300::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pl5FN-0003k4-2Z for guix-devel@gnu.org; Sat, 08 Apr 2023 05:52:39 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id A8EA2635; Sat, 8 Apr 2023 11:52:31 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QJcY0VT8Olj2; Sat, 8 Apr 2023 11:52:31 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64]) by hera.aquilenet.fr (Postfix) with ESMTPSA id CF5DC5C4; Sat, 8 Apr 2023 11:52:30 +0200 (CEST) Date: Sat, 8 Apr 2023 11:52:29 +0200 From: Andreas Enge To: Kaelyn Cc: guix-devel , 62646-done@debbugs.gnu.org Subject: Re: Fix for librsvg 2.40 on core-updates Message-ID: References: <-yuU5lP0atxOfIH2n0tY_JcRohzhb2HtmCj8owCxLEvkaOKSIx8nebEwIarFeEZ0Tab2HOVv_zNjWsa9fFNy8Rs7QU0RWPHIvl0FHKrSPlY=@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <-yuU5lP0atxOfIH2n0tY_JcRohzhb2HtmCj8owCxLEvkaOKSIx8nebEwIarFeEZ0Tab2HOVv_zNjWsa9fFNy8Rs7QU0RWPHIvl0FHKrSPlY=@protonmail.com> Received-SPF: pass client-ip=2a0c:e300::1; envelope-from=andreas@enge.fr; helo=hera.aquilenet.fr X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680947589; a=rsa-sha256; cv=none; b=J5sUp5F1fQaCPET2ry6MvbrG+1y9dRzdiPCONxhtQgO3jrZqqaazqECOKiPI6vPjonuN/E eey6ed3hYcDPt39TYqy7RNHQ7N9OUcQNLeu2hJ+pmePHMcnLDAEob0XK8o6QidpoZDBtjw YkB6v1MIPo4xOd9KiHQ7OXCJwfdT2BKm9QjN2EJlLlJ/ThsZsI/Bel4KbyO4E2qjt2r5By fLUDPyfDuxYdsPghgd98rXrX6lDvtCXtK63fODIq9KlcQPDVRzUCiefo/y5Kin8MIWskY5 19xQ8OpuVY8uIFDb7BecXBxLoPIhNkG4C0GX7m2rqgA5cMBQkH8X6/E905JQKA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680947589; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=FWFzTNRBwUNpp5ohAyh1uhWdIsnclFst+mBA4ThlQ2U=; b=Kf/yhiIG+iT8y9E3l1qPFJU6iBmM1LzURK3acQEHDjM2HEyvSJarSDsLXBqbeQ8+TIjPZu wR4AxWclCvHlLXvM/FKLjW/vw/PTIUAu4kYcjlAA74rYFcsnWwlml6jyhih/YYtgLvUf6R FgXHxE1ym4AX0DTtm4hQ+Djpx9SCfVIR1mepPMxJZ8trXdRZ9RXcuXoL6/KfXxWTZoMerG TALp9pw+5AsC3wSmlVo0U5jdxjAtZyTwgcvEBuiNeWN66tt4a/cSa5CBKe5tN4Ac8SWty/ +tNu5OzGKBqoVkw0+OB/emrTCsPmdxVoxNP1Uaq4YSD95lfsSqm5pDDpcQGg9Q== X-Migadu-Spam-Score: -2.52 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Spam-Score: -2.52 X-Migadu-Queue-Id: 4263C1E5BD X-TUID: DqVd1XlQhZGX Hello, Am Fri, Apr 07, 2023 at 04:53:15PM +0000 schrieb Kaelyn: > On core-updates, librsvg-2.40 fails to compile due to a single failing test (I've confirmed the failure on x86_64 and i686, though the package is only used/needed on non-x86_64 systems for gtk+ and others; it also affects wine and wine-staging on x86_64 as they are 32-bit packages). I was able to track down the test failure to a text rendering difference between Pango 1.48 and 1.50, which led to the text being one pixel line higher between the reference and output images. On Monday I submitted https://issues.guix.gnu.org/62646 which adds a phase to librsvg-2.40 to adjust the output Y coordinate of the SVG transformation matrix by one for the failing test so that it passes with Pango 1.50. thanks a lot, I added a copyright line for you and pushed. Wine still fails to build due to autogen not building on i686: libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../autoopts -DPKGDATADIR=\"/gnu/store/6i60j0fxdsg4qwymas4ymfqlv1azidnc-autogen-5.18.16/share/autogen\" -g -O2 -Wno-format-contains-nul -fno-strict-aliasing -Wall -Werror -Wcast-align -Wmissing-prototypes -Wpointer-arith -Wshadow -Wstrict-prototypes -Wwrite-strings -Wstrict-aliasing=3 -Wextra -Wno-cast-qual -g -O2 -Wno-format-contains-nul -fno-strict-aliasing -c libopts.c -fPIC -DPIC -o .libs/libopts_la-libopts.o In file included from libopts.c:48: usage.c: In function ‘prt_extd_usage.isra’: usage.c:736:38: error: ‘s ’ directive output may be truncated writing 2 bytes into a region of size between 0 and 9 [-Werror=format-truncation=] 736 | snprintf(vfmt, sizeof(vfmt), vfmtfmt, (unsigned int)nmlen + 4); | ^~~~~~~ usage.c:736:9: note: ‘snprintf’ output between 9 and 18 bytes into a destination of size 12 736 | snprintf(vfmt, sizeof(vfmt), vfmtfmt, (unsigned int)nmlen + 4); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Just in case you wish to continue investigating :) Andreas