From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id IHOvCKO9B2R7swAASxT56A (envelope-from ) for ; Tue, 07 Mar 2023 23:41:39 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id KJynB6O9B2RW0AAAG6o9tA (envelope-from ) for ; Tue, 07 Mar 2023 23:41:39 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 30DBE13928 for ; Tue, 7 Mar 2023 23:41:38 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZfzb-0003jY-Nz; Tue, 07 Mar 2023 17:41:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZfzW-0003Sg-2n for guix-patches@gnu.org; Tue, 07 Mar 2023 17:41:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZfzS-00064l-NN for guix-patches@gnu.org; Tue, 07 Mar 2023 17:41:05 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pZfzS-0000Qu-Gq for guix-patches@gnu.org; Tue, 07 Mar 2023 17:41:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61894] [PATCH RFC] Team approval for patches Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 07 Mar 2023 22:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61894 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: guix-maintainers@gnu.org, Simon Tournier , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Christopher Baines , 61894@debbugs.gnu.org, =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= , Andreas Enge , guix-devel@gnu.org Received: via spool by 61894-submit@debbugs.gnu.org id=B61894.16782288511639 (code B ref 61894); Tue, 07 Mar 2023 22:41:02 +0000 Received: (at 61894) by debbugs.gnu.org; 7 Mar 2023 22:40:51 +0000 Received: from localhost ([127.0.0.1]:47372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZfzH-0000QN-1x for submit@debbugs.gnu.org; Tue, 07 Mar 2023 17:40:51 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:38363) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZfzF-0000QB-FS for 61894@debbugs.gnu.org; Tue, 07 Mar 2023 17:40:49 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 622265C00D5; Tue, 7 Mar 2023 17:40:44 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 07 Mar 2023 17:40:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=mesmtp; t=1678228844; x=1678315244; bh=kQ3eh+sOjLk85SqvbitNLpmSdfRiovXbW5U7p2Q8sQ0=; b= bd3odjyhNWHr+1TXF1QnUApui1FbkaVMrWIsxGq3qXOElhNh7Ie787SV/br4bK+1 pT4KHWPV5xpsYA/Arzr4shzqfyog5Q1g0vN0YmwonyAy5eRjRJNWRU14yKV4wkgF +wN61FnSNqyfj51Qz6/Zt/Hu/UYjdlSQ2oxlEHuwf8E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1678228844; x=1678315244; bh=kQ3eh+sOjLk85 SqvbitNLpmSdfRiovXbW5U7p2Q8sQ0=; b=fxSSJg5seYKfgZJwcAvjrvGR/hUkv 8D7cLFqoiAAtF+5Ipd0kTQ9LLx6/zDjVmmk2eC83/4d0dRaEaqJES6m5d86pPdL/ VuCvEyUVqc1Ru7fTeLx4F7Nml+yu5QTDvcLJ3LEUaqjTB9mhfa9tAUL4vMPG5DYY +jYC15hNgI3gQQPm5P88B135cytzs9tvp8dtnQVEj8oVWq5tw6eQvOl+XYafLuRU gd1R55eP+ZOvHfs/btD5pjHU5hm16xHv3ocjlPYYiXtbFOLw+mjL23afIMaJWNNy vJ7Srjxs1hkg/CJFepl+VkceEs0ouXl2QJ+3IyWfjMSZC1bNQwE22Rm6g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdduudcutefuodetggdotefrodftvfcurf hrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfhrghm uhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtthgvrh hnpeeiteduheefkeeufeelgeduhfejgfelheefleeuhfeffffgueduleehvdejleeiteen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghose hfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 7 Mar 2023 17:40:43 -0500 (EST) Date: Tue, 7 Mar 2023 17:40:42 -0500 From: Leo Famulari Message-ID: References: <878rgga1qv.fsf@inria.fr> <871qm8wf8e.fsf@cbaines.net> <87r0u86qgo.fsf_-_@gnu.org> <87y1o9mina.fsf_-_@envs.net> <861qm0da4y.fsf@gmail.com> <87sfegwh28.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87sfegwh28.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1678228898; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=kQ3eh+sOjLk85SqvbitNLpmSdfRiovXbW5U7p2Q8sQ0=; b=RDGo46YNS2Om5DZY+GEEnBYe2mMwFS6wP4k8ADDVdk4yriyJfSESc6Im3dW+bUxHBUoA54 bxKdk5+jgDJvCrye1Tme4ZuHbe+YZlHhLzPRFMU9Ul+oK3Bx6n7fYSHo+CgMdCE6AFcRof 0clO1dYeIxeGw5/zanaCzY16PEh7iVyMCtGGGJkCQo23FB2LqUM/dRPdUzpnbAym+rqB/l NDAY9Y8tq51GqO6TLY9DCq06c4f+h/wH6OSDwEqLKzneS07EvW/ZmJXEAP3R3gjSIwRqMV 5Unm45cLwkVSCcXY25o2HhmYNUQ2P8K87wLA3LQo96XFkENpkqMmrWwQms9Pvg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=bd3odjyh; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=fxSSJg5s; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1678228898; a=rsa-sha256; cv=none; b=TZ5RpuCOjbe198QEOkLEnSiNI3r71H9D9xVLFuH7wW74MzE3pZLcq6bU7p7KJT1r81VQRO CCx9hJcT19Zr6VlFbaSXL1lA+QcSdodfLdtEBVo7wnaUmWSjpg+uop+Q0U2blXZ3Aa8GZ3 TZ3sOh8PxWGdTbGfM3rVqSLiOn/u4unneioO7B3YcXNXYXouboROKi6f6twLQSJBBj4t8S PQ/fLGCrBMuJMfohis6vfDe3Q3hyKmg4TE9YN65USGb9F7givy1YaHwuDIk7VR2djG2S+y KuQqKBOv4TkvmcsvoBT123XTTt71ujrkWSA5niJwTze+2E8of+WBLjU8Xa5AFQ== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=bd3odjyh; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=fxSSJg5s; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Spam-Score: 3.70 X-Spam-Score: 3.70 X-Migadu-Queue-Id: 30DBE13928 X-Migadu-Scanner: scn1.migadu.com X-TUID: HC4dtk2ikuHG I don't have a strong opinion one way or the other about whether we should formalize the review process. The status quo isn't working well, so I'm in favor of trying something. On Tue, Mar 07, 2023 at 01:29:51PM -0500, Maxim Cournoyer wrote: > I think the main problem we have is social, not organizational. There's > little incentive to jump into the laborious review process compared to > hack on something we like in our free time. We need to promote and > value review work more, without making it feel like a compulsory chore. > That's a great challenge to solve for a project that's driven by > volunteers. However, I agree with this point wholeheartedly. We really need to ask ourselves, why would anyone review patches? It's a lot of work, often thankless, and unfortunately sometimes unpleasant. > I'll venture a suggestion to explore: adding enticements to review (some > playful guidelines such as "while waiting for your 2 weeks review > period, please try to review twice as many other submissions that have > been patiently waiting on the patches tracker :-)", or some stats > crunched and advertised periodically to guix-devel or even our to our > blog about our top reviewers, etc.). In release announcements, alongside to the the normal `git shortlog` list of authors, I suggest also publicizing the list of committers: `git shortlog --numbered --summary --committer v1.4.0..HEAD` A small thing, but hopefully one of many incentives to review and commit.