From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id WP/NFukTB2T6rgAASxT56A (envelope-from ) for ; Tue, 07 Mar 2023 11:37:29 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id mLCMFukTB2RFSgEAauVa8A (envelope-from ) for ; Tue, 07 Mar 2023 11:37:29 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 372741418B for ; Tue, 7 Mar 2023 11:37:29 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZUgn-0000sm-Ng; Tue, 07 Mar 2023 05:37:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZUgl-0000sS-Or for guix-devel@gnu.org; Tue, 07 Mar 2023 05:36:59 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZUgj-0005fL-Rg; Tue, 07 Mar 2023 05:36:59 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 08A63193E; Tue, 7 Mar 2023 11:36:54 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WUacxmylU4zX; Tue, 7 Mar 2023 11:36:53 +0100 (CET) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 415E6569; Tue, 7 Mar 2023 11:36:53 +0100 (CET) Date: Tue, 7 Mar 2023 11:36:51 +0100 From: Andreas Enge To: =?utf-8?B?5a6L5paH5q2m?= Cc: Ludovic =?iso-8859-15?Q?Court=E8s?= , Christopher Baines , guix-devel@gnu.org, 61894@debbugs.gnu.org, guix-maintainers@gnu.org Subject: Re: bug#61894: [PATCH RFC] Team approval for patches Message-ID: References: <878rgga1qv.fsf@inria.fr> <871qm8wf8e.fsf@cbaines.net> <87r0u86qgo.fsf_-_@gnu.org> <87y1o9mina.fsf_-_@envs.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87y1o9mina.fsf_-_@envs.net> Received-SPF: pass client-ip=185.233.100.1; envelope-from=andreas@enge.fr; helo=hera.aquilenet.fr X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1678185449; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=fjJ037Lz3Ao06XkZfO+VwqfAeWfNjoRYKxwZ0rbym6w=; b=IbkpHq9fqWyJ1MsLomkKQz8t/xRoiVXpVDvF/DiuQF/sWnj/sn9TPXSBZuQeoioflQNAxD XoP4pM9tG89tIckMi/yYbIPuim4FEfVITRGBVB5zVxESIwmmIyVdnIcgeUDVCwqtxT2CF6 XDZhlwFQMvsKuX3XYbeOx4OoQj0GLUrM9eZkrprPP61sD+wrmrOLQ6R4GvnR8tY12asJ/1 TiRKqK9JdRb2a5oL3kiSA1H9fa/yvFoi+hV2/DMXzkE5KPnRHc4x33CFcgJMZo1NsqfCfd opP92vgYv2qWn0yv5ngO6rg7W15fAeAzk9EoamD+xRmrAv8c3+AUJSu3Q0JShQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1678185449; a=rsa-sha256; cv=none; b=RgV46k6QFZH8tUN9dcGTJlnSeOcvZDPVDB5ZltQ4QFAK5orM6DHz0t53NBA2Oj0IXnlU6F qyyxgBkv6r5z8Hcfq/F4gV9DQb6MWRXxjOhxV9XCORA/WuZykZsxYpKeqpUYQyrqWOB5F/ SotYl3bpRRwuzIqwu/6AbqfRj+h6LNKDhpUJ4G9mYhJoF8UG0dUhVoaCsEWuv720fAfSx7 77OjIC/bgD5yXi+8lcmTskhRU4JSa9qU2eWAm59APN0keypEGFG/uRYBXpIhP02VsXb4x+ h1hPauIOX7kREjtkYRrfVJYeAk7lB13pqQYpPO5fCRgV9v+k0cX/7+DishizSA== Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Spam-Score: -1.01 X-Spam-Score: -1.01 X-Migadu-Queue-Id: 372741418B X-Migadu-Scanner: scn1.migadu.com X-TUID: GLMlk2godrfy Hello, Am Tue, Mar 07, 2023 at 09:53:29AM +0800 schrieb 宋文武: > I usually push patches for others who don't have commit access, while > most packages don't have a team at all, and some with me as the only > team member. > Should I wait for another commiter's approvol under this new policy or > can I push "random packages" (eg: jwm) solo under the status quo? For > packages I as the only team member (eg: fcitx), should I looking for > another commiter for other's patches and my patches? under the current policy, what you do is fine and very welcome. Under the new policy, it would not be (if I remember correctly, there is a one week waiting policy, after which one could push nevertheless). So while the idea is good in principle, I think we would have to make sure that first: 1) Every current and potential new package is covered by a team. 2) Every team has at least 3 members, better yet 4 or 5. 3 members would make it possible that even if one of them is on vacation or otherwise busy a patch could be pushed without this additional one week if the other 2 agree. And I also think we then need 3) more tooling; maybe a mailing list for each team? A file that contains the link between source code files and teams, and a script around "git send-email" that automatically puts into cc the corresponding team when submitting a patch? And the feature branches with QA on cuirass or the Guix Build Coordinator that we talked about at the Guix Days. I think our main problem right now is lack of committers and/or contributors. While looking at core-updates, I was surprised how outdated some of our packages are (around Qt, KDE and Python, for instance; I suppose it depends a lot on the field), in particular for a rolling release distro. (For Qt@5, we were at a release from June 2022, and there had been more recent releases in September, October and January; it would be nice to have a working team preparing a feature branch in a timely fashion after each release.) There are currently 48 committers, and not all of them are active. I think this is just not enough for 20000 packages. Andreas