From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id cB/3IyFYUWcPLwAA62LTzQ:P1 (envelope-from ) for ; Thu, 05 Dec 2024 07:37:05 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id cB/3IyFYUWcPLwAA62LTzQ (envelope-from ) for ; Thu, 05 Dec 2024 08:37:05 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=NsUZgeWc; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1733384225; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=WvH877pC4ZxhaBRp795GhEOSYIbthskiXMSpAZnT5Nk=; b=OIYdC/RLHv/gc2MvL2fnttLiGGf3TS+qLRddosY9/j7RhwMGRgnK0r7wP/egFb0wcG1aQW RXLGLSVCd9qH3J7bWXg5SWGDghkYO6YP49xNR8JnhZaYPcji5JqUpvYpS3jrkzLuedy9pw akst5lP7/WGgsLuuMTYe4tlO9kMguuETejGQSpILQrz3Csl6Gp6YD62XYkE1fZHIsoq4OD bvqjqLeUOImlRz9jfm2dDxcROuEhkzlLkKLYTwf+d+3HhShvcqhNVpmZCmhzUNvtoecAhN V4Hf42ZU/00uofZMxZjzpfTgZHfDmt4t8X5oV4xP3eNC6xl/T2quCBksueUSjg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=NsUZgeWc; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1733384225; a=rsa-sha256; cv=none; b=WIHDsgIIw6LcKzQbcGS/j+2g7dtKwOwpC6gh4m3yZRmR2QfoGLIQqZ1ZWi9ANXWpDfuw32 DrKxrl+yU2FlRvejCo0bGkp/yMLcd9FRnliyXBSGQGFEylkK3tEb67Spi2ZmEOrGZxnMNn J6TGkrfPMr7OUG/2DSQ6y7QIjERdp3gywXqj3s+G5N3ml9yXr4Di40yZNT7rRtS5F+Z78L o12POyotM7uzpOtowwSGrw9rcAVKV66YBEiqt+69u2eYmBMsog0PgoQjwnJG5SOR3lHQXH Fjlknz5bnTICa+yl580EpVYF2/xqaU/cE48ZP1G6d/gZgYcq+kfJs/TqZYTgnQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5FA998A400 for ; Thu, 05 Dec 2024 08:37:05 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJ6PR-0005RS-Hb; Thu, 05 Dec 2024 02:36:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJ6P6-0005Qp-Ej for guix-devel@gnu.org; Thu, 05 Dec 2024 02:36:04 -0500 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tJ6P0-0003I7-5V for guix-devel@gnu.org; Thu, 05 Dec 2024 02:36:03 -0500 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-43497839b80so3533305e9.2 for ; Wed, 04 Dec 2024 23:35:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733384155; x=1733988955; darn=gnu.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=WvH877pC4ZxhaBRp795GhEOSYIbthskiXMSpAZnT5Nk=; b=NsUZgeWc48gl0hS/V0vFSMZprzEpT+hHmJcbeUGCys0b5xavHK8W7uFn3FsVCtN1Bn i2vwf6aVZzy4Cak10L0wXDlJ9df8GVSctj5p9xrhT1E88ZS0An5vEgmJPVBxEmW8714+ McxGA6LJL9BQoyfJ/FA6aGWruoCBaGzBbQx32/hNzELW/we6USPXcwhwAl7QFVVPmxTc 0OVKv+9fGEtYa8P1+5s12bPu233hDh7HBlKtnBrMMjxSKtUQXShiLybehZ2Jp90D347F IB0iws0QymTPmodqcBzYOtPb91cxYlir72YsNI5SmHNtkTGUbh/bCcNIlg3xcAjWSZuH aMTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733384155; x=1733988955; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WvH877pC4ZxhaBRp795GhEOSYIbthskiXMSpAZnT5Nk=; b=lBXXjEhYhsuX7Wa28d8BDGodIFx3RrN2lxbfCCHpNyVfFyi1qrnLrAriYnsfDNeSXc IQ697+F5t2K7l+LyQkJMuSiDjSSkAwHkjyg2GNFgwpwXmAMOUVtQCUcVi6RXNXrpjQXF Hr2KROwYtEijGQ+KIJJUFxFQ1WYi6FDQngsg7Jqpdwja8rkPyyG0rRSlRgCD28W5GAMk pblzq2DRJAnmTyp7ho6BDr0IQ4oxMCpMMMyVhnYc96vbUiOpJ7AvPZC5Cwz7dVdNvzGM Nc1TSpTCDrIhX+xsZMUAST98g2TQMr2oY6UDTpQm+jQrCo8OUXPAnV+wuHle0IELveKO KBcg== X-Gm-Message-State: AOJu0Yw7PZ6q+4HZpoxSPMi83Jo/EyC3NPXHoHwyWpfdipKW3YY36qmO 4e+Ef685PsBnE0ko3mjlmq/xWzA1soLoO73uw/Fpf6URNOcGSDDGiDqXDlzt X-Gm-Gg: ASbGncu5gayUg9lELM8mUhkzdWALpLiKplm7qoJod1euHpoMZIEbJd+77RS2Ctf5P75 QbPf7oxNlv5njE0ZMnCXl2M4gOrsPxQL7eiw+nFkl6Ej2P6PzqZw0SoTjmO172lspR4ny7xhDUT QfEPHIEheOeqTeMRHBYvErsl46etmeKiRJqvfeHKAr7pkxHIJHDonaoAI4eCsOw0SwOzJx8R6zm 1vwSHkHcLBbGPcJ0kmXNN3daBuMIe0EBIHdvhSmSJc/1eo= X-Google-Smtp-Source: AGHT+IFAkdAwiuwBfzy59mjlwiyWJHf1O3vcg1b/8t38iBKDaatHl0O3WZpnOnsoBW69evIwe2A6Ig== X-Received: by 2002:a05:600c:45ce:b0:431:60ec:7a91 with SMTP id 5b1f17b1804b1-434d4100a3fmr57587035e9.2.1733384154834; Wed, 04 Dec 2024 23:35:54 -0800 (PST) Received: from localhost ([141.226.9.46]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434da113670sm14119035e9.28.2024.12.04.23.35.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Dec 2024 23:35:53 -0800 (PST) Date: Thu, 5 Dec 2024 09:35:51 +0200 From: Efraim Flashner To: guix-devel@gnu.org Cc: Tomas Volf <~@wolfsden.cz> Subject: Re: Regarding the vertical alignment in the record definitions Message-ID: Mail-Followup-To: guix-devel@gnu.org, Tomas Volf <~@wolfsden.cz> References: <87frn538q2.fsf@wolfsden.cz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6yJJVKgy19EIed84" Content-Disposition: inline In-Reply-To: <87frn538q2.fsf@wolfsden.cz> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=efraim.flashner@gmail.com; helo=mail-wm1-x329.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: 2.95 X-Spam-Score: 2.95 X-Migadu-Queue-Id: 5FA998A400 X-TUID: ES/kmA9akMAk --6yJJVKgy19EIed84 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 03, 2024 at 01:34:29AM +0100, Tomas Volf wrote: >=20 > Hello Guix, >=20 > I would like to bring up for debate the convention the project has of > vertically aligning the record definitions. While I agree it lead to > visually pleasing code, I also leads to significantly bloated diffs. >=20 > While some amount of noise in diffs is expected in any lisp language > (the trailing `)'), the vertical aligning makes it worse. It (in my > opinion) complicates both reviewing and re-basing (due to merge > conflicts). >=20 > For example, take this patch I sent today. It adds *a single field* to > the record. However the patch (that someone needs to review and make > sure is correct) looks like this: >=20 > --8<---------------cut here---------------start------------->8--- > @@ -1246,44 +1247,49 @@ (define-deprecated (agetty-service config) > (define-record-type* > mingetty-configuration make-mingetty-configuration > mingetty-configuration? > - (mingetty mingetty-configuration-mingetty ;file-like > - (default mingetty)) > - (tty mingetty-configuration-tty) ;string > - (auto-login mingetty-configuration-auto-login ;string | #f > - (default #f)) > - (login-program mingetty-configuration-login-program ;gexp > - (default #f)) > - (login-pause? mingetty-configuration-login-pause? ;Boolean > - (default #f)) > - (clear-on-logout? mingetty-configuration-clear-on-logout? ;Boolean > - (default #t)) > - (delay mingetty-configuration-delay ;Integer | #f > - (default #f)) > - (print-issue mingetty-configuration-print-issue ;Boolean | Symbol > - (default #t)) > - (print-hostname mingetty-configuration-print-hostname ;Boolean | Sym= bol > - (default #t)) > - (nice mingetty-configuration-nice ;Integer | #f > - (default #f)) > - (chdir mingetty-configuration-chdir ;String | #f > - (default #f)) > - (chroot mingetty-configuration-chroot ;String | #f > - (default #f))) > + (mingetty mingetty-configuration-mingetty ;file-like > + (default mingetty)) > + (tty mingetty-configuration-tty) ;string > + (auto-login mingetty-configuration-auto-login ;string | #f > + (default #f)) > + (login-program mingetty-configuration-login-program ;gexp > + (default #f)) > + (login-pause? mingetty-configuration-login-pause? ;Boolean > + (default #f)) > + (clear-on-logout? mingetty-configuration-clear-on-logout? ;Boolean > + (default #t)) > + (delay mingetty-configuration-delay ;Integer | #f > + (default #f)) > + (print-issue mingetty-configuration-print-issue ;Boolean | Sy= mbol > + (default #t)) > + (print-hostname mingetty-configuration-print-hostname ;Boolean |= Symbol > + (default #t)) > + (nice mingetty-configuration-nice ;Integer | #f > + (default #f)) > + (chdir mingetty-configuration-chdir ;String | #f > + (default #f)) > + (chroot mingetty-configuration-chroot ;String | #f > + (default #f)) > + (shepherd-requirement mingetty-configuration-shepherd-requirement > + ;; Since the login prompt shows the host name, w= ait > + ;; for the 'host-name' service to be done. Also= wait > + ;; for udev essentially so that the tty text is = not > + ;; lost in the middle of kernel messages (XXX). > + (default '( user-processes host-name udev > + virtual-terminal)))) > --8<---------------cut here---------------end--------------->8--- >=20 > But it could have look like this: >=20 > --8<---------------cut here---------------start------------->8--- > @@ -1268,23 +1269,27 @@ (define-record-type* > (working-directory mingetty-configuration-working-directory ;String | = #f > (default #f)) > (root-directory mingetty-configuration-root-directory ;String | #f > - (default #f))) > + (default #f)) > + (shepherd-requirement mingetty-configuration-shepherd-requirement > + ;; Since the login prompt shows the host name, w= ait > + ;; for the 'host-name' service to be done. Also= wait > + ;; for udev essentially so that the tty text is = not > + ;; lost in the middle of kernel messages (XXX). > + (default '( user-processes host-name udev > + virtual-terminal)))) > --8<---------------cut here---------------end--------------->8--- >=20 > I would like to hear what people who review lot of patches think about > this. Does it make your life worse? Does it not matter? Or does it > even help you in some way? >=20 > Thank you for your time and have a nice day, > Tomas I agree it makes for a more bloated diff, but it does make it easier to read when the indentation doesn't change between each field. What if it were formatted like this? No gratuitous white space changes for formatting and more room for code and comments since it's not smushed on the right side of the screen. --8<---------------cut here---------------start------------->8--- @@ -1268,23 +1269,28 @@ (define-record-type* (working-directory mingetty-configuration-working-directory ;String | #f (default #f)) (root-directory mingetty-configuration-root-directory ;String | #f - (default #f))) + (default #f)) + (shepherd-requirement + mingetty-configuration-shepherd-requirement + ;; Since the login prompt shows the host name, wait + ;; for the 'host-name' service to be done. Also wait + ;; for udev essentially so that the tty text is not + ;; lost in the middle of kernel messages (XXX). + (default '(user-processes host-name udev + virtual-terminal)))) --8<---------------cut here---------------end--------------->8--- --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --6yJJVKgy19EIed84 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmdRV9QACgkQQarn3Mo9 g1H+XQ//aY5fC046J8M5ZBWXLQT83MWiuvvvLAugxzQnFy1gH/aKyJHE/msVAWxw /Vwv/UqUszlzos9StzkTJtxpCgzpMfTc0FWhZX8J23loF4/FgZY9fiu1A9ln3Qc3 RoWbaKOlnDfEPkYzVDQ6QRKXKZPCDuQG2F4ud7P03CMOSq89WwCjmLD/DsA6jipv kkHVG3djPx+tFSgEOHk1Y6FSzPcaDTMBx2d2+aKMjn6rFQUXUFPT78BxvDeCV3uD 6Q2C/CxBeTRnc2iRHVkF/MK2Lq6EFGmkqQC7EV1OYbKtRpLJdQM/60IBauRvUNGX 5XwhC9sWBPa+edgXvzdPbbdLCOrOoGrLc7NdUGg4bLyO2fFKgIlqbtNOJ3cUv1ew 9DsF/gNZyOxlL4YntC25OJd/5nkwTiuyKjCMopfDNq5rPawkruTg7rwtjV8vXOCj 9JjiiijIID4mD5C0sBVs9tum7rTlEsJdhNKZvWpZ51JoMu+d5jpXnPxrj0XxtGZs +Md5MZXKxTBQh1VV75WsDMa/lw5QGVUJFvysf+o+QL/oqp0JUJGJgYHh8GbYP/8+ ELdcNJbMkooeqW8Vt5mgfWaraPL02zT2xs3uT5gAsQxMhk2nAz1ZTbJ4Fv3jSQeV R1/U98/qYS8rvUNmxnP+BdYbeWEaNAWN3qQ7/s5+Zj/kQeo+ABg= =l00z -----END PGP SIGNATURE----- --6yJJVKgy19EIed84--