Re: ‘gnu: Add go-github-com-niemeyer-pretty.’

Re: ‘gnu: Add go-github-com-niemeyer-pretty.’

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 603 bytes --]

> + (define-public go-github-com-niemeyer-pretty
> +  (package
> +    (name "go-github-com-niemeyer-pretty")
> +    (version "0.0.0-20200227124842-a10e7caefd8e")
> +    (source
> +      (origin
> +        (method git-fetch)
> +        (uri (git-reference
< +               (url "https://github.com/niemeyer/pretty")
> +               (commit (go-version->git-ref version))))

Why package the fork niemeyer/pretty instead of upstream kr/pretty?
Also, where does this version number come from?  Looking at pkg.go.dev,
the version number is 0.3.0, not 0.3.0-$foo-$bar.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

Re: ‘gnu: Add go-github-com-niemeyer-pretty.’

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1330 bytes --]

On Sun, Mar 06, 2022 at 03:32:09PM +0100, Maxime Devos wrote:
> > + (define-public go-github-com-niemeyer-pretty
> > +  (package
> > +    (name "go-github-com-niemeyer-pretty")
> > +    (version "0.0.0-20200227124842-a10e7caefd8e")
> > +    (source
> > +      (origin
> > +        (method git-fetch)
> > +        (uri (git-reference
> < +               (url "https://github.com/niemeyer/pretty")
> > +               (commit (go-version->git-ref version))))
> 
> Why package the fork niemeyer/pretty instead of upstream kr/pretty?
> Also, where does this version number come from?  Looking at pkg.go.dev,
> the version number is 0.3.0, not 0.3.0-$foo-$bar.

The package is one of the dependencies for one of the dependencies of
gitea.  That said, Upon double-checking that package¹² it doesn't seem
that it actually needs it directly, and when I comment out the package
go-github-com-go-git-go-billy-v5 builds just fine, and so does my copy
of gitea. Looks like this package isn't needed after all.

¹ github.com/go-git/go-billy/v5
² https://github.com/go-git/go-billy/blob/v5.3.1/go.mod


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]