From: Efraim Flashner <efraim@flashner.co.il>
To: Maxime Devos <maximedevos@telenet.be>
Cc: guix-devel@gnu.org
Subject: Re: ‘gnu: Add go-github-com-niemeyer-pretty.’
Date: Tue, 8 Mar 2022 09:37:35 +0200 [thread overview]
Message-ID: <YicHv/0Lu2kdpj5D@3900XT> (raw)
In-Reply-To: <d182de629b13f375ae622e151e59263bb0596e5a.camel@telenet.be>
[-- Attachment #1: Type: text/plain, Size: 1330 bytes --]
On Sun, Mar 06, 2022 at 03:32:09PM +0100, Maxime Devos wrote:
> > + (define-public go-github-com-niemeyer-pretty
> > + (package
> > + (name "go-github-com-niemeyer-pretty")
> > + (version "0.0.0-20200227124842-a10e7caefd8e")
> > + (source
> > + (origin
> > + (method git-fetch)
> > + (uri (git-reference
> < + (url "https://github.com/niemeyer/pretty")
> > + (commit (go-version->git-ref version))))
>
> Why package the fork niemeyer/pretty instead of upstream kr/pretty?
> Also, where does this version number come from? Looking at pkg.go.dev,
> the version number is 0.3.0, not 0.3.0-$foo-$bar.
The package is one of the dependencies for one of the dependencies of
gitea. That said, Upon double-checking that package¹² it doesn't seem
that it actually needs it directly, and when I comment out the package
go-github-com-go-git-go-billy-v5 builds just fine, and so does my copy
of gitea. Looks like this package isn't needed after all.
¹ github.com/go-git/go-billy/v5
² https://github.com/go-git/go-billy/blob/v5.3.1/go.mod
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-03-08 8:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-06 14:32 ‘gnu: Add go-github-com-niemeyer-pretty.’ Maxime Devos
2022-03-08 7:37 ` Efraim Flashner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YicHv/0Lu2kdpj5D@3900XT \
--to=efraim@flashner.co.il \
--cc=guix-devel@gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).