From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id IJiwLfq1xGGnNQAAgWs5BA (envelope-from ) for ; Thu, 23 Dec 2021 18:46:34 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id AG1aKfq1xGEKEwAAB5/wlQ (envelope-from ) for ; Thu, 23 Dec 2021 17:46:34 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 82EB6E324 for ; Thu, 23 Dec 2021 18:46:34 +0100 (CET) Received: from localhost ([::1]:33760 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n0SAj-0004eO-M6 for larch@yhetil.org; Thu, 23 Dec 2021 12:46:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40624) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0SAS-0004dQ-Sw for guix-devel@gnu.org; Thu, 23 Dec 2021 12:46:17 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:35709) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0SAR-0003i4-1k for guix-devel@gnu.org; Thu, 23 Dec 2021 12:46:16 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 27BC83200BF9; Thu, 23 Dec 2021 12:46:12 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 23 Dec 2021 12:46:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:subject:message-id:mime-version:content-type; s= mesmtp; bh=5rxFJ4X9UaPBnRd677MzEVzmzRaFI7O/uf4tDnkZ7AU=; b=ITEBo NbsLeZFqWtj1paBKgZnzNE9MZATuP6c9cutayzA4uFgXaRN8Z+3FNB4N075FlWxV 5z3gDea5k6PlsFbfkqiOgJVm4mr5PlZKp0zpIM/f2na29xc6Yfpj78glphB0UfaO k1Le6vw8RH06kRuECNjuptqld8sDf4Bx/6U1Rs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=5rxFJ4X9UaPBnRd677MzEVzmzRaFI 7O/uf4tDnkZ7AU=; b=KHLfRZK32z4WwbVnj/6xwCgwppk5ww1K/buiXFz0hXEuh a/ApTiwvX45z5EUrK46JpTqk4CSeaU2ZgCTh6Q8xcULbYrLeWfNZi+jIPzkA5I2Z 5XIlTJHQETTjKpHxKx85tJ79L0MsPht/uQq5H5mnTYGE8I4iWRVu8XLtLNT0JZur Rr2suESNuYflH5v+xwRsEdFfBLP1481ZmNTu3PGF+q5rZbjHIk25pkJIpZKx0Cd3 Nf5PGkVpd15Eiwp5Lly2VWFLTixII3llYl3Llf8bEmhf0xlJxu9R9DUFWXtNG6KA k6W2oHDPYtApo21mTkReRKBTiZ1kbCMpQyiIDk/Qg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddtkedguddthecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfggtggusehttdertd dttddvnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghr ihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeeuieduieejudffvdfhjedvgedvhefggf ejvdevkeeffeelfeekueeijeduveetudenucffohhmrghinhepghhnuhdrohhrghenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrg hmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Thu, 23 Dec 2021 12:46:11 -0500 (EST) Date: Thu, 23 Dec 2021 12:46:09 -0500 From: Leo Famulari To: guix-devel@gnu.org Subject: search-input-file vs (assoc-ref inputs) Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=64.147.123.24; envelope-from=leo@famulari.name; helo=wout1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640281594; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=5rxFJ4X9UaPBnRd677MzEVzmzRaFI7O/uf4tDnkZ7AU=; b=N9nrdw9i7lv+D6R4h3IbTkBWumNf1DZg/dWlbi+v9p7dcLHOsWNKUbcdG6cFxugpcH49X2 CzvcdrKqnZItkegy6BI3Psm+O9b8O8GK9qQrYJJdJrJxM/rqkqHTn4QxC787Nx5FfsxNER /H4L+T5hhu1cmEhdt+E+0VML9Ceued0u6pu24wA53weRsiqIZYAs+QyMNz1ZCUJN8yELQl 6BFy8BDroJVRF0Pdsf1dSrckHMA2lbjbO2GZj8MpgN960QVLDjPVfTpw+KvvU4fKyMGbda 9rQT4drLhrjiyWzd42MHYm3uG3rx2D6Ab8GwnESI4G76HKfvqBgFZTres+6o2w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640281594; a=rsa-sha256; cv=none; b=rnfb7sSY7tyOi+jiUz0pz+aDkd+E8ycg0tytUqWoceDhFx1zy5ZIXqUwppAXduo+LYrgbS vqyOEvGhWhtKJA+vRbZ+ocCmenn27RMfubf/pwPKmYRtXD7NG/4IS17etTTW+sMlpX19A7 UdOWqs0uZ/W0F786e4fPwGZEEjz4rKZuZ02esxlh3pD4HlRgdJ913cqGyUpp2k+2iag5oh JlUPPe7F4KlQHz9pzuQEtMU+jSc9u0YAkNcOruaa4yy2QQQcTJeOfa5fW6y2YlRTorZJjE BqgQqdfdPfNA1/bpg52F6rtCMGOat0W9x8+wyYaIpgIugyZPEKeGrfyYVT7i0w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=famulari.name header.s=mesmtp header.b="ITEBo Nb"; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=KHLfRZK3; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -10.55 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=famulari.name header.s=mesmtp header.b="ITEBo Nb"; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=KHLfRZK3; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 82EB6E324 X-Spam-Score: -10.55 X-Migadu-Scanner: scn0.migadu.com X-TUID: ez1rJQjjACxD I noticed that, as part of the transition to the new inputs style [0], we are sometimes replacing code like (assoc-ref inputs "foo") with (search-input-file inputs "/bin/foo"). I think that we should instead replace the old style with gexps that specify which package, in order to keep the equivalent functionality. Otherwise, we risk regressions, when the code finds a match for the desired filename in the wrong input. I would say that (search-input-file) is a replacement for the Guile (which) procedure. On the other hand, we can replace (assoc-ref inputs ...) with (this-package-input "foo"). What do you think? [0] https://guix.gnu.org/en/blog/2021/the-big-change/